From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>,
jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, ihkose@gmail.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, rajat.khandelwal@intel.com
Subject: Re: [PATCH v2] dt-bindings: iio: dac: Change the I2C slave address for ds4422/4424 to its correct value
Date: Tue, 11 Oct 2022 08:10:29 -0400 [thread overview]
Message-ID: <1ce4ba01-074e-861a-e4f0-d5a0c9cc1fc3@linaro.org> (raw)
In-Reply-To: <20221012074446.726409-1-rajat.khandelwal@linux.intel.com>
On 12/10/2022 03:44, Rajat Khandelwal wrote:
> The datasheet states that the slave address for the device is 0x20
> when the pins A0 and A1 are ground. The DT binding has been using
> 0x10 as the value and I think it should be 0x20 as per datasheet.
>
> Signed-off-by: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
> ---
>
> v2:
> 1. Subject prefix added
> 2. DT bindings validated
No, still wrong. Nothing was validated.
>
> Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
> index 264fa7c5fe3a..1955b1a97cd6 100644
> --- a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
> @@ -38,7 +38,7 @@ examples:
>
> dac@10 {
> compatible = "maxim,ds4424";
> - reg = <0x10>; /* When A0, A1 pins are ground */
> + reg = <0x20>; /* When A0, A1 pins are ground */
Nothing improved here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-11 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 7:44 [PATCH v2] dt-bindings: iio: dac: Change the I2C slave address for ds4422/4424 to its correct value Rajat Khandelwal
2022-10-11 12:10 ` Krzysztof Kozlowski [this message]
2022-10-11 13:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ce4ba01-074e-861a-e4f0-d5a0c9cc1fc3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ihkose@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajat.khandelwal@intel.com \
--cc=rajat.khandelwal@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).