From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8531CC433FE for ; Tue, 11 Oct 2022 12:10:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbiJKMKf (ORCPT ); Tue, 11 Oct 2022 08:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiJKMKe (ORCPT ); Tue, 11 Oct 2022 08:10:34 -0400 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5EC961DBB for ; Tue, 11 Oct 2022 05:10:32 -0700 (PDT) Received: by mail-qt1-x82e.google.com with SMTP id cj27so8057840qtb.7 for ; Tue, 11 Oct 2022 05:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=POhII6F19HL9Jpz6l44lNoHqeI4O0KAnr15FsZzwSiw=; b=Gouqkf6y4M8S9bLJeUpRlj8ohNfnLapgEO84M6R9JakMD0N8Gif2k0bjnUix+nJlaY aigoLLsJhgckgsN37lxvsEeqheN/PjCikGZ1B8SZg3c+eyAuxMXcC9P43VcDydwt7TGb QczR4Oxg6MkLL5+9j+5Y1Dh6DsrM3h9vr0gTbjZsj3q4iQMjS5cYcH9zksxNM26r2QHj Vv38OgOKo99a8stbTioxeZtSdtvpjMBklsJu74Td4LYLLgE8Nr07wglT71hOkUpF0GNh Sj0fwxy9YLamX50oOY9oWLOMnPJ4c1KlgWS14r+AOmcUjzwC5doJPjO3PXyyEq+Ya4Vo +U7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=POhII6F19HL9Jpz6l44lNoHqeI4O0KAnr15FsZzwSiw=; b=TB8a5WZ1CQZcU73aaWl6KSgKZGONSFQLXnQqNSj393o+YGviNfbEDRR05bk7Ac7otc TmdwH8MsnuHETuuRnC+GfoRfJ8ItbtPA7CSDXqUf8PmG0Z+EH8ESbXCm5T1kTeTcSZy4 moROYVrpJG3MTZGhG/w7/YzIAkHsJl84Z/rCKhai3AJH3M0NMmilaouaordhO+qlx+i/ cJ8tSlWUImKg0s8wBgS4RxjguikWVZ41R7Egmff1llsX7NoQcnjIQyvLWZWYF1U3P8Z5 j9LC9ZklbqYJTrakRo9Mh6A85Hhf9jhc7nhccBpNkK/BiFka+bFel5/cwTpEVxTA4V1v aM2A== X-Gm-Message-State: ACrzQf1EfUvFJQxgz3vgUlRar4OJmz6Hr5lHt9M5ueXjpMmIaFoZmn3o V/fI/Bhwstwf4nxUhex5nDYOig== X-Google-Smtp-Source: AMsMyM7zwLeaJwvx/qel0Do5JwTShDJSJhZp+q0wSCJHuxPlW2h1f5744flplIf8q7XZ16GfSLeDsg== X-Received: by 2002:ac8:5f93:0:b0:394:13a:8ffe with SMTP id j19-20020ac85f93000000b00394013a8ffemr18530275qta.9.1665490231977; Tue, 11 Oct 2022 05:10:31 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id f14-20020a05620a280e00b006be8713f742sm12771153qkp.38.2022.10.11.05.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 05:10:31 -0700 (PDT) Message-ID: <1ce4ba01-074e-861a-e4f0-d5a0c9cc1fc3@linaro.org> Date: Tue, 11 Oct 2022 08:10:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2] dt-bindings: iio: dac: Change the I2C slave address for ds4422/4424 to its correct value Content-Language: en-US To: Rajat Khandelwal , jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, ihkose@gmail.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rajat.khandelwal@intel.com References: <20221012074446.726409-1-rajat.khandelwal@linux.intel.com> From: Krzysztof Kozlowski In-Reply-To: <20221012074446.726409-1-rajat.khandelwal@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/10/2022 03:44, Rajat Khandelwal wrote: > The datasheet states that the slave address for the device is 0x20 > when the pins A0 and A1 are ground. The DT binding has been using > 0x10 as the value and I think it should be 0x20 as per datasheet. > > Signed-off-by: Rajat Khandelwal > --- > > v2: > 1. Subject prefix added > 2. DT bindings validated No, still wrong. Nothing was validated. > > Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml > index 264fa7c5fe3a..1955b1a97cd6 100644 > --- a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml > @@ -38,7 +38,7 @@ examples: > > dac@10 { > compatible = "maxim,ds4424"; > - reg = <0x10>; /* When A0, A1 pins are ground */ > + reg = <0x20>; /* When A0, A1 pins are ground */ Nothing improved here. Best regards, Krzysztof