From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC3EC433FE for ; Sun, 17 Apr 2022 17:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231299AbiDQSAl (ORCPT ); Sun, 17 Apr 2022 14:00:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230373AbiDQSAl (ORCPT ); Sun, 17 Apr 2022 14:00:41 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E9B11AF1C for ; Sun, 17 Apr 2022 10:58:04 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id t11so23489418eju.13 for ; Sun, 17 Apr 2022 10:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nSubeHyIkbDyezCXTtI5pe5KWL/Nm+X5yHUcXHqauxY=; b=KmCxtqwiDxG8GCSszSnyyyohTIwtJgrR4dUoq6Pfw2NqgZdygFjyj52fymLpmFKQyV o1D/vivFHFxicCfzDfW2EdM5J1v7O0OsXJUF3UJhWq9NTWJDMwaCar9U4Yh6/o0wc+PI 85xJa78Im2Lp7png/Ov+RZ3TQZdRvx1ByVbt1flSmuoYsi4//TUWig18ZBv/nqedKgm0 heXVjbAGS90FAg9SFPZZMv4aBG/o+oHmzpswH931UpQXPd+Vt4h2ibwDESMDVYyjPN08 o4X/bShbg7lG7u+Cv9wZrJf7GOwbQKFzT3aG9hxhfmd+ZRdEI0MY+PsbNoef/hz1LuP+ +yZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nSubeHyIkbDyezCXTtI5pe5KWL/Nm+X5yHUcXHqauxY=; b=OAvsBSIrYrj1GPcDsf/y9BEcG6+KjEEoi+wl2bEu5eAYK0dPVdtrjiRkUAtGGP7tlw jaag2bjwE0FzGJy8ke8eWk8GpZUwmK+PAlF6QeZvkJClIrsjXJQmq8hbcJGsiN4Uh64m rfthV2xITOjHxdaqJJFQrIFf1WL3LEAT/lq7RT8dY5cHn9wBwGr7dapvJTiH3lSOpQuw hRnRjRSDNDQ2umUskg60MjY19WneGyQg1pd5HpOORd69cRwkW/l14VwFPkXByRYfo1LC 9OS137C/tEtuDW5dT+B/5fmLLjTGjtGCfGBNRaYpTvi9/3LC8SIzDyYN9WqaaseL7A1C l8og== X-Gm-Message-State: AOAM531zeegEi5q1jQSM0yft3aCzzfArPfLu5RAyLyRQqpTgLjg7hohD 0MND5hEu1oY6XkP0ZgcibM5L9Q== X-Google-Smtp-Source: ABdhPJwn4RYMuzx1OPkO0KuwJKryizP0RNdSa0rqni5YB3lwpEj/clUpmf0tuoUU1d7TDzbh6UlCZg== X-Received: by 2002:a17:906:c113:b0:6d7:7b53:9cb with SMTP id do19-20020a170906c11300b006d77b5309cbmr6634960ejc.197.1650218283093; Sun, 17 Apr 2022 10:58:03 -0700 (PDT) Received: from [192.168.0.216] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id bf11-20020a0564021a4b00b00423e997a3ccsm80153edb.19.2022.04.17.10.58.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 10:58:02 -0700 (PDT) Message-ID: <1cecb0c3-2925-765f-0654-37d5703b75b8@linaro.org> Date: Sun, 17 Apr 2022 19:58:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible Content-Language: en-US To: Nishanth Menon Cc: Santosh Shilimkar , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220407143140.295092-1-krzysztof.kozlowski@linaro.org> <20220407143140.295092-2-krzysztof.kozlowski@linaro.org> <20220415185439.4hsfnllhplfcpwvk@encrypt> From: Krzysztof Kozlowski In-Reply-To: <20220415185439.4hsfnllhplfcpwvk@encrypt> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/04/2022 20:54, Nishanth Menon wrote: > > I have no idea how this works. There is no documentation for the > compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor"; Compatible is documented in jedec,spi-nor.yaml (through pattern), although it should be followed by "jedec,spi-nor", according to schema. I did not fix that missing compatible fallback, because I did not want to break any setup (I cannot test it), but adding the fallback seems harmless/safe. > > $ git grep micron,n25q128a11 . > arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11"; > arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > > Best regards, Krzysztof