From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Emanuele Ghidoli <ghidoliemanuele@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v1] arm64: dts: colibri-imx8x: Add ad7879_ts label to touchscreen controller
Date: Mon, 16 Sep 2024 18:10:55 +0200 [thread overview]
Message-ID: <1cfe3f3a-28a3-4030-b6ba-3892a2a7bc79@linaro.org> (raw)
In-Reply-To: <20240910152213.2072743-1-ghidoliemanuele@gmail.com>
On 10/09/2024 17:22, Emanuele Ghidoli wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
>
> The device tree defines the touchscreen controller, but it cannot be
> enabled because it lacks a reference label.
It can be. Just enable it...
> This commit adds a label to allow it to be referenced and enabled.
>
You changed here nothing. For me this patch is churn and pointless.
You add the label when you need to use it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-16 16:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 15:22 [PATCH v1] arm64: dts: colibri-imx8x: Add ad7879_ts label to touchscreen controller Emanuele Ghidoli
2024-09-16 16:10 ` Krzysztof Kozlowski [this message]
2024-09-17 7:45 ` Francesco Dolcini
2024-09-17 8:21 ` Krzysztof Kozlowski
2024-09-17 13:29 ` Francesco Dolcini
2024-10-16 7:34 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cfe3f3a-28a3-4030-b6ba-3892a2a7bc79@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=emanuele.ghidoli@toradex.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=ghidoliemanuele@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).