From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gary Yang <gary.yang@cixtech.com>
Cc: "robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
Peter Chen <peter.chen@cixtech.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
cix-kernel-upstream <cix-kernel-upstream@cixtech.com>
Subject: Re: 回复: [PATCH v9 1/3] dt-bindings: soc: cix: document the syscon on Sky1 SoC
Date: Wed, 25 Feb 2026 12:46:04 +0100 [thread overview]
Message-ID: <1d0f36ef-0647-4f7a-a42e-2c2cfc31307a@kernel.org> (raw)
In-Reply-To: <PUZPR06MB58873921FCCC1B9B34F2C683EF75A@PUZPR06MB5887.apcprd06.prod.outlook.com>
On 25/02/2026 12:15, Gary Yang wrote:
> Hi Krzysztof:
>
> I'm sorry for my mistakes.
>
>> EXTERNAL EMAIL
>>
>> On 25/02/2026 11:29, Krzysztof Kozlowski wrote:
>>> On Tue, Feb 24, 2026 at 05:21:09PM +0800, Gary Yang wrote:
>>>> +
>>>> +additionalProperties: false
>>>> +
>>>> +examples:
>>>> + - |
>>>> + syscon@16000000 {
>>>> + compatible = "cix,sky1-s5-system-control", "syscon";
>>>> + reg = <0x16000000 0x1000>;
>>>> + #reset-cells = <1>;
>>>> + };
>>>> diff --git a/include/dt-bindings/reset/cix,sky1-rst-fch.h
>> b/include/dt-bindings/reset/cix,sky1-rst-fch.h
>>>
>>> I am not going to repeat my reviews.
>>
>> Quoting myself last time from second email:
>>
>> "It's the last time I am asking you of it"
>>
>>>
>>> NAK, I mark it as changes requested in Patchwork.
>>>
>>> Krzysztof
>>>
>>
>
> Sorry for missing your advices. We just come back from the Chinese New Year Festival.
> It almost takes two weeks, so we forget your advices. Do you mean that cix,sky1-rst-fch.h
> should be named cix,sky1-system-control.h and cix,sky1-rst.h should be named cix,sky1-s5-system-control.h?
> Are there other advices forgot, except this one? Please give us one more chances.
>
> If miss any information, please let us know. Thanks
The same filename as used for binding.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-25 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 9:21 [PATCH v9 0/3] Add support for Cix Sky1 resets Gary Yang
2026-02-24 9:21 ` [PATCH v9 1/3] dt-bindings: soc: cix: document the syscon on Sky1 SoC Gary Yang
2026-02-25 10:29 ` Krzysztof Kozlowski
2026-02-25 10:30 ` Krzysztof Kozlowski
2026-02-25 11:15 ` 回复: " Gary Yang
2026-02-25 11:46 ` Krzysztof Kozlowski [this message]
2026-02-24 9:21 ` [PATCH v9 2/3] reset: add Sky1 soc reset support Gary Yang
2026-02-24 10:12 ` Philipp Zabel
2026-02-24 10:34 ` 回复: " Gary Yang
2026-02-24 9:21 ` [PATCH v9 3/3] arm64: dts: cix: add support for cix sky1 resets Gary Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d0f36ef-0647-4f7a-a42e-2c2cfc31307a@kernel.org \
--to=krzk@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gary.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox