From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 01/15] dt-bindings: PCI: qcom: Fix sc8180x clocks and interrupts
Date: Thu, 1 Jun 2023 09:25:51 +0200 [thread overview]
Message-ID: <1d1b42e9-dbc2-263e-b937-b12e961f892a@linaro.org> (raw)
In-Reply-To: <ZHhG4LOgfYgWbFt7@matsya>
On 01/06/2023 09:21, Vinod Koul wrote:
> On 31-05-23, 10:19, Krzysztof Kozlowski wrote:
>> On 30/05/2023 18:24, Vinod Koul wrote:
>>> Commit 45a3ec891370 ("PCI: qcom: Add sc8180x compatible") added sc8180x
>>> compatible and commit 075a9d55932e ("dt-bindings: PCI: qcom: Convert to
>>> YAML") converted the description to yaml
>>>
>>> But there are still some errors specific to sc8180x which this change
>>> attempts to fix. The clocks and resets for sc8180 pcie controller are
>>> different so need to be documented separately
>>
>> I don't get what's the error here to fix. The clocks you list are
>> already there as part of oneOf.
>
> It was listed with sm8150 block which has different set of clocks than
> used in sc81880x, so this needs to have its own block of clocks and
> resets
Ah, after careful check I see indeed difference in one clock.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-01 7:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 16:24 [PATCH v3 00/15] Introduce the SC8180x devices Vinod Koul
2023-05-30 16:24 ` [PATCH v3 01/15] dt-bindings: PCI: qcom: Fix sc8180x clocks and interrupts Vinod Koul
2023-05-31 8:19 ` Krzysztof Kozlowski
2023-06-01 7:21 ` Vinod Koul
2023-06-01 7:25 ` Krzysztof Kozlowski [this message]
2023-06-01 7:26 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 02/15] dt-bindings: usb: qcom,dwc3: Add SC8180x binding Vinod Koul
2023-05-31 8:19 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema Vinod Koul
2023-05-31 8:22 ` Krzysztof Kozlowski
2023-06-01 7:23 ` Vinod Koul
2023-06-01 7:26 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 04/15] scsi: ufs: dt-bindings: Add SC8180x binding Vinod Koul
2023-05-31 8:24 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 05/15] dt-bindings: qcom,pdc: Add SC8180x compatible Vinod Koul
2023-05-31 8:24 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 06/15] arm64: dts: qcom: Introduce the SC8180x platform Vinod Koul
2023-05-30 16:24 ` [PATCH v3 07/15] arm64: dts: qcom: sc8180x: Add interconnects and lmh Vinod Koul
2023-05-31 8:26 ` Krzysztof Kozlowski
2023-06-01 7:17 ` Vinod Koul
2023-06-01 13:27 ` Bjorn Andersson
2023-06-01 15:27 ` Krzysztof Kozlowski
2023-06-10 16:24 ` Bjorn Andersson
2023-05-30 16:24 ` [PATCH v3 08/15] arm64: dts: qcom: sc8180x: Add thermal zones Vinod Koul
2023-05-30 16:24 ` [PATCH v3 09/15] arm64: dts: qcom: sc8180x: Add QUPs Vinod Koul
2023-05-30 16:24 ` [PATCH v3 10/15] arm64: dts: qcom: sc8180x: Add PCIe instances Vinod Koul
2023-05-30 16:24 ` [PATCH v3 11/15] arm64: dts: qcom: sc8180x: Add remoteprocs, wifi and usb nodes Vinod Koul
2023-05-30 16:24 ` [PATCH v3 12/15] arm64: dts: qcom: sc8180x: Add display and gpu nodes Vinod Koul
2023-05-30 16:24 ` [PATCH v3 13/15] arm64: dts: qcom: sc8180x: Add pmics Vinod Koul
2023-06-07 19:31 ` Rob Herring
2023-05-30 16:24 ` [PATCH v3 14/15] arm64: dts: qcom: sc8180x: Introduce Primus Vinod Koul
2023-05-30 16:24 ` [PATCH v3 15/15] arm64: dts: qcom: sc8180x: Introduce Lenovo Flex 5G Vinod Koul
2023-05-30 17:22 ` (subset) [PATCH v3 00/15] Introduce the SC8180x devices Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1b42e9-dbc2-263e-b937-b12e961f892a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).