From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D43C77B7A for ; Thu, 1 Jun 2023 07:26:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231985AbjFAH0L (ORCPT ); Thu, 1 Jun 2023 03:26:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231865AbjFAH0B (ORCPT ); Thu, 1 Jun 2023 03:26:01 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A05A419F for ; Thu, 1 Jun 2023 00:25:55 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5149429c944so898465a12.0 for ; Thu, 01 Jun 2023 00:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685604354; x=1688196354; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fQ8Iw2iCGa9zj3iZr7ZFozqO805VgOcxoKQqsTGIsOI=; b=AYOT3xtsd+O//amhEezrgGaBtJnwib7gI+EnhAmJjLK/lj0xCMgszKY7m3jQJ9mJ9r tB2dzFP7H2mlZuZb3hwu3aedyQjMoTYBZAy1LDVLzr3GYSSg9f5hzBpn65G1qlbqI1us z4HAVdArGfSqbSg/Fjf3oxUPe3nSkHGU+MUauv+gGIFg5YNz1FaVaCGGkBV5ni5XthRM 094SYl5G+zSumdo2gaohmKirbN/uSV2NTNihHyW+Ef0D067jBCVPdKPaJLl7AjeFlzQQ hSSco/FkC7mAkZ4R6y0qt86tDfFMRatSfaBo3pZuYzQxRIstmvCwJyEur31ubsSaw4o0 MUjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685604354; x=1688196354; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fQ8Iw2iCGa9zj3iZr7ZFozqO805VgOcxoKQqsTGIsOI=; b=YW6tSv9JP4yLBpj3UOMQKxbhbKtjG6ojVVpXrXQ9Cc/jbBA0Q/OstMSvrJ2n4S3+Th agYZO96mtXgp7QDrB8HNMH2SXFb/7kpmyOK9gLN9kKbAco8PPbNKzb9vnpLsztX+7r6y nv2jE89O2dgBBa0Yqo1vyZrPitkhJrRCzgylrm0F3LvH4Nxi3Ws9zGeuaiRukL8rWQU6 BFcL3HY35h6+XIHiA2aBjuhyWuD7JvEemzLBEbuEjXBs1nEpS7O5I/IER+0EBdnQIjwm C8SWKKFBqoGZdHElp1kW64uizegAE5Q9LRc7uUj8OpnSICCAJjJ4ACMPV1sMFEERggIu 6r1w== X-Gm-Message-State: AC+VfDySQordPTXimfLW5tVo/ula+lGvTQUJexPGmVywWWh6owarZpun HDu6h6fjOqQRsnEkx35b+DHZMQ== X-Google-Smtp-Source: ACHHUZ7SXG2KxfCd7JaB/XvF7rLw1rxGUqsLf+kqSXRvkmd5jFRBeD/+UCk5Xok6o8WA9obEeLVwxw== X-Received: by 2002:a17:907:7e85:b0:972:aa30:203e with SMTP id qb5-20020a1709077e8500b00972aa30203emr7818275ejc.34.1685604353919; Thu, 01 Jun 2023 00:25:53 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id u8-20020a1709060b0800b0096f920858afsm10109200ejg.102.2023.06.01.00.25.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 00:25:53 -0700 (PDT) Message-ID: <1d1b42e9-dbc2-263e-b937-b12e961f892a@linaro.org> Date: Thu, 1 Jun 2023 09:25:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 01/15] dt-bindings: PCI: qcom: Fix sc8180x clocks and interrupts Content-Language: en-US To: Vinod Koul Cc: Bjorn Andersson , linux-arm-msm@vger.kernel.org, Konrad Dybcio , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230530162454.51708-1-vkoul@kernel.org> <20230530162454.51708-2-vkoul@kernel.org> <4fcbb3b7-ed44-d8e6-a601-e3e957c55ebf@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/06/2023 09:21, Vinod Koul wrote: > On 31-05-23, 10:19, Krzysztof Kozlowski wrote: >> On 30/05/2023 18:24, Vinod Koul wrote: >>> Commit 45a3ec891370 ("PCI: qcom: Add sc8180x compatible") added sc8180x >>> compatible and commit 075a9d55932e ("dt-bindings: PCI: qcom: Convert to >>> YAML") converted the description to yaml >>> >>> But there are still some errors specific to sc8180x which this change >>> attempts to fix. The clocks and resets for sc8180 pcie controller are >>> different so need to be documented separately >> >> I don't get what's the error here to fix. The clocks you list are >> already there as part of oneOf. > > It was listed with sm8150 block which has different set of clocks than > used in sc81880x, so this needs to have its own block of clocks and > resets Ah, after careful check I see indeed difference in one clock. Best regards, Krzysztof