From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Tejun Heo <tj@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-ide@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 01/14] ata: ahci-platform: add reset control support and the flag to specify using reset
Date: Wed, 22 Aug 2018 12:34:30 +0300 [thread overview]
Message-ID: <1d221236-636e-962e-2e4e-3db228689c5e@cogentembedded.com> (raw)
In-Reply-To: <1534923430-9692-2-git-send-email-hayashi.kunihiko@socionext.com>
Hello!
On 8/22/2018 10:36 AM, Kunihiko Hayashi wrote:
> Add support to get and control a list of resets for the device
> as optional and shared. These resets must be kept de-asserted until
> the device is enabled.
>
> This is specified as shared because some SoCs like UniPhier series
> have common reset controls with all ahci controller instances.
>
> However, according to Thierry's view,
> https://www.spinics.net/lists/linux-ide/msg55357.html
> some hardware-specific drivers already use their own resets,
> and the common reset make a path to occur double controls of resets.
>
> Now this add the flag to ahci_platform_get_resources() indicating
> whether to use the resources, currently resets only, and existing
> drivers set 0 to this flags.
>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
[...]
> diff --git a/include/linux/ahci_platform.h b/include/linux/ahci_platform.h
> index 1b0a17b..eaedca5f 100644
> --- a/include/linux/ahci_platform.h
> +++ b/include/linux/ahci_platform.h
> @@ -30,7 +30,7 @@ void ahci_platform_disable_regulators(struct ahci_host_priv *hpriv);
> int ahci_platform_enable_resources(struct ahci_host_priv *hpriv);
> void ahci_platform_disable_resources(struct ahci_host_priv *hpriv);
> struct ahci_host_priv *ahci_platform_get_resources(
> - struct platform_device *pdev);
> + struct platform_device *pdev, unsigned int flags);
That breaks all the users of this API. You should fix the callers in this
same patch to avoid breakage.
[...]
MBR, Sergei
next prev parent reply other threads:[~2018-08-22 9:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 7:36 [PATCH 00/14] ata: ahci-platform: add reset control support except for existing drivers Kunihiko Hayashi
2018-08-22 7:36 ` [PATCH 01/14] ata: ahci-platform: add reset control support and the flag to specify using reset Kunihiko Hayashi
2018-08-22 9:34 ` Sergei Shtylyov [this message]
2018-08-22 10:06 ` Kunihiko Hayashi
2018-08-22 7:36 ` [PATCH 02/14] ata: ahci_brcm: add second argument of ahci_platform_get_resources() Kunihiko Hayashi
2018-08-22 7:36 ` [PATCH 03/14] ata: ahci_ceva: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 04/14] ata: ahci_da850: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 05/14] ata: ahci_dm816: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 06/14] ata: ahci_imx: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 07/14] ata: ahci_brcm: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 08/14] ata: ahci_mvebu: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 09/14] ata: ahci_qoriq: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 10/14] ata: ahci_seattle: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 11/14] ata: ahci_st: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 12/14] ata: ahci_sunxi: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 13/14] ata: ahci_tegra: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 14/14] ata: ahci_xgene: " Kunihiko Hayashi
2018-08-22 9:27 ` [PATCH 00/14] ata: ahci-platform: add reset control support except for existing drivers Hans de Goede
2018-08-22 10:06 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d221236-636e-962e-2e4e-3db228689c5e@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).