From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CF7C4332F for ; Tue, 11 Oct 2022 12:23:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbiJKMXv (ORCPT ); Tue, 11 Oct 2022 08:23:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229824AbiJKMXh (ORCPT ); Tue, 11 Oct 2022 08:23:37 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A85758F976 for ; Tue, 11 Oct 2022 05:23:35 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id de14so8808677qvb.5 for ; Tue, 11 Oct 2022 05:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZDcL9+bBzbkp+KJx7T0xtbSPbbNIbsOAPMQB2E5GrtY=; b=N+NatMm2WFYZ9mlYoAn0l9SfSVSiVLQceQHaHCdUaWDDV5dzyZGrZFCohOqc6+l/Wy UL/lnRKlEhyWOhIYKablbsfREcV+noOV6VdWjGj0fpWW8ko2oTT6CVh/OcJrNZF8dEhB UFJomVk8jdBWafzbWL9DJobEwBdpEyNvPvikaiFZtuQW5eBVRj6QBOIlXxCoCcZbp4CK pP4scW0ATERDCFzEQok7RfNm0PdmdcKnmg5Sdy4N6mov7vn1IvqShkpDfTkpTtvDepB3 e9gvkJvdPWsKYlnFac7mznRbl0yATAzgZFQ8jbaH5XxoDOMHjiC5xkcSEj7oRJCIrd1q qjRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZDcL9+bBzbkp+KJx7T0xtbSPbbNIbsOAPMQB2E5GrtY=; b=jWAh8sOgysCKrSljrU8rLIpjzSLx5TlanSyypmV15uQG8yteUszbxYA5aDLZdWfFBs iqM2hfmBEqk/rYWzcNiwJlHIZxfawsAC/wMdrrZ6MmW83igjjAK8m9RfGVex83MEIf9u Dujwd8PNejjinFS34prmU+gvHd8ex2JzPICrJRp88v6XENKMcepLg+Z4zqmSCJl/GioY 5aGG6tiuRyat6kSFFznuLDKmvHFexDxOBSwM9AhcqiGTC40yIdQmE3fFntWUbVHyVVdR s8/8O9ZnyZPZwa3LHyoH4k0ehmIc6aEwaveEnuFSUDBCOJ6XwZ4L/gl+/1vYI8t9r4lu 84aQ== X-Gm-Message-State: ACrzQf3+E0BtbjgVp4tmaexYT//y7EOZKcUdSZGZTMJAn11xU+PlSpiV f3A8MJCEb7XHCF14/6otJSfahw== X-Google-Smtp-Source: AMsMyM5WBAgPEtbDPqvpOtzVhrgo36KGJWwWy4bAnO2SXyUL6V2OnRATsznb7iVc9nuz8KjnaB3sCg== X-Received: by 2002:a05:6214:2464:b0:4b3:6cce:9860 with SMTP id im4-20020a056214246400b004b36cce9860mr16026754qvb.120.1665491014660; Tue, 11 Oct 2022 05:23:34 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id bp36-20020a05620a45a400b006ce7bb8518bsm4348208qkb.5.2022.10.11.05.23.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 05:23:34 -0700 (PDT) Message-ID: <1d2613aa-3225-a2b6-521a-b2df70a30ed5@linaro.org> Date: Tue, 11 Oct 2022 08:23:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 3/7] dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS Content-Language: en-US To: Moudy Ho , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , Chun-Kuang Hu Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, "Roy-CW.Yeh" References: <20221011070356.682-1-moudy.ho@mediatek.com> <20221011070356.682-4-moudy.ho@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20221011070356.682-4-moudy.ho@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/10/2022 03:03, Moudy Ho wrote: > From: "Roy-CW.Yeh" > > Compatible names, node names, and GCE client registers for > VPPSYS0 and VPPSYS1 should be renamed or added to match > the binding file requirements. > Also, add two nodes for MT8195 VPPSYS MUTEX. > > Signed-off-by: Roy-CW.Yeh > Signed-off-by: Moudy Ho Use subject prefixes matching the subsystem (git log --oneline -- ...). > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 30 ++++++++++++++++++++---- > 1 file changed, 26 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 905d1a90b406..3e73bd58e54d 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -1476,12 +1476,23 @@ > #clock-cells = <1>; > }; > > - vppsys0: clock-controller@14000000 { > - compatible = "mediatek,mt8195-vppsys0"; > + vppsys0: syscon@14000000 { > + compatible = "mediatek,mt8195-vppsys0", > + "mediatek,mt8195-mmsys", "syscon"; No. You change multiple pieces in one patch, some of them have much bigger impact, like adding compatibles. Split and describe *why* you are changing it. > reg = <0 0x14000000 0 0x1000>; > + mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0 0x1000>; > #clock-cells = <1>; > }; > > + mutex@1400f000 { > + compatible = "mediatek,mt8195-vpp-mutex"; And you add some new nodes in a cleanup patch... Best regards, Krzysztof