From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16483377 for ; Fri, 22 Sep 2023 01:23:59 +0000 (UTC) Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3897CF; Thu, 21 Sep 2023 18:23:57 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id BF08C24DBC0; Fri, 22 Sep 2023 09:23:48 +0800 (CST) Received: from EXMBX171.cuchost.com (172.16.6.91) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 22 Sep 2023 09:23:48 +0800 Received: from [192.168.125.57] (113.72.146.252) by EXMBX171.cuchost.com (172.16.6.91) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 22 Sep 2023 09:23:47 +0800 Message-ID: <1d29eea8-9053-2250-cff1-68b16436ba36@starfivetech.com> Date: Fri, 22 Sep 2023 09:23:47 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 08/19] PCI: plda: Add event interrupt codes and IRQ domain ops Content-Language: en-US To: Bjorn Helgaas , Conor Dooley CC: Daire McNamara , Rob Herring , Krzysztof Kozlowski , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Emil Renner Berthing , , , , , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Mason Huo , Leyfoon Tan , Kevin Xie References: <20230921150814.GA330660@bhelgaas> From: Minda Chen In-Reply-To: <20230921150814.GA330660@bhelgaas> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.146.252] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX171.cuchost.com (172.16.6.91) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 2023/9/21 23:08, Bjorn Helgaas wrote: > On Sat, Sep 16, 2023 at 01:11:29AM +0100, Conor Dooley wrote: >> On Fri, Sep 15, 2023 at 06:22:32PM +0800, Minda Chen wrote: >> > For PolarFire implements non-PLDA local interrupt events, most of >> > event interrupt process codes can not be re-used. PLDA implements >> > new codes and IRQ domain ops like PolarFire. >> > >> > plda_get_events() adds a new IRQ num to event num mapping codes for >> > PLDA local event except DMA engine interrupt events. The DMA engine >> > interrupt events are implemented by vendors. >> > >> > Signed-off-by: Minda Chen >> >> Perhaps not important as they will go away in the next patch, but for >> this patch the riscv patchwork stuff noticed: >> drivers/pci/controller/plda/pcie-plda-host.c:114:36: warning: unused variable 'plda_evt_dom_ops' [-Wunused-const-variable] >> drivers/pci/controller/plda/pcie-plda-host.c:118:36: warning: unused variable 'plda_event_ops' [-Wunused-const-variable] > > Details like this *are* important because fixing them makes the > individual patches more readable, thanks for noticing! > > Bjorn OK, I will solve this.