From: "Rafał Miłecki" <zajec5@gmail.com>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: mtd: Document use of nvmem-cells compatible
Date: Thu, 11 Mar 2021 07:37:13 +0100 [thread overview]
Message-ID: <1d2ad735-ad15-be6a-ad90-9c33f5845a15@gmail.com> (raw)
In-Reply-To: <YElMjg/AspNSRe0A@Ansuel-xps.localdomain>
On 10.03.2021 23:47, Ansuel Smith wrote:
> On Wed, Mar 10, 2021 at 11:41:24PM +0100, Rafał Miłecki wrote:
>> See inline
>>
>> On 10.03.2021 22:08, Ansuel Smith wrote:
>>> Document nvmem-cells compatible used to treat mtd partitions as a
>>> nvmem provider.
>>>
>>> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
>>> ---
>>> .../bindings/mtd/partitions/nvmem-cells.yaml | 96 +++++++++++++++++++
>>> 1 file changed, 96 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>>> new file mode 100644
>>> index 000000000000..f70d7597a6b0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>>> @@ -0,0 +1,96 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Nvmem cells
>>> +
>>> +description: |
>>> + Any partition containing the compatible "nvmem-cells" will register as a
>>> + nvmem provider.
>>> + Each direct subnodes represents a nvmem cell following the nvmem binding.
>>> + Nvmem binding to declare nvmem-cells can be found in:
>>> + Documentation/devicetree/bindings/nvmem/nvmem.yaml
>>> +
>>> +maintainers:
>>> + - Ansuel Smith <ansuelsmth@gmail.com>
>>
>> I think that when Rob wrote:
>>
>> On 10.03.2021 03:58, Rob Herring wrote:
>>> I think this should reference nvmem.yaml.
>>
>> he meant you using:
>>
>> allOf:
>> - $ref: "nvmem.yaml#"
>>
>> (you'll need to adjust binding path).
>>
>> Please check how it's done in Documentation/devicetree/bindings/nvmem/*.yaml files
>>
>>
>
> Aside from that, should I readd the old properties or I can keep the
> compatible as the only one required?
What old properties do you mean?
You shouldn't need to add anything to the list of "required" I think.
Some NVMEM providers add "#address-cells" and "#size-cells". That makes
sense if NVMEM provider must provide at least 1 cell. I'm not sure if we
need that for MTD.
Even "compatible" is actually redundant but most YAML files list it for
convenience. Source:
On 10.12.2020 03:48, Rob Herring wrote:
> And drop 'compatible' as required. It's redundant anyways because the
> schema will only be applied if compatible matches.
http://lists.infradead.org/pipermail/linux-mtd/2020-December/084574.html
https://patchwork.ozlabs.org/comment/2597326/
next prev parent reply other threads:[~2021-03-11 6:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 21:08 [PATCH v4 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells Ansuel Smith
2021-03-10 21:08 ` [PATCH v4 2/3] dt-bindings: mtd: Document use of nvmem-cells compatible Ansuel Smith
2021-03-10 22:41 ` Rafał Miłecki
2021-03-10 22:47 ` Ansuel Smith
2021-03-11 6:37 ` Rafał Miłecki [this message]
2021-03-11 5:18 ` Ansuel Smith
2021-03-10 21:08 ` [PATCH v4 3/3] devicetree: nvmem: nvmem: drop $nodename restriction Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d2ad735-ad15-be6a-ad90-9c33f5845a15@gmail.com \
--to=zajec5@gmail.com \
--cc=ansuelsmth@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).