From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554C1C433F5 for ; Thu, 14 Oct 2021 18:09:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 340AC60EBB for ; Thu, 14 Oct 2021 18:09:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232731AbhJNSLU (ORCPT ); Thu, 14 Oct 2021 14:11:20 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:46618 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230386AbhJNSLU (ORCPT ); Thu, 14 Oct 2021 14:11:20 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634234955; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=PaqL+qcUYZsZZQg/ZfKwStuB0Bng0ty0IIvhLrT9KAE=; b=TNyu0vFrNXytapvsZDqa0I/R75ml5AgGjq3f7blTRSQyGwcrKCiewI3wpKkUdA5OtMbe2eWR reo+M/MbPeUTb2oHwavIcrVil6mgyELOqpb7O2NnxxkGnKoCVt8fxUJwiPf6Fptf/uCTVlJX ytLZUMyr0ZbEtUA4XCg/JtD/UL8= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 61687249446c6db0cb8da888 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 14 Oct 2021 18:09:13 GMT Sender: pmaliset=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1D361C4360C; Thu, 14 Oct 2021 18:09:13 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: pmaliset) by smtp.codeaurora.org (Postfix) with ESMTPSA id ADFBBC43460; Thu, 14 Oct 2021 18:09:12 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 14 Oct 2021 23:39:12 +0530 From: Prasad Malisetty To: Stephen Boyd Cc: agross@kernel.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, manivannan.sadhasivam@linaro.org, robh+dt@kernel.org, sanm@codeaurora.org, vbadigan@codeaurora.org Subject: Re: [PATCH v1] arm64: dts: qcom: sc7280: Add pcie clock support In-Reply-To: References: <1634042171-31461-1-git-send-email-pmaliset@codeaurora.org> Message-ID: <1d311e617667a2bbda233e423ca0b898@codeaurora.org> X-Sender: pmaliset@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2021-10-12 22:56, Stephen Boyd wrote: > Quoting Prasad Malisetty (2021-10-12 05:36:11) >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index 39635da..78694c1 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -569,9 +569,10 @@ >> reg = <0 0x00100000 0 0x1f0000>; >> clocks = <&rpmhcc RPMH_CXO_CLK>, >> <&rpmhcc RPMH_CXO_CLK_A>, >> <&sleep_clk>, >> - <0>, <0>, <0>, <0>, <0>, <0>; >> + <0>, <&pcie1_lane 0>, >> + <0>, <0>, <0>, <0>; >> clock-names = "bi_tcxo", "bi_tcxo_ao", >> "sleep_clk", >> - "pcie_0_pipe_clk", >> "pcie_1_pipe-clk", >> + "pcie_0_pipe_clk", >> "pcie_1_pipe_clk", > > It looks like a fix because the name doesn't match the binding. Can you > add a Fixes tag? > Hi Stephen, Thanks for the review. Yes, I fixed the clock name as per the binding. I have added fixes tag and updated the new pacth. Thanks -Prasad >> "ufs_phy_rx_symbol_0_clk", >> "ufs_phy_rx_symbol_1_clk", >> "ufs_phy_tx_symbol_0_clk", >> >> "usb3_phy_wrapper_gcc_usb30_pipe_clk";