From: Jon Hunter <jonathanh@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Sameer Pujar <spujar@nvidia.com>,
tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com,
robh+dt@kernel.org, thierry.reding@gmail.com, perex@perex.cz
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] ALSA: hda/tegra: Skip reset on BPMP devices
Date: Tue, 7 Dec 2021 15:07:17 +0000 [thread overview]
Message-ID: <1d373ba1-d2eb-356d-259b-db7743654916@nvidia.com> (raw)
In-Reply-To: <9da3de11-b6c5-b2ac-f4cf-e14c73ec134a@gmail.com>
On 07/12/2021 11:57, Dmitry Osipenko wrote:
> 07.12.2021 14:02, Jon Hunter пишет:
>>
>> On 07/12/2021 10:58, Dmitry Osipenko wrote:
>>> 07.12.2021 13:44, Dmitry Osipenko пишет:
>>>> 07.12.2021 13:22, Dmitry Osipenko пишет:
>>>>> 07.12.2021 09:32, Sameer Pujar пишет:
>>>>>> HDA regression is recently reported on Tegra194 based platforms.
>>>>>> This happens because "hda2codec_2x" reset does not really exist
>>>>>> in Tegra194 and it causes probe failure. All the HDA based audio
>>>>>> tests fail at the moment. This underlying issue is exposed by
>>>>>> commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP
>>>>>> response") which now checks return code of BPMP command response.
>>>
>>> I see that this BPMP commit already has been reverted. There is no
>>> problem in this hda_tegra driver at all.
>>
>> That is temporary until this fix is merged and then we will revert the
>> revert.
>
> It's the device-tree that is broken, not the driver. If you don't care
> about broken HDMI audio using outdated dtb, then there is nothing to fix
> in the code.
That's correct. However, we do care about HDMI audio being broken with
existing DTBs and so we need to make sure they still work.
Jon
--
nvpublic
next prev parent reply other threads:[~2021-12-07 15:07 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 6:32 [PATCH 0/3] Fix Tegra194 HDA regression Sameer Pujar
2021-12-07 6:32 ` [PATCH 1/3] ALSA: hda/tegra: Skip reset on BPMP devices Sameer Pujar
2021-12-07 8:16 ` Thierry Reding
2021-12-07 8:36 ` Takashi Iwai
2021-12-07 9:09 ` Sameer Pujar
2021-12-07 10:22 ` Dmitry Osipenko
2021-12-07 10:44 ` Dmitry Osipenko
2021-12-07 10:58 ` Dmitry Osipenko
2021-12-07 11:02 ` Jon Hunter
2021-12-07 11:57 ` Dmitry Osipenko
2021-12-07 15:07 ` Jon Hunter [this message]
2021-12-07 12:00 ` Sameer Pujar
2021-12-07 12:05 ` Dmitry Osipenko
2021-12-07 12:40 ` Sameer Pujar
2021-12-07 14:07 ` Dmitry Osipenko
2021-12-07 14:49 ` Sameer Pujar
2021-12-07 15:35 ` Dmitry Osipenko
2021-12-07 17:37 ` Sameer Pujar
2021-12-07 18:02 ` Dmitry Osipenko
2021-12-08 5:22 ` Sameer Pujar
2021-12-08 12:05 ` Dmitry Osipenko
2021-12-14 6:02 ` Sameer Pujar
2021-12-14 6:09 ` Dmitry Osipenko
2021-12-14 6:15 ` Dmitry Osipenko
2021-12-14 7:22 ` Sameer Pujar
2021-12-14 13:56 ` Dmitry Osipenko
2021-12-14 14:29 ` Takashi Iwai
2021-12-14 15:34 ` Dmitry Osipenko
2021-12-20 10:32 ` Sameer Pujar
2021-12-07 6:32 ` [PATCH 2/3] dt-bindings: sound: tegra: Update HDA resets Sameer Pujar
2021-12-07 8:18 ` Thierry Reding
2021-12-07 9:27 ` Sameer Pujar
2021-12-07 10:14 ` Dmitry Osipenko
2021-12-07 11:04 ` Sameer Pujar
2021-12-07 12:02 ` Dmitry Osipenko
2021-12-07 12:22 ` Sameer Pujar
2021-12-07 6:32 ` [PATCH 3/3] arm64: tegra: Remove non existent Tegra194 reset Sameer Pujar
2021-12-07 8:04 ` [PATCH 0/3] Fix Tegra194 HDA regression Takashi Iwai
2021-12-07 8:21 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d373ba1-d2eb-356d-259b-db7743654916@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).