From: Roger Quadros <rogerq@kernel.org>
To: MD Danish Anwar <danishanwar@ti.com>, vigneshr@ti.com, nm@ti.com
Cc: conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kristo@kernel.org, srk@ti.com
Subject: Re: [PATCH] arm64: dts: ti: k3-am642-evm: Add dt overlay to disable icssg for Linux
Date: Thu, 31 Oct 2024 12:53:12 +0200 [thread overview]
Message-ID: <1d38d2c7-e1e7-4bc2-a760-a1321cbe0e16@kernel.org> (raw)
In-Reply-To: <20241030114458.1358800-1-danishanwar@ti.com>
Hi Danish,
On 30/10/2024 13:44, MD Danish Anwar wrote:
> Add k3-am642-evm-icssg1-disable.dtso overlay file that disables
> icssg1-eth from Linux so that icssg peripherals can be used by
> RTOS or some other OS running on R5 core.
>
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> arch/arm64/boot/dts/ti/Makefile | 7 +--
> .../dts/ti/k3-am642-evm-icssg1-disable.dtso | 49 +++++++++++++++++++
> 2 files changed, 53 insertions(+), 3 deletions(-)
> create mode 100644 arch/arm64/boot/dts/ti/k3-am642-evm-icssg1-disable.dtso
>
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index 6bd06bd76b68..0fd95b7df5a8 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -76,6 +76,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am642-evm.dtb
> dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-nand.dtbo
> dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-icssg1-dualemac.dtbo
> dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-icssg1-dualemac-mii.dtbo
> +dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-icssg1-disable.dtbo
> dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-pcie0-ep.dtbo
> dtb-$(CONFIG_ARCH_K3) += k3-am642-phyboard-electra-rdk.dtb
> dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb
> @@ -235,8 +236,8 @@ k3-am62p5-sk-microtips-mf103hie-lcd2-dtbs := k3-am62p5-sk.dtb \
> k3-am62p5-sk-microtips-mf103hie-lcd2.dtbo
> k3-am642-evm-icssg1-dualemac-dtbs := \
> k3-am642-evm.dtb k3-am642-evm-icssg1-dualemac.dtbo
> -k3-am642-evm-icssg1-dualemac-mii-dtbs := \
> - k3-am642-evm.dtb k3-am642-evm-icssg1-dualemac-mii.dtbo
> +k3-am642-evm-icssg1-disable-dtbs := \
> + k3-am642-evm.dtb k3-am642-evm-icssg1-disable.dtbo
> k3-am642-evm-pcie0-ep-dtbs := \
> k3-am642-evm.dtb k3-am642-evm-pcie0-ep.dtbo
> k3-am642-tqma64xxl-mbax4xxl-sdcard-dtbs := \
> @@ -323,7 +324,7 @@ dtb- += k3-am625-beagleplay-csi2-ov5640.dtb \
> k3-am62p5-sk-microtips-mf101hie-panel.dtb \
> k3-am62p5-sk-microtips-mf103hie-lcd2.dtb \
> k3-am642-evm-icssg1-dualemac.dtb \
> - k3-am642-evm-icssg1-dualemac-mii.dtb \
> + k3-am642-evm-icssg1-disable.dtb \
> k3-am642-evm-pcie0-ep.dtb \
> k3-am642-tqma64xxl-mbax4xxl-sdcard.dtb \
> k3-am642-tqma64xxl-mbax4xxl-wlan.dtb \
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm-icssg1-disable.dtso b/arch/arm64/boot/dts/ti/k3-am642-evm-icssg1-disable.dtso
> new file mode 100644
> index 000000000000..dc04e2999e97
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm-icssg1-disable.dtso
> @@ -0,0 +1,49 @@
> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> +/**
> + * DT overlay for enabling 2nd ICSSG1 port on AM642 EVM
> + *
> + * Copyright (C) 2020-2024 Texas Instruments Incorporated - https://www.ti.com/
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include "k3-pinctrl.h"
> +
> +&oc_sram {
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + r5f0_0_sram: r5f0_0_sram@0 {
> + reg = <0x0 0x180000>;
> + };
> +};> +
> +&main_r5fss0_core0 {
> + sram = <&r5f0_0_sram>;
> +};
> +
You need to mention why this change is done, in the commit log.
> +&cpsw_port2 {
> + status = "disabled";
> +};
> +
> +&icssg0 {
> + status = "disabled";
> +};
dtso name says icssg1-disabel but you are disabling icssg0 as well?
> +
> +&icssg1 {
> + status = "disabled";
> +};
> +
> +&ospi0 {
> + status = "disabled";
> +};
and ospi0?
> +
> +&mdio_mux_1 {
> + status = "disabled";
> +};
> +
> +&icssg1_eth {
> + status = "disabled";
> +};
Maybe the dtso is poorly named and should be called something else so that is correctly reflects the use case?
I suppose it has something to do with peripherals reserved for R5 core?
e.g.
k3-am642-evm-r5-reserved.dtso?
How is this dtso applied at boot?
--
cheers,
-roger
next prev parent reply other threads:[~2024-10-31 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 11:44 [PATCH] arm64: dts: ti: k3-am642-evm: Add dt overlay to disable icssg for Linux MD Danish Anwar
2024-10-31 10:53 ` Roger Quadros [this message]
2024-10-31 16:39 ` Andrew Davis
2024-11-03 6:06 ` Vignesh Raghavendra
2024-11-06 14:45 ` Krzysztof Kozlowski
2024-11-06 14:50 ` Anwar, Md Danish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d38d2c7-e1e7-4bc2-a760-a1321cbe0e16@kernel.org \
--to=rogerq@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).