From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Brian Masney <bmasney@redhat.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property
Date: Tue, 16 Jun 2026 10:36:00 +0200 [thread overview]
Message-ID: <1d4f3e4e-ec9e-44d0-9e4a-651b6920015c@kernel.org> (raw)
In-Reply-To: <20260615-topic-sm8x50-tie-gcc-to-cx-v2-1-6b5752dd4747@linaro.org>
On 15/06/2026 18:57, Neil Armstrong wrote:
> In order for the GCC votes on the GDSCs it provides to be propagated
> to CX, CX needs to be declared as power domain of the GCC.
I would be happier to see here short mentioning what is the effect of
missing votes - do things work? - as justification why required
property, thus ABI change, is justified.
The DTS patches gave me that answer, but should be here as well the best.
Well, don't want to stall anything here, so anyway:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> Document the missing power-domains property to that purpose.
>
> Fixes: 72a0ca203ca7 ("dt-bindings: clock: Add SM8450 GCC clock bindings")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-16 8:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 16:57 [PATCH v2 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC Neil Armstrong
2026-06-15 16:57 ` [PATCH v2 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property Neil Armstrong
2026-06-15 19:02 ` sashiko-bot
2026-06-16 8:36 ` Krzysztof Kozlowski [this message]
2026-06-16 8:38 ` Neil Armstrong
2026-06-15 16:57 ` [PATCH v2 2/6] dt-bindings: clock: qcom: sm8550-gcc: " Neil Armstrong
2026-06-15 17:03 ` sashiko-bot
2026-06-16 8:36 ` Krzysztof Kozlowski
2026-06-15 16:57 ` [PATCH v2 3/6] dt-bindings: clock: qcom: sm8650-gcc: " Neil Armstrong
2026-06-15 17:05 ` sashiko-bot
2026-06-16 8:36 ` Krzysztof Kozlowski
2026-06-15 16:57 ` [PATCH v2 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC Neil Armstrong
2026-06-15 17:10 ` sashiko-bot
2026-06-15 16:57 ` [PATCH v2 5/6] arm64: dts: qcom: sm8550: " Neil Armstrong
2026-06-15 16:57 ` [PATCH v2 6/6] arm64: dts: qcom: sm8650: " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4f3e4e-ec9e-44d0-9e4a-651b6920015c@kernel.org \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_saipraka@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox