From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 485D6C38142 for ; Sat, 21 Jan 2023 22:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbjAUW5v (ORCPT ); Sat, 21 Jan 2023 17:57:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjAUW5t (ORCPT ); Sat, 21 Jan 2023 17:57:49 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B183435B3 for ; Sat, 21 Jan 2023 14:57:47 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id z5so7749358wrt.6 for ; Sat, 21 Jan 2023 14:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DXevFDlFQdM/zI7Jx7BcXm3YkWz/eRd8voNlgNsEDEs=; b=fOk7XXQyvFjmtjCFm1qgajijZ9hisHU8wsSpmwQeu0iyQ/WWys4CJdsCq3k+0fbDH/ R1z3xUq7q4lDTiZHyX2MgmIzRO9JvoSjwwWC7WiZAmJzWZy9OGov5nfpupFLKX1BffXc jGgpG/MCAXB59mRd8Lrkb4t07e32LrFaojqAtswjVCGnhWaV6j3+dFViR7qSl/ddn5mi M6JaI6gCDUW2fLgrU2/9m28Sm+yocGfFl9LfpQs8qJorogk9CNXo8++TTZNrnBuJoKlb 5R+9hXzpsVsQT91uBXHZ+kECAHLaQj0zXzBFqthurQj3Y6R3YWpGlhh/cbLj7ttO+l8K AsvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DXevFDlFQdM/zI7Jx7BcXm3YkWz/eRd8voNlgNsEDEs=; b=NEkR+4fPb7chqAPsGDXlkipr79mvgF9st0BWNiwU1EGFkH+iTP0MO/dN+1VrYROl+t TiVV28nhWCuRg/8ixkoQUNRWi40LxBGqifMhocSVq/DjrNWwqCtlgzxekFA1IkmwtqPX r+p8cGYvAiu1MU0g/QY3fWsN8gP/+HigbcwMQKWTfCfi+SEOgb4+QK+gnkyTAhhYewnp MTgkLYJ0ZUpDLDiBkgbQZdJmw0ZQSFZIG/88H82DF7qpaXNNRxy2//cJ4ONTFiftyBIX qPCcAkX/zWB3KLhxVDDIghWgX8rpwvOoqQRaanLDzjnYJ+WkA0s0fPMdhtVIu4XuMl+s gN0g== X-Gm-Message-State: AFqh2krmW8aDAepuChHam3dcpV+pZfJmVtRr9TaaTpAmSVRk4kc1xV14 vKGZD/LU4f8CpY2iV9ZuzMqt4A== X-Google-Smtp-Source: AMrXdXsUDxCkXVypog+Cjl1KgXGXiZ+K1LLyRLQkDar7eCHpCQ0/MhePcfFKKNBi0EORYD4Ui4ot6Q== X-Received: by 2002:a5d:4fc8:0:b0:256:ff7d:2347 with SMTP id h8-20020a5d4fc8000000b00256ff7d2347mr24451448wrw.13.1674341866203; Sat, 21 Jan 2023 14:57:46 -0800 (PST) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id e1-20020a5d65c1000000b002be15ee1377sm13079444wrw.22.2023.01.21.14.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Jan 2023 14:57:45 -0800 (PST) Message-ID: <1d6c5aae-dde8-3780-e851-f304e43d3ddf@linaro.org> Date: Sat, 21 Jan 2023 22:57:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 5/8] arm64: dts: qcom: Add msm8939 SoC Content-Language: en-US To: Stephan Gerhold Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, benl@squareup.com, shawn.guo@linaro.org, fabien.parent@linaro.org, leo.yan@linaro.org, dmitry.baryshkov@linaro.org, Jun Nie , James Willcox , Joseph Gates , Max Chen , Zac Crosby , Vincent Knecht References: <20230117024846.1367794-1-bryan.odonoghue@linaro.org> <20230117024846.1367794-6-bryan.odonoghue@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/01/2023 09:59, Stephan Gerhold wrote: > Why are you adding a dummy power domain here? IMO this would be better > added together with CPR. Especially because I would expect two power > domains here later ("mx", "cpr"). For cpufreq you also need to make > votes for the "MSM8939_VDDMX" power domain. Confirmed power-domain is a required property, dtbs check will complain without it. I'll leave further discussion on the format of CPR for the CPR series but our working example supposes the below as a starting point. I'm not aware of VDDMX in the CPR path but its not at this node. CPU2: cpu@102 { device_type = "cpu"; compatible = "arm,cortex-a53", "arm,armv8"; reg = <0x102>; next-level-cache = <&L2_1>; enable-method = "qcom,kpss-acc-v2"; qcom,acc = <&acc2>; qcom,saw = <&saw2>; clocks = <&apcs1>; operating-points-v2 = <&cluster1_opp_table>; power-domains = <&cpr>; power-domain-names = "cpr"; #cooling-cells = <2>; capacity-dmips-mhz = <1024>; }; cluster1_opp_table: cluster1-opp-table { compatible = "operating-points-v2-qcom-cpu"; opp-shared; /* Used by qcom-cpufreq-nvmem.c */ nvmem-cells = <&cpr_efuse_speedbin_pvs>; nvmem-cell-names = "cpr_efuse_speedbin_pvs"; opp-200000000 { opp-hz = /bits/ 64 <200000000>; opp-supported-hw = <0x3f>; required-opps = <&cpr_opp3>; }; opp-345600000 { opp-hz = /bits/ 64 <345600000>; opp-supported-hw = <0x3f>; required-opps = <&cpr_opp3>; }; }; cpr_opp_table: cpr-opp-table { compatible = "operating-points-v2-qcom-level"; cpr_opp1: opp1 { opp-hz = /bits/ 64 <200000000>; opp-level = <1>; qcom,opp-fuse-level = <1>; }; cpr_opp2: opp2 { opp-hz = /bits/ 64 <345600000>; opp-level = <2>; qcom,opp-fuse-level = <1>; }; cpr_opp3: opp3 { opp-hz = /bits/ 64 <400000000>; opp-level = <3>; qcom,opp-fuse-level = <1>; }; }; /* etc */ }; --- bod