From: Heiner Kallweit <hkallweit1@gmail.com>
To: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Andrew Lunn <andrew@lunn.ch>, Andrew Lunn <andrew+netdev@lunn.ch>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 4/5] net: mdio: remove support for old fixed-link binding
Date: Sat, 30 Aug 2025 12:29:54 +0200 [thread overview]
Message-ID: <1d6eeae6-96c9-4c25-a250-01fb7580c9be@gmail.com> (raw)
In-Reply-To: <a3c2f8d3-36e6-4411-9526-78abbc60e1da@gmail.com>
The old array-type fixed-link binding has been deprecated
for more than 10 yrs. So remove support for it.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/mdio/of_mdio.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
index d8ca63ed8..5df01717a 100644
--- a/drivers/net/mdio/of_mdio.c
+++ b/drivers/net/mdio/of_mdio.c
@@ -379,21 +379,12 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev,
}
EXPORT_SYMBOL(of_phy_get_and_connect);
-/*
- * of_phy_is_fixed_link() and of_phy_register_fixed_link() must
- * support two DT bindings:
- * - the old DT binding, where 'fixed-link' was a property with 5
- * cells encoding various information about the fixed PHY
- * - the new DT binding, where 'fixed-link' is a sub-node of the
- * Ethernet device.
- */
bool of_phy_is_fixed_link(struct device_node *np)
{
struct device_node *dn;
int err;
const char *managed;
- /* New binding */
dn = of_get_child_by_name(np, "fixed-link");
if (dn) {
of_node_put(dn);
@@ -404,10 +395,6 @@ bool of_phy_is_fixed_link(struct device_node *np)
if (err == 0 && strcmp(managed, "auto") != 0)
return true;
- /* Old binding */
- if (of_property_count_u32_elems(np, "fixed-link") == 5)
- return true;
-
return false;
}
EXPORT_SYMBOL(of_phy_is_fixed_link);
@@ -416,7 +403,6 @@ int of_phy_register_fixed_link(struct device_node *np)
{
struct fixed_phy_status status = {};
struct device_node *fixed_link_node;
- u32 fixed_link_prop[5];
const char *managed;
if (of_property_read_string(np, "managed", &managed) == 0 &&
@@ -425,7 +411,6 @@ int of_phy_register_fixed_link(struct device_node *np)
goto register_phy;
}
- /* New binding */
fixed_link_node = of_get_child_by_name(np, "fixed-link");
if (fixed_link_node) {
status.link = 1;
@@ -444,17 +429,6 @@ int of_phy_register_fixed_link(struct device_node *np)
goto register_phy;
}
- /* Old binding */
- if (of_property_read_u32_array(np, "fixed-link", fixed_link_prop,
- ARRAY_SIZE(fixed_link_prop)) == 0) {
- status.link = 1;
- status.duplex = fixed_link_prop[1];
- status.speed = fixed_link_prop[2];
- status.pause = fixed_link_prop[3];
- status.asym_pause = fixed_link_prop[4];
- goto register_phy;
- }
-
return -ENODEV;
register_phy:
--
2.51.0
next prev parent reply other threads:[~2025-08-30 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 10:26 [PATCH net-next 0/5] net: phy: remove support for deprecated array-style fixed-link binding Heiner Kallweit
2025-08-30 10:27 ` [PATCH net-next 1/5] arm64: dts: ls1043a-qds: switch to new " Heiner Kallweit
2025-08-30 15:40 ` kernel test robot
2025-08-30 21:27 ` Russell King (Oracle)
2025-08-30 21:39 ` Heiner Kallweit
2025-08-30 21:44 ` Russell King (Oracle)
2025-09-01 19:39 ` Heiner Kallweit
2025-09-01 22:47 ` Andrew Lunn
2025-08-30 10:28 ` [PATCH net-next 2/5] ARM: dts: ls1021a: " Heiner Kallweit
2025-08-30 15:41 ` kernel test robot
2025-08-30 10:28 ` [PATCH net-next 3/5] ARM: dts: st: " Heiner Kallweit
2025-08-30 10:29 ` Heiner Kallweit [this message]
2025-08-30 10:31 ` [PATCH net-next 5/5] net: phy: phylink: remove support for deprecated " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d6eeae6-96c9-4c25-a250-01fb7580c9be@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patrice.chotard@foss.st.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).