From: "Rafał Miłecki" <zajec5@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's PMB binding
Date: Wed, 18 Nov 2020 22:53:35 +0100 [thread overview]
Message-ID: <1d7629ab-dc2d-523c-0cf4-639d64600097@gmail.com> (raw)
In-Reply-To: <d09b2767-66df-fee6-cfc8-3eba116e10af@gmail.com>
On 18.11.2020 22:45, Florian Fainelli wrote:
>> + pmb: reset-controller@802800e0 {
>> + compatible = "brcm,bcm4908-pmb";
>> + reg = <0x802800e0 0x20>;
>> + #reset-cells = <2>;
>> + };
>> +
>> + foo {
>> + resets = <&pmb BRCM_PMB_USB 17>;
>> + }
>
> You are missing a ';' here which is why the binding example did not build.
Ah, the very last minute fix... Thanks!
next prev parent reply other threads:[~2020-11-18 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 13:24 [PATCH 0/2] reset: support Broadcom's PMB Rafał Miłecki
2020-11-18 13:24 ` [PATCH 1/2] dt-bindings: reset: document Broadcom's PMB binding Rafał Miłecki
2020-11-18 21:25 ` Rob Herring
2020-11-18 21:45 ` Florian Fainelli
2020-11-18 21:47 ` Florian Fainelli
2020-11-19 9:54 ` Rafał Miłecki
2020-11-18 21:53 ` Rafał Miłecki [this message]
2020-11-18 13:24 ` [PATCH 2/2] reset: brcm-pmc: add driver for Broadcom's PMB Rafał Miłecki
2020-11-18 21:50 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d7629ab-dc2d-523c-0cf4-639d64600097@gmail.com \
--to=zajec5@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).