From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, leyfoon.tan@starfivetech.com,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux@roeck-us.net, robh+dt@kernel.org,
samin.guo@starfivetech.com, wim@linux-watchdog.org,
xingyu.wu@starfivetech.com
Subject: Re: [PATCH v4 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100
Date: Mon, 18 Dec 2023 15:41:37 +0100 [thread overview]
Message-ID: <1d7f9cbe-9ca1-4ccb-b90f-6e474c0740ad@linaro.org> (raw)
In-Reply-To: <20231218142711.961120-1-jisheng.teoh@starfivetech.com>
On 18/12/2023 15:27, Ji Sheng Teoh wrote:
>>
>> I have real doubts that you ever tested your entire solution with this
>> binding. Where is the DTS?
>>
>
> Currently, the DTS is still in internal and yet to upstream as it depends
> on [1].
Yeah, so you send untested code which cannot work or pass tests. If you
do not test your code, we need to be able to at least verify it, so send
your DTS. Otherwise I cannot trust that this works at all.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-18 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 1:48 [PATCH v4 0/1] Add StarFive JH8100 watchdog Ji Sheng Teoh
2023-12-16 1:48 ` [PATCH v4 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Ji Sheng Teoh
2023-12-18 8:41 ` Krzysztof Kozlowski
2023-12-18 14:27 ` Ji Sheng Teoh
2023-12-18 14:41 ` Krzysztof Kozlowski [this message]
2023-12-18 15:37 ` Ji Sheng Teoh
2023-12-19 15:43 ` Conor Dooley
2023-12-20 1:23 ` Ji Sheng Teoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d7f9cbe-9ca1-4ccb-b90f-6e474c0740ad@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jisheng.teoh@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).