From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Taniya Das <quic_tdas@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_jkona@quicinc.com, quic_imrashai@quicinc.com
Subject: Re: [PATCH 6/8] clk: qcom: Add support for Display clock Controllers on SA8775P
Date: Sat, 6 Jul 2024 14:25:37 +0200 [thread overview]
Message-ID: <1d8e3779-aebf-4f27-bd54-58007b80192a@linaro.org> (raw)
In-Reply-To: <ucgeexs6impgapot4a55cwzqy5kv374jkyhylojvpmstm7cf42@r4i5toizchn2>
On 5.07.2024 5:04 PM, Dmitry Baryshkov wrote:
> On Wed, Jul 03, 2024 at 11:17:01PM GMT, Taniya Das wrote:
>>
>>
>> On 6/21/2024 10:03 AM, Taniya Das wrote:
>>>> Please merge this into one to save on boilerplate, take a look
>>>> at dispcc-sc8280xp.c
>>>>
>>>
>>> I did take a look at the dispcc for SC8280XP before posting the series,
>>> but it kind of looked tricky to add fixes for a particular dispcc.
>>> Debugging could also be difficult in my opinion.
>>> Though I understand that we are trying to optimize by re-using few
>>> common structures/probe but from clocks side they are all redefined.
>>> That was the reason to keep them separate.
>>
>> Konrad, are you good with the proposal to keep the two instance of display
>> clock controllers as separate drivers? As I looking to post
>> the next patch series, please let me know your comments.
>
> I'd say, continue with the separate drivers.
+1
Konrad
next prev parent reply other threads:[~2024-07-06 12:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 10:47 [PATCH 0/8] Add support for SA8775P Multimedia clock controllers Taniya Das
2024-06-12 10:47 ` [PATCH 1/8] dt-bindings: clock: qcom: Add SA8775P video clock controller Taniya Das
2024-06-13 7:28 ` Krzysztof Kozlowski
2024-06-21 4:24 ` Taniya Das
2024-06-21 6:41 ` Krzysztof Kozlowski
2024-06-12 10:47 ` [PATCH 2/8] clk: qcom: Add support for Video clock controller on SA8775P Taniya Das
2024-06-12 10:47 ` [PATCH 3/8] dt-bindings: clock: qcom: Add SA8775P camera clock controller Taniya Das
2024-06-13 7:29 ` Krzysztof Kozlowski
2024-07-04 12:20 ` Markus Elfring
2024-07-04 12:51 ` Conor Dooley
2024-06-12 10:47 ` [PATCH 4/8] clk: qcom: Add support for Camera Clock Controller on SA8775P Taniya Das
2024-06-12 10:47 ` [PATCH 5/8] dt-bindings: clock: qcom: Add SA8775P display clock controllers Taniya Das
2024-06-13 7:30 ` Krzysztof Kozlowski
2024-06-12 10:47 ` [PATCH 6/8] clk: qcom: Add support for Display clock Controllers on SA8775P Taniya Das
2024-06-13 16:46 ` Konrad Dybcio
2024-06-21 4:33 ` Taniya Das
2024-07-03 17:47 ` Taniya Das
2024-07-05 15:04 ` Dmitry Baryshkov
2024-07-06 12:25 ` Konrad Dybcio [this message]
2024-06-12 10:47 ` [PATCH 7/8] arm64: dts: qcom: Add support for multimedia clock controllers Taniya Das
2024-06-12 10:47 ` [PATCH 8/8] arm64: dts: qcom: Update sleep_clk frequency to 32000 on SA8775P Taniya Das
2024-06-13 16:42 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d8e3779-aebf-4f27-bd54-58007b80192a@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).