From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 153972571A0 for ; Mon, 21 Sep 2026 02:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789958615; cv=none; b=AyjPaEU1XBlgh5Cus+Mc6T5zNmqdao1oQLoqVVMa438Z6pnRxO0nQ38FmYBnQ+UgLPp4psvfW/+ogFtW8KWNcXqGdfMUbZ1kyCFaAV4wIQsbgIguZk+xqZv9XPuLRAxM3ZFgK9FPHHTh1RI5GQyuI/LAg/bSzBIv6/7uDwmqbPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789958615; c=relaxed/simple; bh=2qCydK8u3BZHbP6bXSOaSC6oTwDHyDpQPRSmcbNzz4A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FK386o2byauexwnJcSrZQ6N1EnuegpEq5QlgmR7HV5qqTtuEd37vRjWIRueYb+wRI2Hoe2/0A+0A9And12EduWNlCa5GrTrMezzJPKpJlTvPWXr6Mg9QBaXYvN7mbltIery1hClmx8JI+MxfddzjqQFVbTCDsfjsbWtx+wLjmp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ilc4uIPV; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ilc4uIPV" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-398beb616f5so1061897a91.1 for ; Sun, 20 Sep 2026 19:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789958613; x=1790563413; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XjC/UZqLFtMb5vJyxy966HHDm1SdiObcPJD69fIKS4Q=; b=ilc4uIPV7qgnbFjNemL4roqgUH/7xxEyFoDY90lrVFHRKoRnr4Ad3fC0eBopA0Tfqv 5+N6FAWOw4GpqY0sdI77MwZa+Lr0zMIlTsgN/V9aXcVP4OyzW5LQD5izc3M75Ik/9Oyw Zg4Vuf4nrWZaiA38L120csPNf0mCCjnsbVBLDGH8LCWlk5Ij0C3Ax3kPAJU9p3rKAKtI CirlX/Mko1ECH99rbezGtyXc7TEhiA7A1BoqJixXPJoIdBZDoRY8PEMkjBC+ggTj65Hv jsTJs5kZQTb67lELMratPfX6j67E9FIt8AwkOQHZOHNWsKJJn7JX86CYVMZvqPPS1GBV e1Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789958613; x=1790563413; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XjC/UZqLFtMb5vJyxy966HHDm1SdiObcPJD69fIKS4Q=; b=N4mMa2R1Q+j5unSnIEzqwMhAL4fW9Mgcm2HoL4FlYTHY7SmaGMDDJaK2WFAkO65NF8 oTxAddPaJz1CxjFoqmbwa2at3jhDMGGLQbdpoqKDwJN2yGpM1Q5jwjkQQC+0Ky7s6iU3 dU4pTBrAJbMa+kyyxuVfT779VBhOa2ZWFj+rQ151Z3v5Y1GrfExgXsphbKwPx0c0umyc uEaTx72mEBlYM7pen8BOUInY5jm0gLmV458LC4xNyBZGRfu3ofOH/MXqwvxO7N8/cL0Y J6eCzqTun+OBFoJaO01fhXWHaImiq8/8l3A29ZnSMIps2bOT8zMWffLcaGh/4XB5GUov 4ZQA== X-Forwarded-Encrypted: i=1; AKwUvBwGoEPNhqzuVshhVRQQWcC1OYUo3YEDNPW4GaexlQs0a94hor85h+f/+iPZG7lfS+EHBQGtsOcK1miO@vger.kernel.org X-Gm-Message-State: AFuF++mY/H2c3HNUn1Agwv5qvS92RIaxntm4XTdUOwB99s2T4URUzKmm V6UfjK01foj1q36H6HHsp2gKTOWc1UnjUnSZ8eHGEA2YRqTBq6aQQwXu X-Gm-Gg: AYBFou0IvXet4pdyEDIm6M8can0ntF2192JtKGTIkVPWsvBgufJ0RLzky5cg11WNcXb njWIEHBlxSlAGpDKB7EcACPLspESR+EC9ZgFczWqWsxX1S8CWD45w023bM15yQ4ug5KdNs7mFCo +vO6bj0kh38f62fjjaACZVVkwTnWyHuNFU5Bwqx2Yr36ZFK01GHQnEQu2xfHzgGEWYA5n7gg0yC g2OPRYx497NxTRHmmCvBzovk/3SRfCh5BmwQurQHdk02de7vnMxlzABC/9tjI0zbovPEnkd5t2V qHUly88rHePAzwB1bPOTqBRpfyaE2tRlUfnNzvUZ1F+4mupDPhuaG/fyrWQPoRuE42czdB6z3cY ReKbkEIBgjJJDB9xBSvbG+gYdToSVNpc710TaUTLX0PazJMLGzDEXRzfAvuDIjmYpHkvUa/THRm yWcVRiwKphUS7F8Rut5oIlo8aln0GCyqA0phRV7QpwfOuz1j3ezLdNVjWgaYQ9UcPpsOkSHUwHJ GMcOVxetiJJRpmse903ZeNJP8NkDPsAOxJTn0g5fDFgNvfwdh2Gp7A= X-Received: by 2002:a17:90b:55c4:b0:3a0:34a4:187e with SMTP id 98e67ed59e1d1-3a034a41dc3mr3254394a91.15.1789958613234; Sun, 20 Sep 2026 19:43:33 -0700 (PDT) Received: from [192.168.0.100] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a02900f84fsm10384623a91.2.2026.09.20.19.43.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Sep 2026 19:43:32 -0700 (PDT) Message-ID: <1d988dfb-c930-4c17-ae77-47b93ff9f159@gmail.com> Date: Mon, 21 Sep 2026 10:43:28 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 7/7] drm/verisilicon: fix DC8200 primary plane disable clearing FB_EN To: Icenowy Zheng , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260918030125.315978-1-a0987203069@gmail.com> <20260918030125.315978-8-a0987203069@gmail.com> <4a7b271d2a90eff94c27dec3bf24114ce44df1fd.camel@iscas.ac.cn> Content-Language: en-US From: Joey Lu In-Reply-To: <4a7b271d2a90eff94c27dec3bf24114ce44df1fd.camel@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Icenowy Zheng 於 2026/9/18 下午 01:52 寫道: > 在 2026-09-18五的 11:01 +0800，Joey Lu写道： >> vs_dc8200_primary_plane_disable_ex() calls regmap_set_bits() on >> VSDC_FB_CONFIG_EX_FB_EN instead of regmap_clear_bits(), so disabling >> the primary plane on DC8200-family hardware actually leaves the >> framebuffer enable bit instead of clearing it. >> >> This bug predates this series: it was carried over unchanged from >> vs_primary_plane_atomic_disable() when patch "drm/verisilicon: >> introduce per-variant hardware ops table" split the DC8200-specific >> implementation out into vs_dc8200.c. >> >> Fixes: dbf21777caa8 ("drm: verisilicon: add a driver for Verisilicon >> display controllers") > Maybe it'd be better to fix this before adding DC variant abstraction, > for easier backporting. > > Thanks, > Icenowy Makes sense. Should I send it as a standalone patch targeting drm-misc-fixes (separate from this series), or do you have a different preference for how to split it? > >> Signed-off-by: Joey Lu >> --- >>  drivers/gpu/drm/verisilicon/vs_dc8200.c | 4 ++-- >>  1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/verisilicon/vs_dc8200.c >> b/drivers/gpu/drm/verisilicon/vs_dc8200.c >> index f72da10295e1b..25b5906a1c5fc 100644 >> --- a/drivers/gpu/drm/verisilicon/vs_dc8200.c >> +++ b/drivers/gpu/drm/verisilicon/vs_dc8200.c >> @@ -70,8 +70,8 @@ static void >> vs_dc8200_primary_plane_enable_ex(struct vs_dc *dc, unsigned int out >> >>  static void vs_dc8200_primary_plane_disable_ex(struct vs_dc *dc, >> unsigned int output) >>  { >> - regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), >> - VSDC_FB_CONFIG_EX_FB_EN); >> + regmap_clear_bits(dc->regs, VSDC_FB_CONFIG_EX(output), >> +   VSDC_FB_CONFIG_EX_FB_EN); >> >>   vs_dc8200_plane_commit(dc, output); >>  }