devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qii Wang <qii.wang@mediatek.com>
To: Kewei Xu <kewei.xu@mediatek.com>, <wsa@the-dreams.de>
Cc: <matthias.bgg@gmail.com>, <robh+dt@kernel.org>,
	<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>,
	<liguo.zhang@mediatek.com>, <caiyu.chen@mediatek.com>,
	<housong.zhang@mediatek.com>, <yuhan.wei@mediatek.com>,
	<ryan-jh.yu@mediatek.com>
Subject: Re: [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186
Date: Tue, 25 Jan 2022 19:27:44 +0800	[thread overview]
Message-ID: <1d9b53a22e307ca90cafbd6fe08fbae3c4c58531.camel@mediatek.com> (raw)
In-Reply-To: <20220125110413.18988-3-kewei.xu@mediatek.com>

On Tue, 2022-01-25 at 19:04 +0800, Kewei Xu wrote:
> Add i2c compatible for MT8186. Compare to MT8192 i2c controller,
> MT8186 doesn't need handshake signal witch apdma.
> 
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>

Reviewed-by: Qii Wang <qii.wang@mediatek.com>

> ---
>  drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c
> b/drivers/i2c/busses/i2c-mt65xx.c
> index 9ea427f53083..aa4d21838e14 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -397,6 +397,19 @@ static const struct mtk_i2c_compatible
> mt8183_compat = {
>  	.max_dma_support = 33,
>  };
>  
> +static const struct mtk_i2c_compatible mt8186_compat = {
> +	.regs = mt_i2c_regs_v2,
> +	.pmic_i2c = 0,
> +	.dcm = 0,
> +	.auto_restart = 1,
> +	.aux_len_reg = 1,
> +	.timing_adjust = 1,
> +	.dma_sync = 0,
> +	.ltiming_adjust = 1,
> +	.apdma_sync = 0,
> +	.max_dma_support = 36,
> +};
> +
>  static const struct mtk_i2c_compatible mt8192_compat = {
>  	.quirks = &mt8183_i2c_quirks,
>  	.regs = mt_i2c_regs_v2,
> @@ -418,6 +431,7 @@ static const struct of_device_id
> mtk_i2c_of_match[] = {
>  	{ .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat
> },
>  	{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat
> },
>  	{ .compatible = "mediatek,mt8183-i2c", .data = &mt8183_compat
> },
> +	{ .compatible = "mediatek,mt8186-i2c", .data = &mt8186_compat
> },
>  	{ .compatible = "mediatek,mt8192-i2c", .data = &mt8192_compat
> },
>  	{}
>  };


  reply	other threads:[~2022-01-25 11:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 11:04 [v2 0/2] add i2c support for mt8186 Kewei Xu
2022-01-25 11:04 ` [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC Kewei Xu
2022-01-25 11:26   ` Qii Wang
2022-01-28 21:46   ` Wolfram Sang
2022-02-07  2:53     ` Kewei Xu
2022-01-25 11:04 ` [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186 Kewei Xu
2022-01-25 11:27   ` Qii Wang [this message]
2022-01-28 21:46   ` Wolfram Sang
2022-01-28 21:46 ` [v2 0/2] add i2c support for mt8186 Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d9b53a22e307ca90cafbd6fe08fbae3c4c58531.camel@mediatek.com \
    --to=qii.wang@mediatek.com \
    --cc=caiyu.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=housong.zhang@mediatek.com \
    --cc=kewei.xu@mediatek.com \
    --cc=leilk.liu@mediatek.com \
    --cc=liguo.zhang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=ryan-jh.yu@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=wsa@the-dreams.de \
    --cc=yuhan.wei@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).