From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>,
robh+dt@kernel.org, pavel@ucw.cz, lee.jones@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 1/6] regulator: lm363x: Make the gpio register enable flexible
Date: Tue, 9 Apr 2019 20:44:47 +0200 [thread overview]
Message-ID: <1dcaa34b-cce6-63fc-5866-242c1757a4cb@gmail.com> (raw)
In-Reply-To: <20190405145540.27703-2-dmurphy@ti.com>
Hi Dan,
Regulator maintainers should be added too.
On 4/5/19 4:55 PM, Dan Murphy wrote:
> The use of and enablement of the GPIO can be used across devices.
> Use the enable_reg in the regulator descriptor for the register to
> write.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/regulator/lm363x-regulator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm363x-regulator.c
> index c876e161052a..382b1cecdd93 100644
> --- a/drivers/regulator/lm363x-regulator.c
> +++ b/drivers/regulator/lm363x-regulator.c
> @@ -263,8 +263,8 @@ static int lm363x_regulator_probe(struct platform_device *pdev)
>
> if (gpiod) {
> cfg.ena_gpiod = gpiod;
> -
> - ret = regmap_update_bits(regmap, LM3632_REG_BIAS_CONFIG,
> + ret = regmap_update_bits(regmap,
> + lm363x_regulator_desc[id].enable_reg,
> LM3632_EXT_EN_MASK,
> LM3632_EXT_EN_MASK);
> if (ret) {
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-04-09 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 14:55 [PATCH 0/6] LM36274 LMU Introduction Dan Murphy
2019-04-05 14:55 ` [PATCH 1/6] regulator: lm363x: Make the gpio register enable flexible Dan Murphy
2019-04-09 18:44 ` Jacek Anaszewski [this message]
2019-04-05 14:55 ` [PATCH 2/6] dt-bindings: mfd: Add lm36274 bindings to ti-lmu Dan Murphy
2019-04-05 14:55 ` [PATCH 3/6] mfd: ti-lmu: Add LM36274 support to the ti-lmu Dan Murphy
2019-04-05 14:55 ` [PATCH 4/6] regulator: lm363x: Add support for LM36274 Dan Murphy
2019-04-05 14:55 ` [PATCH 5/6] dt-bindings: leds: Add LED bindings for the LM36274 Dan Murphy
2019-04-08 10:10 ` Pavel Machek
2019-04-10 11:37 ` Dan Murphy
2019-04-05 14:55 ` [PATCH 6/6] leds: lm36274: Introduce the TI LM36274 LED driver Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dcaa34b-cce6-63fc-5866-242c1757a4cb@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).