From: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Faiz Abbas <faiz_abbas-l0cyMroinI0@public.gmane.org>,
wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org
Cc: linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
nsekhar-l0cyMroinI0@public.gmane.org,
fcooper-l0cyMroinI0@public.gmane.org,
robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Wenyou.Yang-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org,
sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org
Subject: Re: [PATCH v8 3/5] can: m_can: Move allocation of net device to probe
Date: Tue, 16 Jan 2018 15:00:25 +0100 [thread overview]
Message-ID: <1dcb2038-cc6d-44e5-fe51-e43041b1fe5f@pengutronix.de> (raw)
In-Reply-To: <caa11848-3c69-1229-e4b8-09e51cebe739-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1035 bytes --]
On 01/16/2018 02:03 PM, Marc Kleine-Budde wrote:
>> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
>> index 893edbb..ebb74de 100644
>> --- a/drivers/net/can/m_can/m_can.c
>> +++ b/drivers/net/can/m_can/m_can.c
>> @@ -1207,25 +1207,20 @@ static bool m_can_niso_supported(const struct m_can_priv *priv)
>> return !niso_timeout;
>> }
>>
>> -static struct net_device *alloc_m_can_dev(struct platform_device *pdev,
>> - void __iomem *addr, u32 tx_fifo_size)
>> +static int setup_m_can_dev(struct platform_device *pdev, struct net_device *dev,
>> + void __iomem *addr)
>
> Renamed to m_can_dev_setup() for consistent namespace.
And removed free_m_can_dev(), by calling free_candev() directly.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-16 14:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 11:37 [PATCH v8 0/5] Add MCAN Support for Dra76 platform Faiz Abbas
2018-01-16 11:37 ` [PATCH v8 1/5] dt-bindings: can: m_can: Document new can transceiver binding Faiz Abbas
2018-01-16 11:37 ` [PATCH v8 2/5] dt-bindings: can: can-transceiver: Document new binding Faiz Abbas
2018-01-16 11:37 ` [PATCH v8 3/5] can: m_can: Move allocation of net device to probe Faiz Abbas
[not found] ` <1516102634-6771-4-git-send-email-faiz_abbas-l0cyMroinI0@public.gmane.org>
2018-01-16 13:03 ` Marc Kleine-Budde
[not found] ` <caa11848-3c69-1229-e4b8-09e51cebe739-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2018-01-16 14:00 ` Marc Kleine-Budde [this message]
2018-01-16 11:37 ` [PATCH v8 4/5] can: m_can: Add PM Support Faiz Abbas
2018-01-16 12:57 ` Marc Kleine-Budde
2018-01-16 11:37 ` [PATCH v8 5/5] can: m_can: Support higher speed CAN-FD bitrates Faiz Abbas
2018-01-16 14:12 ` [PATCH v8 0/5] Add MCAN Support for Dra76 platform Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dcb2038-cc6d-44e5-fe51-e43041b1fe5f@pengutronix.de \
--to=mkl-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=Wenyou.Yang-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org \
--cc=b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=faiz_abbas-l0cyMroinI0@public.gmane.org \
--cc=fcooper-l0cyMroinI0@public.gmane.org \
--cc=linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).