From: Stephen Boyd <sboyd@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, ilia.lin@kernel.org,
konrad.dybcio@linaro.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
mturquette@baylibre.com, quic_kathirav@quicinc.com,
rafael@kernel.org, robh+dt@kernel.org, viresh.kumar@linaro.org
Cc: Varadarajan Narayanan <quic_varada@quicinc.com>
Subject: Re: [PATCH v2 4/8] clk: qcom: apss-ipq6018: ipq5332: add safe source switch for a53pll
Date: Thu, 12 Oct 2023 13:51:00 -0700 [thread overview]
Message-ID: <1dfef5d380b3a5f920620fbf491280f9.sboyd@kernel.org> (raw)
In-Reply-To: <000c61a028814f08a9fc6d1d5c446e8dad11a650.1697101543.git.quic_varada@quicinc.com>
Quoting Varadarajan Narayanan (2023-10-12 02:26:20)
> diff --git a/drivers/clk/qcom/apss-ipq6018.c b/drivers/clk/qcom/apss-ipq6018.c
> index 4e13a08..c05c2b2 100644
> --- a/drivers/clk/qcom/apss-ipq6018.c
> +++ b/drivers/clk/qcom/apss-ipq6018.c
> @@ -84,15 +87,63 @@ static const struct qcom_cc_desc apss_ipq6018_desc = {
> .num_clks = ARRAY_SIZE(apss_ipq6018_clks),
> };
>
> +static int cpu_clk_notifier_fn(struct notifier_block *nb, unsigned long action,
> + void *data)
> +{
> + struct clk_hw *hw;
> + u8 index;
> + int err;
> +
> + if (action == PRE_RATE_CHANGE)
> + index = P_GPLL0;
> + else if ((action == POST_RATE_CHANGE) || (action == ABORT_RATE_CHANGE))
This has too many parenthesis.
> + index = P_APSS_PLL_EARLY;
> + else
> + return 0;
Maybe 'return NOTIFY_OK' instead?
> +
> + hw = &apcs_alias0_clk_src.clkr.hw;
> + err = clk_rcg2_mux_closest_ops.set_parent(hw, index);
> +
> + return notifier_from_errno(err);
> +}
> +
> +static struct notifier_block cpu_clk_notifier = {
Instead of a static global can this be allocated with kzalloc?
> + .notifier_call = cpu_clk_notifier_fn,
> +};
> +
> static int apss_ipq6018_probe(struct platform_device *pdev)
next prev parent reply other threads:[~2023-10-12 20:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 9:26 [PATCH v2 0/8] Enable cpufreq for IPQ5332 & IPQ9574 Varadarajan Narayanan
2023-10-12 9:26 ` [PATCH v2 1/8] clk: qcom: clk-alpha-pll: introduce stromer plus ops Varadarajan Narayanan
2023-10-12 20:55 ` Stephen Boyd
2023-10-16 7:02 ` Varadarajan Narayanan
2023-10-16 8:46 ` Dmitry Baryshkov
2023-10-18 9:35 ` Varadarajan Narayanan
2023-10-12 9:26 ` [PATCH v2 2/8] clk: qcom: apss-ipq-pll: Use stromer plus ops for stromer plus pll Varadarajan Narayanan
2023-10-12 9:26 ` [PATCH v2 3/8] clk: qcom: apss-ipq-pll: Fix 'l' value for ipq5332_pll_config Varadarajan Narayanan
2023-10-12 9:26 ` [PATCH v2 4/8] clk: qcom: apss-ipq6018: ipq5332: add safe source switch for a53pll Varadarajan Narayanan
2023-10-12 20:51 ` Stephen Boyd [this message]
2023-10-19 1:15 ` kernel test robot
2023-10-12 9:26 ` [PATCH v2 5/8] cpufreq: qti: Enable cpufreq for ipq53xx Varadarajan Narayanan
2023-10-12 9:26 ` [PATCH v2 6/8] arm64: dts: qcom: ipq5332: populate the opp table based on the eFuse Varadarajan Narayanan
2023-10-12 9:26 ` [PATCH v2 7/8] cpufreq: qti: Introduce cpufreq for ipq95xx Varadarajan Narayanan
2023-10-12 9:26 ` [PATCH v2 8/8] arm64: dts: qcom: ipq9574: populate the opp table based on the eFuse Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dfef5d380b3a5f920620fbf491280f9.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ilia.lin@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).