From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23330EE49A3 for ; Tue, 22 Aug 2023 15:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237204AbjHVPjG (ORCPT ); Tue, 22 Aug 2023 11:39:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237162AbjHVPjF (ORCPT ); Tue, 22 Aug 2023 11:39:05 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D29871B2 for ; Tue, 22 Aug 2023 08:39:00 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-99bcc0adab4so597342466b.2 for ; Tue, 22 Aug 2023 08:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692718739; x=1693323539; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7uDZNE/L2WypJzzrI7vqxRXdhClZjfBh3CCjZ36A17c=; b=KR5CKO3txtjG3t2iB9uTdoOqPbb50mrTmkVmG9sRhDQfi8JoN4zJzwdNQK6W/RgEHm j6FCSbBNhOavnBr+r9kJO5qLyWgxGoDVWxT11kCXf5Aw9PG272XQmsMVAER6NEd6aide T/n/zjZOmQ8B+uXfmVxMbw+e3WGFAycPe/AEne4GScjp+4+G+SIOv1osF4wNI729TOM6 3Q9u690LuLgVGpSyd/AvrTyHInE+j5BcYsPJNxi/PbGu5dv9FnAptWxBPYxLZwyVGcKB rQv6RV5xsOzXJPw2XL2Q/XpYe32zdgFLylpUTsxVYvIPMYrOPhxm5SfcvpSV78D4+8ce 7hvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692718739; x=1693323539; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7uDZNE/L2WypJzzrI7vqxRXdhClZjfBh3CCjZ36A17c=; b=lssnJbhGZ7WtjG4ProAwKhn2JtmLeyWzKGHEtW2FMwV7vLLRQ19fLSyP0qdGCQEYq6 9PyO9wGJxW2Rg1OTRw1IMwlRG8TCu/t0DPI93Ff9W+XYsuLQyQPKZ0WsiFEVFLl4dU3k EjDzy50l4U5Ur9KyB9pGqnhZYU5gcsOJmJFQs5gcH1Okvc2JzbC6VNPza5no9opucEU+ mCkMqdcdKslPcyjXkeJDJD0vsIG2Yd8/xNx5Y1uCuo/IfsT4/W7Mima/XYrXk71H/30A KZaONQpP4p8skbrOUN+BzdHAJ6NAVfGN+5xT8krN+TS4bYFh325yHFH1KzUzzZm72YTU 5bOQ== X-Gm-Message-State: AOJu0Ywty6ixHOACZP/IhZ7oadXaldsKYpqL3CGcgzY+cb96xFc5Lx30 q09M/73+uZLZ7JE+0dShbsuG6Q== X-Google-Smtp-Source: AGHT+IHgJywDjqvWr4qipa5JD526Rk7A2oYdS4BbDCxC+VwxCzxAmx6wZN+j+yHCJEBntWf40M7SEQ== X-Received: by 2002:a17:907:77d8:b0:99b:c517:88a1 with SMTP id kz24-20020a17090777d800b0099bc51788a1mr7367250ejc.67.1692718739384; Tue, 22 Aug 2023 08:38:59 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id y21-20020a1709063a9500b0099364d9f0e6sm8371210ejd.117.2023.08.22.08.38.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 08:38:58 -0700 (PDT) Message-ID: <1e0632d6-73e9-4633-a709-bf9140f2fd32@linaro.org> Date: Tue, 22 Aug 2023 17:38:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v1 2/2] dt-bindings: extcon: Add Realtek DHC RTD SoC Type-C Content-Language: en-US To: Stanley Chang , MyungJoo Ham Cc: Chanwoo Choi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230822102846.4683-1-stanley_chang@realtek.com> <20230822102846.4683-2-stanley_chang@realtek.com> From: Krzysztof Kozlowski In-Reply-To: <20230822102846.4683-2-stanley_chang@realtek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/08/2023 12:28, Stanley Chang wrote: > Document the device-tree bindings for Realtek SoCs Type-C. > Realtek DHC (digital home center) RTD SoCs support a Type-C module. > > Signed-off-by: Stanley Chang > --- > .../bindings/extcon/extcon-rtk-type-c.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/extcon/extcon-rtk-type-c.yaml Filename like compatible. > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-rtk-type-c.yaml b/Documentation/devicetree/bindings/extcon/extcon-rtk-type-c.yaml > new file mode 100644 > index 000000000000..d14b9ee544b9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/extcon/extcon-rtk-type-c.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2023 Realtek Semiconductor Corporation > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/extcon/extcon-rtk-type-c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek DHC RTD SoCs USB Type-C detection Type-c usually go to usb directory. > + > +maintainers: > + - Stanley Chang > + > +description: | Do not need '|' unless you need to preserve formatting. > + Realtek digital home center (DHC) RTD series SoCs include a type c module. > + This module is able to detect the state of type c connector. > + > +properties: > + compatible: > + enum: > + - realtek,rtd1295-type-c > + - realtek,rtd1312c-type-c > + - realtek,rtd1315e-type-c > + - realtek,rtd1319-type-c > + - realtek,rtd1319d-type-c > + - realtek,rtd1395-type-c > + - realtek,rtd1619-type-c > + - realtek,rtd1619b-type-c > + > + reg: > + maxItems: 1 > + description: Address and length of register set for type-c module. Drop description, it's obvious. > + > + interrupts: > + maxItems: 1 > + > + nvmem-cells: > + maxItems: 1 > + description: > + The phandle to nvmem cell that contains the trimming data. > + If unspecified, default value is used. > + > + pinctrl-names: > + const: default > + description: A pinctrl state names "default" must be defined. Drop, property not needed. > + > + pinctrl-0: > + description: > + Should contain default pinctrl. Drop, property not needed. > + > + nvmem-cell-names: > + const: usb-cal items: - const: usb-cal and move description to nvmem-cells. > + description: > + The type c parameter trimming data specified via efuse. Keep same properties next to each other. nvmem-cells should be followed by nvmem-cell-names. > + > + realtek,rd-ctrl-gpio: > + description: The gpio node to control external Rd on board. The names are always "gpios". > + maxItems: 1 > + You miss here connector. Probably also VBUS supply and other supplies. > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + type-c@7220 { > + compatible = "realtek,rtd1619b-type-c"; > + reg = <0x7220 0x20>; > + interrupts = <0 60 4>; Use proper defines for common constants. > + > + pinctrl-names = "default"; > + pinctrl-0 = <&usb_cc1_pins>, <&usb_cc2_pins>; > + nvmem-cells = <&otp_usb_cal>; > + nvmem-cell-names = "usb-cal"; Type-c without connector? This is incomplete. > + }; Best regards, Krzysztof