From: Dmitry Osipenko <digetx@gmail.com>
To: Joseph Lo <josephl@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>
Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 5/8] memory: tegra: Add EMC scaling support code for Tegra210
Date: Thu, 30 May 2019 19:14:13 +0300 [thread overview]
Message-ID: <1e197124-57f5-285b-1624-bba2f3d31386@gmail.com> (raw)
In-Reply-To: <20190529082139.5581-6-josephl@nvidia.com>
29.05.2019 11:21, Joseph Lo пишет:
> This patch adds the required APIs and variables for the EMC scaling
> sequence code on Tegra210.
>
> Based on the work of Peter De Schrijver <pdeschrijver@nvidia.com>.
>
> Signed-off-by: Joseph Lo <josephl@nvidia.com>
> ---
> v4:
> - fix the API with generic naming
> - use 'u16' in 'struct emc_table_register_offset'
> ---
>
> +extern const struct emc_table_register_offset reg_off;
> +extern unsigned long dram_over_temp_state;
Please avoid global variables where they are not really needed.
Add reg_off pointer to tegra_emc.
Remove dram_over_temp_state variable entirely and replace it with
TEGRA_DRAM_OVER_TEMP_NONE in the code since nothing changes the variable.
Again, prepend all global symbols with tegra210_.
Alternatively you could simply include tegra210-emc-cc-r21021.c into
tegra210-emc.c, I don't see anything wrong with that variant.
#include "tegra210-emc-cc-r21021.c"
Or you could squash it all into a single source file if variants other
than "r21021" are not planned to be supported. This will help to reduce
messiness of the code and will allow compiler to better optimize it all.
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-30 16:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 8:21 [PATCH V4 0/8] Add EMC scaling support for Tegra210 Joseph Lo
2019-05-29 8:21 ` [PATCH V4 1/8] dt-bindings: memory: tegra: Add external memory controller binding " Joseph Lo
2019-05-29 8:21 ` [PATCH V4 2/8] clk: tegra: Add PLLP_UD and PLLMB_UD " Joseph Lo
2019-05-29 8:21 ` [PATCH V4 3/8] clk: tegra: Export functions for EMC clock scaling Joseph Lo
2019-05-29 8:21 ` [PATCH V4 4/8] memory: tegra: Add Tegra210 EMC clock driver Joseph Lo
2019-05-29 13:26 ` Dmitry Osipenko
2019-05-30 2:45 ` Joseph Lo
2020-02-26 16:57 ` Thierry Reding
2020-02-27 15:18 ` Dmitry Osipenko
2019-05-29 8:21 ` [PATCH V4 5/8] memory: tegra: Add EMC scaling support code for Tegra210 Joseph Lo
2019-05-29 13:37 ` Dmitry Osipenko
2019-05-30 2:45 ` Joseph Lo
2019-05-30 11:20 ` Dmitry Osipenko
2019-05-30 16:14 ` Dmitry Osipenko [this message]
2019-05-29 8:21 ` [PATCH V4 6/8] memory: tegra: Add EMC scaling sequence " Joseph Lo
2019-05-30 13:16 ` Dmitry Osipenko
2019-05-29 8:21 ` [PATCH V4 7/8] clk: tegra: Remove the old emc_mux clock " Joseph Lo
2019-05-29 12:49 ` Dmitry Osipenko
2019-05-30 2:06 ` Joseph Lo
2019-05-29 8:21 ` [PATCH V4 8/8] arm64: tegra: Add external memory controller node " Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e197124-57f5-285b-1624-bba2f3d31386@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).