Re: [PATCH v6 4/8] hwmon: (amc6821) add support for tsd,mule

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/08/2024 15:21, Guenter Roeck wrote:
> On 8/12/24 04:38, Krzysztof Kozlowski wrote:
>> On 31/07/2024 17:12, Guenter Roeck wrote:
>>> On Thu, Jul 25, 2024 at 03:27:50PM +0200, Farouk Bouabid wrote:
>>>> Theobroma Systems Mule is an MCU that emulates a set of I2C devices,
>>>> among which is an amc6821 and other devices that are reachable through
>>>> an I2C-mux.
>>>>
>>>> The devices on the mux can be selected by writing the appropriate device
>>>> number to an I2C config register (amc6821: reg 0xff)
>>>>
>>>> Implement "tsd,mule" compatible to instantiate the I2C-mux platform device
>>>> when probing the amc6821.
>>>>
>>>> Signed-off-by: Farouk Bouabid <farouk.bouabid@cherry.de>
>>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> Applied.
>>
>> Eh, there is undocumented dependency on I2C here. Next has warning
>> because of this.
>>
>> Farouk, please *always mention* the dependencies between patches.
>>
>> Best regards,
>> Krzysztof
>>
>>
> Sorry, I wasn't aware that all bindings have to be in the tree before I apply
> patches, and I somehow had the apparently wrong impression that the bindings

None of us were aware of it and bindings were in fact approved, so I
would do the same as you - picked up patches.

> were approved. I'll drop the two patches (this one and the DT patch for
> amc6821). Someone may need to remind me to re-apply them after all
> pre-dependencies are in the tree.

Thanks, that would solve the issue.

Best regards,
Krzysztof