From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98842377566 for ; Tue, 14 Jul 2026 11:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784027027; cv=none; b=qQscwnvdmIpoS8FIQAJ3qxNHsEiBOoEI+uFm/m2WpvrNJ+VHJ6ZDcEgh/QhTYffqV8P5Z6462c8pw4u+bSvPqeikmtj5ckzTZhvsQMr6w+HyYaAWUPXN861eBdwFvJCAyc4VoOzTtACsvd8e3SbmMu3BHIvxGchBbgMNNFG28RU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784027027; c=relaxed/simple; bh=nRXqOwRrDIdwQBvgebmXi2daQrVI9gYsamm/tsW5/rw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dnSKMdg+gHWFbV+8Q0h4KxZi14IQoQu2ZOthXpeLYjpWVe57faIP8kqwtJtwhrJNOl74yADV8B3XxNLcuIKVUviCxdNN6VVxZKBb0Nq5l40B9R4zaX3GWbdB3HMedROwOGZjhjYT5W2GX48UxNi5+5U4XIipekSIWgklk4luAWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ECIQn36r; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ECIQn36r" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-493b779003fso17812705e9.3 for ; Tue, 14 Jul 2026 04:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784027024; x=1784631824; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xUlBoKh9V23To8DEkY2V3YxhmQz/dU01CR+2A2ONytA=; b=ECIQn36rKfAxtMeY16RzqQa2S/TzZW5eGdbyS27dWoSjIQqWZvrHvlgNu1HtOUMh/h sUkTfGfgcuBnMeAuSXa18C2jeqLqwU3fW5sYs5hNMpzkDr+McUZlF5N39Coo9QXc0Uvk 81W92cneSKpBnQypdzDxVpqi9ePWuTMnotRTaiYwRJFNOYu1D9nnMQmsy4siyJ2G3jQ2 NSbID6NPz5Of38OFEy0AFJf5UusSn0IQ6yhe+5e6NVAUaFTarK+M8xevnQAXLbTiXYjY RWGUoGgDrgbsj15kz7oyJOZIXniqa2W3GLcAVzAAlOe8LIBHr0NqwDOdQ7JMuUv51BnW Mijw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784027024; x=1784631824; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xUlBoKh9V23To8DEkY2V3YxhmQz/dU01CR+2A2ONytA=; b=RHFpJTW5sc62HYuELeA/4BLiBBQxj23zP3v1EsvCDFyIqpPsD6NWQOtVs3wDICUq1x 8ieg7qPl1kO0R9xutVIhPDH9/QjgVte4LyiUc0PK3NN9J6xyh/sapCpmmRgFAFtn2enG 3tBc0X6Rs7XOI59nHtA7POhOGTCnsicbMPu/7/eyK1iMCAKF+SUGucs2eMh1pfFBLN2O 7z2EkQliJPjQVr3x/hMrx7GbrFK5kyH3oWtILQSgvP1g0M3jbmTHbX6NwuQ9kOAnN+vs ANZPvYfpHGLNGIyMloL/lPTrENX7A63IZxUNxAMVNz6/YxepGgS5b0hAeapyUJNKn1al MTnQ== X-Forwarded-Encrypted: i=1; AHgh+RqdzlkKBHlzIIEYnlA2h1bIYtyKzS8yHN+jW44apSvuCO6nFnEGVdQikj16lobbquTl0PFhJ9nX8Wmq@vger.kernel.org X-Gm-Message-State: AOJu0Yzxm++7wbiT4xsq/6dnSCY7V16nqmlFGMTwqB0hbCzbsNXySgSi P0i/WN1B1X5HNui4y8eRHo4N9D4D+amvYnSxYVDfOGWU2djMenikQGyW X-Gm-Gg: AfdE7clOUz1LwGRdAWxvOfxYTroLRNmmiRu700Xt5uvJuZ6oXBYkkOQB5x1GY4P3bo4 uAMHOWsRK1Lylgzz3epQcdYHdosNd9wipvADKKLW+CXU0XuzkztmMKAipyC9adZpN9LzUKs8+Qt VJDQguLwYV3UEf5SLdlk7iFQb81g3fvKadwisq5XAg01Vim8XCRSiYSL4xSNvw/B0Cjtwr/NMMJ LdOmDOeFPGQkhZ0qZyWUB1RUUGFdSBjiMjuOefd2FdRsnjDzMyZaLbn5ECN2YTaVAv9kUZ/uS1W d42N6BLIrAjgxS3wn5VonPvFYGdhEqe85X3eWgzI5X7HccvF78Zp7Orhar5DiRUpYBI8Flj9a7o XhgBqHTRlA6XrTsa6zYHBJQJ1v01lyZ/8UuJpWO2QdFd21X3zN7WpGHgHRo5nuz0q6RJYzxWK4S v6Ip6Oj1pJK8eBgIsjXWAOHRYUxAqVSr8IwtfKLuf7teLKoimG4QBf8sYF2W8ljJRJ X-Received: by 2002:a05:600c:528e:b0:493:edc2:98ab with SMTP id 5b1f17b1804b1-495389cc4bemr20361535e9.28.1784027023678; Tue, 14 Jul 2026 04:03:43 -0700 (PDT) Received: from ?IPV6:2a02:3033:600:7200:8c5:6bb4:871f:52ad? ([2a02:3033:600:7200:8c5:6bb4:871f:52ad]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49510c8e220sm57914405e9.15.2026.07.14.04.03.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 04:03:42 -0700 (PDT) Message-ID: <1e353a66-3543-4a6f-91b6-d5e8524d9754@gmail.com> Date: Tue, 14 Jul 2026 13:03:40 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] gpio: ad7768: Add AD7768 GPIO auxiliary driver To: Andy Shevchenko , Janani Sunil Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Olivier Moysan , Philipp Zabel , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Shuah Khan , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org References: <20260709-ad7768-driver-v1-0-44e1194fd96a@analog.com> <20260709-ad7768-driver-v1-5-44e1194fd96a@analog.com> Content-Language: en-US From: Janani Sunil In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/9/26 13:05, Andy Shevchenko wrote: > On Thu, Jul 09, 2026 at 10:50:16AM +0200, Janani Sunil wrote: >> The AD7768/AD7768-4 ADC exposes 5 general-purpose I/O pins that can be >> independently configured as inputs or outputs. Add an auxiliary bus driver >> to expose these pins as a GPIO chip, registered by the parent IIO driver. >> >> The driver uses the parent's regmap for register access and delegates >> runtime power management to the parent device. >> + if (ret) >> + return ret; >> + >> + return regmap_update_bits(st->regmap, AD7768_REG_GPIO_CONTROL, >> + BIT(offset), AD7768_GPIO_INPUT); >> +} > ... > > So, I briefly looked at the implementation and I don't understand why > gpio-regmap can't be used. Do you need PM runtime there? It can be > done for all (if absent). > > ... gpio-regmap does not naturally model the AD7768's direction dependent readback behavior. On this device, GPIO Write data (0x0F) holds the latched output values and the GPIO Read Data (0x10) reads the logic input level only when the pins are configured as inputs. Using the generic gpio-regmap would always read 0x10 including output GPIOs. The custom implementation preserves the device specific behavior. Best Regards, Janani Sunil