From: Jon Hunter <jonathanh@nvidia.com>
To: Sandipan Patra <spatra@nvidia.com>, <treding@nvidia.com>,
<robh+dt@kernel.org>, <u.kleine-koenig@pengutronix.de>
Cc: <bbasu@nvidia.com>, <ldewangan@nvidia.com>,
<linux-pwm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pwm: tegra: Add support for Tegra194
Date: Mon, 23 Mar 2020 11:36:07 +0000 [thread overview]
Message-ID: <1e40daf7-e5f8-7b79-cabe-8aceef6dda58@nvidia.com> (raw)
In-Reply-To: <1583407653-30059-1-git-send-email-spatra@nvidia.com>
On 05/03/2020 11:27, Sandipan Patra wrote:
> Tegra194 has multiple PWM controllers with each having only one output.
>
> Also the maxmimum frequency is higher than earlier SoCs.
>
> Add support for Tegra194 and specify the number of PWM outputs and
> maximum supported frequency using device tree match data.
>
> Signed-off-by: Sandipan Patra <spatra@nvidia.com>
> ---
> Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 1 +
> drivers/pwm/pwm-tegra.c | 6 ++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
> index 0a69ead..74c41e3 100644
> --- a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
> @@ -9,6 +9,7 @@ Required properties:
> - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132
> - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210
> - "nvidia,tegra186-pwm": for Tegra186
> + - "nvidia,tegra194-pwm": for Tegra194
> - reg: physical base address and length of the controller's registers
> - #pwm-cells: should be 2. See pwm.yaml in this directory for a description of
> the cells format.
> diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
> index aa12fb3..d26ed8f 100644
> --- a/drivers/pwm/pwm-tegra.c
> +++ b/drivers/pwm/pwm-tegra.c
> @@ -282,9 +282,15 @@ static const struct tegra_pwm_soc tegra186_pwm_soc = {
> .max_frequency = 102000000UL,
> };
>
> +static const struct tegra_pwm_soc tegra194_pwm_soc = {
> + .num_channels = 1,
> + .max_frequency = 408000000UL,
> +};
> +
> static const struct of_device_id tegra_pwm_of_match[] = {
> { .compatible = "nvidia,tegra20-pwm", .data = &tegra20_pwm_soc },
> { .compatible = "nvidia,tegra186-pwm", .data = &tegra186_pwm_soc },
> + { .compatible = "nvidia,tegra194-pwm", .data = &tegra194_pwm_soc },
> { }
> };
> MODULE_DEVICE_TABLE(of, tegra_pwm_of_match);
>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
prev parent reply other threads:[~2020-03-23 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 11:27 [PATCH] pwm: tegra: Add support for Tegra194 Sandipan Patra
2020-03-06 7:28 ` Uwe Kleine-König
2020-03-06 9:03 ` Laxman Dewangan
2020-03-10 21:43 ` Rob Herring
2020-03-23 11:36 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e40daf7-e5f8-7b79-cabe-8aceef6dda58@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=spatra@nvidia.com \
--cc=treding@nvidia.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).