From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31A353019D9; Fri, 16 Jan 2026 08:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768552467; cv=none; b=LkIuJl1Mmbb37nOUbucBd/ICTPxX5r5C2CwyUf7Jkk8NTaeIAAT9+hWlckFqHDD8SskMuaub6Xq9omu7EXZY+zLdeexxa7anG2F4QJfaVXO9cMCo0cwYGk1gWQc6nmMlZVrvB5LMh0WiUIflGTsNowUrbJZO/MuY0/cAUy2bEVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768552467; c=relaxed/simple; bh=a9tjrZw2TcFjoDfFV+ERPOr3LmyNFX/P9bnXZTro2bI=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=PzZydgziUVNUyv770NpqCBd6uPMLXBO6BNcJtWFtckcvmnCKqdcP5ESdXDD7jThDaABR/C4gPPH1c+cvbraFAePcZVHlHDp/swdUPo3rWKob1Ha0w8uwy4mxjVvfdazVM1voZ/e1mVOXR3RgVDZrExqv+0JNz7DTbSlwyn9uzmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ek7hQtLW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ek7hQtLW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57F8EC116C6; Fri, 16 Jan 2026 08:34:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768552466; bh=a9tjrZw2TcFjoDfFV+ERPOr3LmyNFX/P9bnXZTro2bI=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=ek7hQtLWk2LH8rttxYykyZVLHVfXaAFY9rplEfn/ctOGxfaJpbRG4KMclPqdSeON6 G8PsCQqygZbgerqtLjDLlh0iKvt6ymZQ166mjEgBgbOJdTqV/u5S01ZVYFGmCFeY7G RHZOfKg7NmtEyRd6foXhfhlWr+wd4vobNoxTFrdPa58vI1vUrbTOJKimu2CgY13+CU Kry4x1etbFUH6+Epfa34dbuWjZ59JAMdwqzIqGv8lnZiucdsPHmO3RmdqUQIc3Mn4s ComVcNHTwZ8YjD352+A5AcKarUa7vi0qMaYmWGBU7jAAvkVspP5+IX/ViC60bKL32n HypHshQEzJeIA== Message-ID: <1e65bcd0-54c1-41ff-8552-6ed5c56c1f70@kernel.org> Date: Fri, 16 Jan 2026 09:34:22 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404 support From: Krzysztof Kozlowski To: Antoniu Miclaus Cc: Peter Rosin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Johan Hovold , Bartosz Golaszewski , David Lechner , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260115121943.23715-1-antoniu.miclaus@analog.com> <20260115121943.23715-4-antoniu.miclaus@analog.com> <20260116-invaluable-ambitious-piculet-dade13@quoll> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260116-invaluable-ambitious-piculet-dade13@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/01/2026 09:29, Krzysztof Kozlowski wrote: > On Thu, Jan 15, 2026 at 02:18:21PM +0200, Antoniu Miclaus wrote: >> Add adi,adg2404 as a compatible string. The ADG2404 is a 4:1 analog >> multiplexer that uses the enable-gpios feature. >> >> Signed-off-by: Antoniu Miclaus >> --- >> changes in v3: >> * integrate with gpio-mux bindings instead of separate adi,adg2404.yaml >> --- >> .../devicetree/bindings/mux/gpio-mux.yaml | 19 ++++++++++++++++++- >> 1 file changed, 18 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml >> index 199792d42323..f5866b9f46dd 100644 >> --- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml >> +++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml >> @@ -19,7 +19,9 @@ description: |+ >> >> properties: >> compatible: >> - const: gpio-mux >> + enum: >> + - gpio-mux >> + - adi,adg2404 > > I do not understand why this was placed in gpio-mux. You have a strictly > defined hardware, with known muxes, not a flexible semi-software > binding. > > Otherwise please explain: why do you have both 0 and 1 cells? > > This is supposed to be in its own binding. After reading further patches - this patch does not make sense, but it should not be its own binding. Rob at v2 gave you advice what should be done. Best regards, Krzysztof