From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D573E1D1744 for ; Mon, 21 Oct 2024 07:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729495378; cv=none; b=fLx8fv0z0gEdfKPsMgD6F3XQLCQjyCWpVjetAZCJ8ounft0DgglxgXz0KD7fiMUXjcalEZPPw80aTVUHx4/4EPtJ2Qazh6QYP08IjtA4nGt2xdJsKhNvhEcFzNE1sqwevPoJ6XXVAhQMyYGaWEAdHQIcv4uAaTkyLhY/AJG8qxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729495378; c=relaxed/simple; bh=akqdO3psSSDcqPoPmRfhBaq7KYA8OuLkph2vgmsZ1Rk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=OGsoF/ljW/PFXYMME4i+Jc4USpfavpY87cLFaOhMrefp1Yi19I5eyhqSl5hv0C5Y6svnxfv4ahXLUPd4K78sJ4F+dbHWjhJ3Ib2xZzo8Gt89i6wVVL8x0veoBDA61CFcfluwgy2BNhX3tLmwLHZdkGiv+6EHo+/RfRJ6Wq+id1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GyPMG86s; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GyPMG86s" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43161e7bb25so27435095e9.2 for ; Mon, 21 Oct 2024 00:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729495373; x=1730100173; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3hGXgeNMIw4U0yQPd3D3dKiR4l6lD9w9YryhZf6FB70=; b=GyPMG86srfmSTYEaJt5uC0PAtf2Pi470RvQBg+U7lK5a/e2Qlhrga3LzyM53muHYZQ wfc1yNeVHbb3no45jCXVE6YCN8JlC9Nfu7IY9wY1kAm9jPzyxsdoEiJuqMc3GiIytstu IY1IYfHXHg5N9szmZw4jLncyT4gQ3FkhYHty68UC/qtJ99TqwHqll4M8Eak1KDOzGt4t gyqyxUWXc30mxJIa0+nncEMoC9l8ongBJnGgKHjsnT2k8FDZTSDj6LNcjlqUx/JblRCU kv36ENO+0zQNKd96xprNdPNJJEKa77/mKHA7nZopFXstQstqNVWaS84p7xImKo4nUh2H 46eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729495373; x=1730100173; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3hGXgeNMIw4U0yQPd3D3dKiR4l6lD9w9YryhZf6FB70=; b=uSwotI7d8RnE8vjKqHtv8UpwhOy6frDeQRhCgoBsyFtkMa85p6JLvqCQ/6bb/SZrBe xcA4N9YHIJZIdEDam///Ol0/8uR+MYF4xhqsurBB9OlC/AFLq9dzSqKw3hnqup4da0oj Pf92San7ahRkKQG7MnYUDHRP0DBXcbzgVNq8nr0mMp61nCIUBD9dZJryy7OQ11LHwL+u /lH61nlEutLvjDjySLSPbD7cxl9nLZwnZ96hhvXcxPSo2uWrVIhdV3eT8MP6nUQMGSYx MDOEkKwtcB+FrATd4iK8Q7eEsD6q0fIg4BSPgPrZ/CwNjTMBR0eg+A2LX5xvZASqcAg8 UplA== X-Forwarded-Encrypted: i=1; AJvYcCWWPGixuxeOWfFoZiXmEI92C0dDbDXBtim9RidpPcp5DD/QjAq88AcvUPktuttMMzAnGZD0nbxoKtMW@vger.kernel.org X-Gm-Message-State: AOJu0Yzg8PmFOPCiaVHP85u8CbVlR7tkf8Qzxe1FFe2jhitYT9zGVop8 96YwRvVF3iCYOKcZrkhwyZCasnxI0KB3qZNKFYm5FfaMN+vbdQu9ct6vNBdA9WU= X-Google-Smtp-Source: AGHT+IHZljiICRUhyxDdbtD4WYuUm0mjjSTqWVUHER2Y2hZLhu0VdV7MjcSaGSeKiI81kTq5jO6bgg== X-Received: by 2002:a05:600c:4f09:b0:431:2460:5574 with SMTP id 5b1f17b1804b1-4316168f23amr72052835e9.27.1729495373102; Mon, 21 Oct 2024 00:22:53 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f57fa35sm46098105e9.19.2024.10.21.00.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 00:22:52 -0700 (PDT) Date: Mon, 21 Oct 2024 10:22:49 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Troy Mitchell , andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, troymitchell988@gmail.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT K1 SoC Message-ID: <1e65dbe7-0269-4c96-99be-c4eb224a5a9f@stanley.mountain> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241015075134.1449458-3-TroyMitchell988@gmail.com> Hi Troy, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Troy-Mitchell/dt-bindings-i2c-spacemit-add-support-for-K1-SoC/20241015-155402 base: https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host patch link: https://lore.kernel.org/r/20241015075134.1449458-3-TroyMitchell988%40gmail.com patch subject: [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT K1 SoC config: alpha-randconfig-r071-20241019 (https://download.01.org/0day-ci/archive/20241019/202410191416.NyqQCvE3-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 13.3.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202410191416.NyqQCvE3-lkp@intel.com/ smatch warnings: drivers/i2c/busses/i2c-k1.c:621 spacemit_i2c_probe() warn: passing zero to 'PTR_ERR' drivers/i2c/busses/i2c-k1.c:622 spacemit_i2c_probe() warn: passing zero to 'dev_err_probe' vim +/PTR_ERR +621 drivers/i2c/busses/i2c-k1.c aede17b17b7dfb Troy Mitchell 2024-10-15 604 static int spacemit_i2c_probe(struct platform_device *pdev) aede17b17b7dfb Troy Mitchell 2024-10-15 605 { aede17b17b7dfb Troy Mitchell 2024-10-15 606 struct spacemit_i2c_dev *i2c; aede17b17b7dfb Troy Mitchell 2024-10-15 607 struct device_node *of_node = pdev->dev.of_node; aede17b17b7dfb Troy Mitchell 2024-10-15 608 struct clk *clk; aede17b17b7dfb Troy Mitchell 2024-10-15 609 int ret = 0; aede17b17b7dfb Troy Mitchell 2024-10-15 610 aede17b17b7dfb Troy Mitchell 2024-10-15 611 i2c = devm_kzalloc(&pdev->dev, aede17b17b7dfb Troy Mitchell 2024-10-15 612 sizeof(struct spacemit_i2c_dev), aede17b17b7dfb Troy Mitchell 2024-10-15 613 GFP_KERNEL); aede17b17b7dfb Troy Mitchell 2024-10-15 614 if (!i2c) aede17b17b7dfb Troy Mitchell 2024-10-15 615 return -ENOMEM; aede17b17b7dfb Troy Mitchell 2024-10-15 616 aede17b17b7dfb Troy Mitchell 2024-10-15 617 i2c->dev = &pdev->dev; aede17b17b7dfb Troy Mitchell 2024-10-15 618 aede17b17b7dfb Troy Mitchell 2024-10-15 619 i2c->base = devm_platform_ioremap_resource(pdev, 0); aede17b17b7dfb Troy Mitchell 2024-10-15 620 if (!i2c->base) { This should be if (IS_ERR(i2c->base)) { aede17b17b7dfb Troy Mitchell 2024-10-15 @621 ret = PTR_ERR(i2c->base); aede17b17b7dfb Troy Mitchell 2024-10-15 @622 return dev_err_probe(&pdev->dev, ret, "failed to do ioremap"); aede17b17b7dfb Troy Mitchell 2024-10-15 623 } aede17b17b7dfb Troy Mitchell 2024-10-15 624 aede17b17b7dfb Troy Mitchell 2024-10-15 625 i2c->irq = platform_get_irq(pdev, 0); aede17b17b7dfb Troy Mitchell 2024-10-15 626 if (i2c->irq < 0) { aede17b17b7dfb Troy Mitchell 2024-10-15 627 ret = i2c->irq; aede17b17b7dfb Troy Mitchell 2024-10-15 628 return dev_err_probe(&pdev->dev, ret, "failed to get irq resource"); aede17b17b7dfb Troy Mitchell 2024-10-15 629 } aede17b17b7dfb Troy Mitchell 2024-10-15 630 aede17b17b7dfb Troy Mitchell 2024-10-15 631 ret = devm_request_irq(i2c->dev, i2c->irq, aede17b17b7dfb Troy Mitchell 2024-10-15 632 spacemit_i2c_irq_handler, aede17b17b7dfb Troy Mitchell 2024-10-15 633 IRQF_NO_SUSPEND | IRQF_ONESHOT, aede17b17b7dfb Troy Mitchell 2024-10-15 634 dev_name(i2c->dev), i2c); aede17b17b7dfb Troy Mitchell 2024-10-15 635 aede17b17b7dfb Troy Mitchell 2024-10-15 636 if (ret) aede17b17b7dfb Troy Mitchell 2024-10-15 637 return dev_err_probe(&pdev->dev, ret, "failed to request irq"); -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki