From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA71EC0015E for ; Fri, 23 Jun 2023 12:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbjFWMeR (ORCPT ); Fri, 23 Jun 2023 08:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231132AbjFWMeQ (ORCPT ); Fri, 23 Jun 2023 08:34:16 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A73B272D for ; Fri, 23 Jun 2023 05:33:44 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so744964e87.2 for ; Fri, 23 Jun 2023 05:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687523620; x=1690115620; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XJBbPxfWrIuV/htAq2D57dxg7jiTMZRQ5tzvyjJ5U0I=; b=obCSInjK7X4096fRkEPea7JwwnsafzrelyXkIFyENBxm8AVq38u32KeiNjuhlLKsVV 1UheljHPXGlSq4bNOW0m5eZmOWtS54Sg3xQtMfIQx9ApUGvZOx/0DHyRqA+SXbDQFD4V YtzSVWYLXEHe8YeFETDHIR7byqi2iq74de+bjjRuUN424V8wnRb5dI6+KjiD5F/VBi+w 1yuyBVWPyGKEBjVO1VdDPh03AY8JNoVzNn1IRl+RWP0V4lB59RvBGkGdX3KB40HQBqRc PYIcosaRtg/hFlhFxjkh8qgOp4S+oA/7qQglZgcZyBAkEeETTfbHYR9VUXtdkthWp1p2 OQaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687523620; x=1690115620; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XJBbPxfWrIuV/htAq2D57dxg7jiTMZRQ5tzvyjJ5U0I=; b=OhZa5ApjNas7Kyxttky8T/emkc9XCC+kWQnb6ZhvDRUbqilHgiPNZcg1S1mZDYw+wU TKlLS8ozoOP0GLSLnC/5D00JoEdlQvGP9BCAvdkzsC+n4sW/fCwyvC8xdYB8o2MaBYZO YKrW8DRQTdHAtmPfyO3waNa4l0K8ZtcsTLiOIHnjENDZlClk7PhFuJqoXRGKTzo2iayk EgVrZTfSJybET8HB9DrSEBLNHALgyJlS8EJVN9RQQw8/2nqhuT6SZMosLieiv9itwxoA xZHL90aWDnDp6xhfuOK3My3iKiJeWP0ZIQCBnM4GvVH+KMaXpl4ggpqhZ0m8RVk8wqf6 Ehxw== X-Gm-Message-State: AC+VfDxRjCKuLqs1I7mRDgUTH2EYgP7muysHDUWE9M8Ou6qV5OQiFAXt 39QSJTxlKMP2fnZBsAqRq1aJpQ== X-Google-Smtp-Source: ACHHUZ4D6vGRZleunmyW53hwe9ptNk+Pr8vApp749tDGYCvrBNMzpoUEmxmZagf3RvI/kCp5lfPBhA== X-Received: by 2002:a19:ca08:0:b0:4f8:5792:3802 with SMTP id a8-20020a19ca08000000b004f857923802mr12828607lfg.10.1687523620328; Fri, 23 Jun 2023 05:33:40 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id p4-20020a05600c204400b003f90a604885sm2213436wmg.34.2023.06.23.05.33.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 05:33:39 -0700 (PDT) Message-ID: <1e66ae2e-d88d-7c7f-a42f-e4ba17fd254e@linaro.org> Date: Fri, 23 Jun 2023 14:33:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/5] scsi: dt-bindings: ufs: qcom: Add compatible for sm6115 and sm6125 Content-Language: en-US To: Abel Vesa , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Martin K . Petersen" , Alim Akhtar , Avri Altman , Bart Van Assche , Lux Aliaga Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List References: <20230623113009.2512206-1-abel.vesa@linaro.org> <20230623113009.2512206-3-abel.vesa@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230623113009.2512206-3-abel.vesa@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/06/2023 13:30, Abel Vesa wrote: > Add the compatible string for the UFS on sm6115 and sm6125 platforms. > > Signed-off-by: Abel Vesa > --- > .../devicetree/bindings/ufs/qcom,ufs.yaml | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index bdfa86a0cc98..46f454ec3688 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -29,6 +29,8 @@ properties: > - qcom,sa8775p-ufshc > - qcom,sc8280xp-ufshc > - qcom,sdm845-ufshc > + - qcom,sm6115-ufshc > + - qcom,sm6125-ufshc > - qcom,sm6350-ufshc > - qcom,sm8150-ufshc > - qcom,sm8250-ufshc > @@ -163,6 +165,36 @@ allOf: > minItems: 2 > maxItems: 2 > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm6115-ufshc > + - qcom,sm6125-ufshc > + then: > + properties: > + clocks: > + minItems: 8 > + maxItems: 8 > + clock-names: > + items: > + - const: core_clk > + - const: bus_aggr_clk > + - const: iface_clk > + - const: core_clk_unipro > + - const: ref_clk > + - const: tx_lane0_sync_clk > + - const: rx_lane0_sync_clk > + - const: ice_core_clk > + reg: > + minItems: 2 > + maxItems: 2 > + reg-names: > + items: > + - const: std > + - const: ice Same comment about reg-names as for your further patch. I guess this will supersed the https://lore.kernel.org/all/20221215190404.398788-1-they@mint.lgbt/ (because it was abandoned... I keep rebasing this patch for half a year) Best regards, Krzysztof