public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Frank Wang <frank.wang@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, charles.chen@rock-chips.com,
	cody.xie@rock-chips.com, kevan.lan@rock-chips.com,
	huangtao@rock-chips.com, sugar.zhang@rock-chips.com,
	wmc@rock-chips.com
Subject: Re: [PATCH 1/3] arm: dts: rk322x: fix i2s1 pinctrl error
Date: Wed, 17 May 2017 17:21:01 +0800	[thread overview]
Message-ID: <1e922ff2-d1ce-5bff-e172-3b2ddf713d9e@rock-chips.com> (raw)
In-Reply-To: <2781249.GNsgFIKA50@diego>

Hi Heiko,

On 2017/5/17 17:01, Heiko Stübner wrote:
> Hi Frank,
>
> Am Mittwoch, 17. Mai 2017, 11:40:49 CEST schrieb Frank Wang:
>> From: Sugar Zhang <sugar.zhang@rock-chips.com>
>>
>> Refer to Chapter 5.3.2 of rk3229 TRM, we can see that GPIO1A[2,4,5]
>> using RK_FUNC_2 not RK_FUNC_1. This patch fixes it.
>>
>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> if the patch has another author, you should preserve his/her Signed-off-by
> line, so for example this patch would look like:
>
> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>
> Same for all other patches with differing authors in your 2 series from
> today. As this touches the developer-certificate-of-origin, this is also
> something I cannot really correct myself.

Noted and thanks for reminding, I will resend these 2 series.

BR.
Frank

>
> Heiko
>
>
>> ---
>>   arch/arm/boot/dts/rk322x.dtsi | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
>> index 48a0c1c..cc6a27d 100644
>> --- a/arch/arm/boot/dts/rk322x.dtsi
>> +++ b/arch/arm/boot/dts/rk322x.dtsi
>> @@ -621,9 +621,9 @@
>>   						<0 12 RK_FUNC_1 &pcfg_pull_none>,
>>   						<0 13 RK_FUNC_1 &pcfg_pull_none>,
>>   						<0 14 RK_FUNC_1 &pcfg_pull_none>,
>> -						<1 2 RK_FUNC_1 &pcfg_pull_none>,
>> -						<1 4 RK_FUNC_1 &pcfg_pull_none>,
>> -						<1 5 RK_FUNC_1 &pcfg_pull_none>;
>> +						<1 2 RK_FUNC_2 &pcfg_pull_none>,
>> +						<1 4 RK_FUNC_2 &pcfg_pull_none>,
>> +						<1 5 RK_FUNC_2 &pcfg_pull_none>;
>>   			};
>>   		};
>
>
>
>

  reply	other threads:[~2017-05-17  9:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17  3:40 [PATCH 0/3] add and fix some device node for rk322x SoC Frank Wang
2017-05-17  3:40 ` [PATCH 1/3] arm: dts: rk322x: fix i2s1 pinctrl error Frank Wang
     [not found]   ` <1494992451-32542-2-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-05-17  9:01     ` Heiko Stübner
2017-05-17  9:21       ` Frank Wang [this message]
     [not found] ` <1494992451-32542-1-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-05-17  3:40   ` [PATCH 2/3] arm: dts: rk322x: correct uart2 pinctrl and add another sets Frank Wang
2017-05-17  6:31     ` Kever Yang
     [not found]       ` <3974d438-89ca-04e2-03cd-6d3946dd461e-9Onoh4P/yGk@public.gmane.org>
2017-05-17  7:35         ` Frank Wang
2017-05-17  3:40 ` [PATCH 3/3] arm: dts: rk322x: add watchdog device node Frank Wang
     [not found]   ` <1494992451-32542-4-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-05-18  3:18     ` kbuild test robot
2017-05-18  3:58       ` Frank Wang
2017-05-18  7:18         ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e922ff2-d1ce-5bff-e172-3b2ddf713d9e@rock-chips.com \
    --to=frank.wang@rock-chips.com \
    --cc=charles.chen@rock-chips.com \
    --cc=cody.xie@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=kevan.lan@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sugar.zhang@rock-chips.com \
    --cc=wmc@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox