From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6931C433FE for ; Tue, 19 Apr 2022 06:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348951AbiDSGop (ORCPT ); Tue, 19 Apr 2022 02:44:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239127AbiDSGoo (ORCPT ); Tue, 19 Apr 2022 02:44:44 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AD0F2C128 for ; Mon, 18 Apr 2022 23:42:00 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id t25so19976595edt.9 for ; Mon, 18 Apr 2022 23:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=crADoU7TuQHIvNUCkN3bftpXZTQCbbgAEyPuKyFnosA=; b=kAxwmtbFjL2vIdyOc0SJTzQ1jRxFAwAUqZgQ5ZkF1NnHm/Blxgwz0k4NqRpDIYYQ78 xhSPQgOzkY9gQf99yy3p41mmtlzDPDmiYI52EsDiF+zGA+55HjVgUpusGGDgep56zcNq bUtdQi87v1F95EInqQD+8T4uTWUmj2yzlZu6IWdrpAQCptuo+9OTisBgR0v3WQy/VraS RrxbA/RZxjNO1u8ZrFuYuENtRVtEjLz3ninsRhxtlVNMfTB7+tnBfzxAUWAJvTHO+k7a QPNNa95lLWCrzTe18SxlB0kCZGLXQ4g87upZCMEyWRVcJr0ZmDYEoSVnsq9HjMb7VAZN ZxpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=crADoU7TuQHIvNUCkN3bftpXZTQCbbgAEyPuKyFnosA=; b=N2soXVmyxTU4vs5iWYsT4z3IPKTJxjeVERnxhlc78QnL2IuQLUZ09uOr4TKn0fvL8B +P1BwjoK1WMFdJg/uhGyPSPKUKOJft51OIPrmFUvXa3SUsiPF8gkdsIbg2cqW+WHkAbZ Z7/0Htbze8q0UjZVJCMULHzqBbOUrw9w8HjFNXj7SPcqbO5wAzxgq5uE0EVqS4geXdnE DlgflMj5MNDe2GZsIRiYGkTzhxWsJeEYGnxb/RhIasZuAGP9gzdwScJFr3XC97W1l9AN /kyw55wy7gB0TE01fTCvFScodVp35BSHypH4z58u/JwI/Do/ZOTSfTLN6BBhABxSkp0D mjGA== X-Gm-Message-State: AOAM531Uz4RqVQdmynQMN2aRx+OKvWmoqdTxlvD81QW4BRIPYRCKVFCZ OysXAOqqtqcnPagzGDdCJbWJaA== X-Google-Smtp-Source: ABdhPJwzHBRz4mz5yTbCzi/y8+W/yiUPkQ8vl23P9aHgnApQ8eiW8ymYJ0xHpdkdGZF7fZE8OTCANQ== X-Received: by 2002:a05:6402:909:b0:415:cdbf:4748 with SMTP id g9-20020a056402090900b00415cdbf4748mr15663935edz.395.1650350518753; Mon, 18 Apr 2022 23:41:58 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q14-20020a17090622ce00b006e898c912e5sm5303190eja.217.2022.04.18.23.41.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Apr 2022 23:41:58 -0700 (PDT) Message-ID: <1e9bf9d6-cd5a-6a47-f0d7-5a4bc6e6d2f0@linaro.org> Date: Tue, 19 Apr 2022 08:41:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/5] dt-bindings: rtc: Rework compatible strings and add #clock-cells Content-Language: en-US To: Paul Cercueil , Alessandro Zummo , Alexandre Belloni Cc: list@opendingux.net, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Rob Herring , Krzysztof Kozlowski References: <20220418184933.13172-1-paul@crapouillou.net> <20220418184933.13172-2-paul@crapouillou.net> From: Krzysztof Kozlowski In-Reply-To: <20220418184933.13172-2-paul@crapouillou.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/04/2022 20:49, Paul Cercueil wrote: > The RTC in the JZ4770 is compatible with the JZ4760, but has an extra > register that permits to configure the behaviour of the CLK32K pin. The > same goes for the RTC in the JZ4780. > > Therefore, the ingenic,jz4770-rtc and ingenic,jz4780-rtc strings do not > fall back anymore to ingenic,jz4760-rtc. The ingenic,jz4780-rtc string > now falls back to the ingenic,jz4770-rtc string. > > Additionally, since the RTCs in the JZ4770 and JZ4780 support outputting > the input oscillator's clock to the CLK32K pin, the RTC node is now also > a clock provider on these SoCs, so a #clock-cells property is added. > > Signed-off-by: Paul Cercueil > Cc: Rob Herring > Cc: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml b/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml > index b235b2441997..57393c3ac724 100644 > --- a/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml > @@ -18,14 +18,14 @@ properties: > - enum: > - ingenic,jz4740-rtc > - ingenic,jz4760-rtc > + - ingenic,jz4770-rtc > - items: > - const: ingenic,jz4725b-rtc > - const: ingenic,jz4740-rtc > - items: > - enum: > - - ingenic,jz4770-rtc > - ingenic,jz4780-rtc > - - const: ingenic,jz4760-rtc > + - const: ingenic,jz4770-rtc > > reg: > maxItems: 1 > @@ -39,6 +39,9 @@ properties: > clock-names: > const: rtc > > + "#clock-cells": > + const: 0 > + > system-power-controller: > description: | > Indicates that the RTC is responsible for powering OFF Inside allOf:if:then:, please add a constraint which compatible cannot have clock-cells (or maybe better which can?). Some modification of: https://elixir.bootlin.com/linux/v5.17-rc2/source/Documentation/devicetree/bindings/media/renesas,vsp1.yaml#L53 Best regards, Krzysztof