From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C02C001B0 for ; Wed, 5 Jul 2023 03:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbjGEDkt (ORCPT ); Tue, 4 Jul 2023 23:40:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjGEDks (ORCPT ); Tue, 4 Jul 2023 23:40:48 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B4C51A2; Tue, 4 Jul 2023 20:40:46 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 080E824E01A; Wed, 5 Jul 2023 11:40:45 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 11:40:45 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 11:40:44 +0800 Message-ID: <1e9dedc6-dee3-b65d-2823-0468fcb13193@starfivetech.com> Date: Wed, 5 Jul 2023 11:40:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RESEND v1 2/2] riscv: dts: starfive: Add spi node for JH7110 SoC Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Linus Walleij References: <20230704092200.85401-1-william.qiu@starfivetech.com> <20230704092200.85401-3-william.qiu@starfivetech.com> <7f3b600d-d315-22d6-b987-eabfe1b04fdf@linaro.org> From: William Qiu In-Reply-To: <7f3b600d-d315-22d6-b987-eabfe1b04fdf@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/7/4 17:39, Krzysztof Kozlowski wrote: > On 04/07/2023 11:22, William Qiu wrote: >> Add spi node for JH7110 SoC. >> >> Co-developed-by: Xingyu Wu > > Missing SoB. > It looks like that drop it is the best solution. >> Signed-off-by: William Qiu >> --- >> .../jh7110-starfive-visionfive-2.dtsi | 52 ++++++++++ >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 98 +++++++++++++++++++ >> 2 files changed, 150 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> index 2a6d81609284..a066d2e399c4 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> @@ -126,6 +126,20 @@ &i2c6 { >> status = "okay"; >> }; >> >> +&spi0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&spi0_pins>; >> + status = "okay"; >> + >> + spi_dev0: spi@0 { >> + compatible = "st,m25p80"; >> + pl022,com-mode = <1>; >> + spi-max-frequency = <10000000>; >> + reg = <0>; > > reg is always following compatible, not somewhere deep in properties. > Will update. >> + status = "okay"; > > okay is by default > Will drop. >> + }; >> +}; > > > Best regards, > Krzysztof > Thanks for taking time to review this patch series.