Re: [PATCH 1/2] rtc: Add driver for Sunplus SP7021

[Randy Dunlap <rdunlap@infradead.org>]

Hi--

On 11/1/21 11:22 PM, Vincent Shih wrote:
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index e1bc521..0c205d2 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1028,6 +1028,16 @@ config RTC_DRV_DS1685_FAMILY
>   	  This driver can also be built as a module. If so, the module
>   	  will be called rtc-ds1685.
>   
> +config RTC_DRV_SUNPLUS
> +	bool "Sunplus SP7021 RTC"
> +	depends on SOC_SP7021
> +	help
> +		Say 'yse' to get support for Sunplus SP7021 real-time clock

		     yes

> +		(RTC) for industrial applications.
> +		It provides RTC status check, timer/alarm functionalities,
> +		user data reservation only with battery with voltage over 2.5V,
> +		RTC power status check and battery charge.


Also please follow coding-style for Kconfig files:

(from Documentation/process/coding-style.rst, section 10):

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


thanks.
-- 
~Randy