From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Slawomir Stepien <slawomir.stepien@nokia.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Slawomir Stepien <sst@poczta.fm>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Alan Tull <atull@kernel.org>
Subject: Re: [PATCH 1/1] of: overlay: of_overlay_apply() kfree() errors
Date: Fri, 8 Apr 2022 12:40:56 -0500 [thread overview]
Message-ID: <1ed7ea01-b515-7c0b-4b3e-547d19717deb@gmail.com> (raw)
In-Reply-To: <CAL_JsqJC6pKxEmwMeirVLwJEbOH0WD+01VEfFXC257a+ZDRtsw@mail.gmail.com>
On 4/8/22 12:34, Rob Herring wrote:
> On Fri, Apr 8, 2022 at 12:21 PM <frowand.list@gmail.com> wrote:
>>
>> From: Frank Rowand <frank.rowand@sony.com>
>
> The subject needs a verb.
>
>>
>> Fix various kfree() issues related to of_overlay_apply().
>> - Double kfree() of fdt and tree when init_overlay_changeset()
>> returns an error.
>> - free_overlay_changeset() free of the root of the unflattened
>> overlay (variable tree) instead of the memory that contains
>> the unflattened overlay.
>> - Move similar kfree()s from multiple error locations to a
>> common error path (err_free_tree_unlocked:).
>
> What about my question/suggestion on the original patch from Slawomir?
>
I lost track of your email while investigating the problem. I'll go
back and look at your suggestion and question.
-Frank
next prev parent reply other threads:[~2022-04-08 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 17:21 [PATCH 1/1] of: overlay: of_overlay_apply() kfree() errors frowand.list
2022-04-08 17:34 ` Rob Herring
2022-04-08 17:40 ` Frank Rowand [this message]
2022-04-10 20:32 ` Frank Rowand
2022-04-09 6:52 ` Slawomir Stepien
2022-04-10 20:22 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ed7ea01-b515-7c0b-4b3e-547d19717deb@gmail.com \
--to=frowand.list@gmail.com \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=slawomir.stepien@nokia.com \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).