From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E816C433F5 for ; Fri, 8 Apr 2022 17:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237139AbiDHRnE (ORCPT ); Fri, 8 Apr 2022 13:43:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238372AbiDHRnC (ORCPT ); Fri, 8 Apr 2022 13:43:02 -0400 Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7941690FC3; Fri, 8 Apr 2022 10:40:58 -0700 (PDT) Received: by mail-qk1-x72b.google.com with SMTP id b19so5390228qkk.12; Fri, 08 Apr 2022 10:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=aEGMMSoqzQV29Yb3vuyxXwWYzXUyMcWqjEt/8PwjhP4=; b=f5+kjuwksQh4ROVlTCgr6Bmrfuh7tv7d2sKBntQaNA9RkEEG/8YHNYJS8Lm3GaAKLY 6wiVB3nqxEc8RbW6j+ID+7Yg3t/yvgZSEZ4R3D8Bt7rlKw6khDqNF62CGtWSYv3EsoZ5 3JTkkN1Nil0CUHRORoOWuBcWsowiQTlEiM18fOEOvijFXgSVbAnQVgny63DENrr8gyic LZhYITb1UhHZsijwT+h8De5Ur9GSKjlTeynpZdblz186EU5fDuv+IHnfXHyTrtg0m9Rt NhgW4DzGPdP5EEStA/ZyOVWilT+cYDIGy96rU4Yq7PY4AJ72cI9ZwohsK4kgn6s4wkVs GKNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=aEGMMSoqzQV29Yb3vuyxXwWYzXUyMcWqjEt/8PwjhP4=; b=vU2s3vgiveMFdxRRoajOMel5tmtox9AjEi0prK+pL38f6DcTWlRxXj5fp1zQ8iOSec B0i2IOadn/r1Eg+DvxRz/Tl6FY8NUuC6BL8fwbQaUr/ssl6Pll4L3ECX9zKVATS/cb5n La7nxEPBxPJ3CNkTr2kR4Qv0KIA9cY5NE1Cwzo176Yot3xDGzZ+aEnSzOFrSfyJrvTDh jANlpV9IaTjQDWgGvpm7lxn8Xd6OFrgfcseIZCGlIC1wF1Mm4TZUVgMm/wf8zBnru1EW 1TTJqFGaYZa0jGs7Uq5sCrXrYekBJZav2aBwFSyC3KOqxpGwSSNbQTd/iMOsZkDk+6cY r+KQ== X-Gm-Message-State: AOAM530+PWfllESFvAz7ne7JrOw8l3b4y+muR0UVaMmDwykxLLaQWrGF iuoGYUS/xJMhT7LGm1PJDqu8a9vAbDY= X-Google-Smtp-Source: ABdhPJyGWb1/E9mWepAzuuHv95UgS5bl6t4bSWTiiNmVXIifF60fF07UXLQHxTRzwcOEoHEyfASS3Q== X-Received: by 2002:a37:554:0:b0:69b:ef36:cd6f with SMTP id 81-20020a370554000000b0069bef36cd6fmr1454823qkf.129.1649439657667; Fri, 08 Apr 2022 10:40:57 -0700 (PDT) Received: from ?IPV6:2600:1700:2442:6db0:6d2d:3351:3e49:3378? ([2600:1700:2442:6db0:6d2d:3351:3e49:3378]) by smtp.gmail.com with ESMTPSA id h186-20020a376cc3000000b00699c789a757sm9336207qkc.132.2022.04.08.10.40.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 10:40:57 -0700 (PDT) Message-ID: <1ed7ea01-b515-7c0b-4b3e-547d19717deb@gmail.com> Date: Fri, 8 Apr 2022 12:40:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/1] of: overlay: of_overlay_apply() kfree() errors Content-Language: en-US To: Rob Herring Cc: Pantelis Antoniou , Slawomir Stepien , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Slawomir Stepien , Geert Uytterhoeven , Alan Tull References: <20220408172103.371637-1-frowand.list@gmail.com> From: Frank Rowand In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/8/22 12:34, Rob Herring wrote: > On Fri, Apr 8, 2022 at 12:21 PM wrote: >> >> From: Frank Rowand > > The subject needs a verb. > >> >> Fix various kfree() issues related to of_overlay_apply(). >> - Double kfree() of fdt and tree when init_overlay_changeset() >> returns an error. >> - free_overlay_changeset() free of the root of the unflattened >> overlay (variable tree) instead of the memory that contains >> the unflattened overlay. >> - Move similar kfree()s from multiple error locations to a >> common error path (err_free_tree_unlocked:). > > What about my question/suggestion on the original patch from Slawomir? > I lost track of your email while investigating the problem. I'll go back and look at your suggestion and question. -Frank