devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com>,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	richardcochran@gmail.com, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	yangbo.lu@nxp.com, radhey.shyam.pandey@amd.com,
	anirudha.sarangi@amd.com, harini.katakam@amd.com, git@amd.com
Subject: Re: [PATCH net-next V3] dt-bindings: net: ethernet-controller: Add ptp-hardware-clock
Date: Tue, 14 Mar 2023 16:45:06 +0100	[thread overview]
Message-ID: <1ee7386b-f42d-a182-f42d-c1f628fb4dda@linaro.org> (raw)
In-Reply-To: <20230313153532.2ed45ddf@kernel.org>

On 13/03/2023 23:35, Jakub Kicinski wrote:
> On Wed, 8 Mar 2023 11:14:08 +0530 Sarath Babu Naidu Gaddam wrote:
>> There is currently no standard property to pass PTP device index
>> information to ethernet driver when they are independent.
>>
>> ptp-hardware-clock property will contain phandle to PTP clock node.
>>
>> Its a generic (optional) property name to link to PTP phandle to
>> Ethernet node. Any future or current ethernet drivers that need
>> a reference to the PHC used on their system can simply use this
>> generic property name instead of using custom property
>> implementation in their device tree nodes."
>>
>> Signed-off-by: Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com>
>> Acked-by: Richard Cochran <richardcochran@gmail.com>
> 
> Rob, Krzysztof, any thoughts on this one?
> Looks like the v2 discussion was a bit inconclusive.

Anyway this did not implement changes I requested, so NAK.

Best regards,
Krzysztof


  reply	other threads:[~2023-03-14 15:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08  5:44 [PATCH net-next V3] dt-bindings: net: ethernet-controller: Add ptp-hardware-clock Sarath Babu Naidu Gaddam
2023-03-08  5:44 ` Sarath Babu Naidu Gaddam
2023-03-13 22:35   ` Jakub Kicinski
2023-03-14 15:45     ` Krzysztof Kozlowski [this message]
2023-03-14 15:46   ` Krzysztof Kozlowski
2023-03-16 10:53     ` Gaddam, Sarath Babu Naidu
2023-03-16 11:35       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ee7386b-f42d-a182-f42d-c1f628fb4dda@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=anirudha.sarangi@amd.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=git@amd.com \
    --cc=harini.katakam@amd.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sarath.babu.naidu.gaddam@amd.com \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).