From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A3CECAAA1 for ; Tue, 30 Aug 2022 19:03:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbiH3TDZ (ORCPT ); Tue, 30 Aug 2022 15:03:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbiH3TDY (ORCPT ); Tue, 30 Aug 2022 15:03:24 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AC785F22A for ; Tue, 30 Aug 2022 12:03:22 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id x10so12368657ljq.4 for ; Tue, 30 Aug 2022 12:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=gXK/wYTrdjw1OFwGZvQGSVF4ZM2/PXgjnzR2P4z9JVU=; b=RfyVD3awpAa0llxye9rwb8D/ncwSK7kal8kbOTuM8IbDZFVDp3nkj1DLplToMDLPH9 29f5OmifJuPUSCaaEHSautt/YWR1ko394Ac4+Ke0yY9H8LAKIKnGvXOra5p9wX83TobH NC+3MQoXk+6m+I67DPYLhh4r3IBHjXl796aNlSoHAxzoi9U7xscBQorR3pulfB4bkwLV zaVyrK2txt0sbDMiOJ57bjrByubi+NWvB97jNTBLHnzP57aUdknZ7o2zUn9M2GeojJqg VsxHRqHM4b3XJrCDpFHi8Qkqhh+fuabfsP4hykouZxs3r5PGUipSMx8rhjE+Q44E0Cww WJOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=gXK/wYTrdjw1OFwGZvQGSVF4ZM2/PXgjnzR2P4z9JVU=; b=yjss16hsYuW+rSBmKihbdIcxwb+Dh0XxNoyMytU4unnovy829GE6uZqm9CDexkjRQq Ocx0qF5jOdHI9GLKQV9oAQmcHIRbgGhAikEntF3gKqZ//bxHv05C74lu2kbM4jXz5pZ4 xnJ7FQTNWlclQJGMTU9l2hzspD2wg9Sc5c0LYQyIMlxn+BP8zOCyxihqfHX52CmTFT9C 7JtdKzF/upfJ8+p2FzetXVucx+IUvE2rIrr16PyQxNEwUfIWi8j15D4qpORlmmtfPFRA Q4zW/2IrR7OhQsJJ2WbDHQD8XZOQI+SFuQVtuT8j2U0IKz4v6hh/UZALjMQR5c3DrUhM 9QHQ== X-Gm-Message-State: ACgBeo2hKNHox2/zsyoTpFN5itkeNk0JdZO6iClDXCgsOBIAlKu+ZXoE 1JfsAd0EmIrgCmMYpt31uyUBOA== X-Google-Smtp-Source: AA6agR7XX821cAlmC8c6TzfFWW/lCcMRA71i63MiH9w6y67HfOTP74/INxmWqpqcMogEbXBBQEmDJQ== X-Received: by 2002:a2e:b0f9:0:b0:266:d31e:3061 with SMTP id h25-20020a2eb0f9000000b00266d31e3061mr2075012ljl.391.1661886200513; Tue, 30 Aug 2022 12:03:20 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id z9-20020a056512308900b00492f21c161esm1691923lfd.123.2022.08.30.12.03.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 12:03:19 -0700 (PDT) Message-ID: <1ef5dbd4-806f-ac1d-0ad5-0f8359a560de@linaro.org> Date: Tue, 30 Aug 2022 22:03:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3 1/3] dt-bindings: can: nxp,sja1000: Document RZ/N1 power-domains support Content-Language: en-US To: Biju Das , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski Cc: "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad , "linux-renesas-soc@vger.kernel.org" References: <20220830164518.1381632-1-biju.das.jz@bp.renesas.com> <20220830164518.1381632-2-biju.das.jz@bp.renesas.com> <23539312-caaa-78f0-cd6c-899a826f9947@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/08/2022 20:47, Biju Das wrote: > Hi Krzysztof Kozlowski, > > Thanks for the feedback. > >> Subject: Re: [PATCH v3 1/3] dt-bindings: can: nxp,sja1000: Document >> RZ/N1 power-domains support >> >> On 30/08/2022 19:45, Biju Das wrote: >>> Document RZ/N1 power-domains support. Also update the example with >>> power-domains property. >>> >>> Signed-off-by: Biju Das >>> --- >>> v3: >>> * Documented power-domains support. >> >> You made them required, so it would be nice to see reason in such >> change. The commit msg says only what you did, but not why you did it. > > It is simple. As you see from [1] and [2] power-domains are enabled by default in RZ/N1 SoC. > So there is nothing prevent us to document this property for all IP's present in > RZ/N1 SoC. Any explanation I expect to see in commit msg. Anyway you referred to Linux drivers, which is not actually a reason. What if some device is not in a power domain? Best regards, Krzysztof