From: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
kernel@savoirfairelinux.com,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Mark Featherston <mark@embeddedarm.com>,
kris@embeddedarm.com
Subject: Re: [PATCH v8 2/2] ARM: dts: TS-4600: add basic device tree
Date: Thu, 7 Dec 2017 12:06:11 -0500 [thread overview]
Message-ID: <1f11151e-fa71-5af6-245d-482fcbcec5e9@savoirfairelinux.com> (raw)
In-Reply-To: <CAOMZO5DcM0u9+DZjywsqadu834++rXAckqnkMqzZOo-vgFVs_w@mail.gmail.com>
Hi Fabio
On 11/26/2017 02:39 PM, Fabio Estevam wrote:
> Hi Sebastien,
>
> On Thu, Nov 23, 2017 at 7:04 PM, Sebastien Bourdelin
> <sebastien.bourdelin@savoirfairelinux.com> wrote:
>
>> + reg_vddio_sd0: regulator-vddio-sd0 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vddio-sd0";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> + gpio = <&gpio3 28 GPIO_ACTIVE_HIGH>;
>
> It seems this should be GPIO_ACTIVE_LOW instead, as you don't pass
> 'enable-active-high' here.
>
Yes! you are right, thanks for the catch!
Regards,
Sebastien.
prev parent reply other threads:[~2017-12-07 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 21:04 [PATCH v8 1/2] of: documentation: add bindings documentation for TS-4600 Sebastien Bourdelin
2017-11-23 21:04 ` [PATCH v8 2/2] ARM: dts: TS-4600: add basic device tree Sebastien Bourdelin
[not found] ` <20171123210410.7107-2-sebastien.bourdelin-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2017-11-26 19:39 ` Fabio Estevam
2017-12-07 17:06 ` Sebastien Bourdelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f11151e-fa71-5af6-245d-482fcbcec5e9@savoirfairelinux.com \
--to=sebastien.bourdelin@savoirfairelinux.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@savoirfairelinux.com \
--cc=kris@embeddedarm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mark@embeddedarm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox