From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: quic_huliu@quicinc.com, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs.
Date: Fri, 12 Jan 2024 08:44:40 +0100 [thread overview]
Message-ID: <1f14bff5-4f3e-426b-b81d-006da061af1e@linaro.org> (raw)
In-Reply-To: <20240112-lpg-v4-1-c4004026686b@quicinc.com>
On 12/01/2024 04:05, Hui Liu via B4 Relay wrote:
> From: Hui Liu <quic_huliu@quicinc.com>
>
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
>
> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
> ---
> Changes in v4:
> - Removed "label" definition and added "function" definition.
You did not test your patch before sending.
Subject is still wrong. Also, it still has unnecessary full stop. Drop it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-12 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 3:05 [PATCH v4] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs Hui Liu via B4 Relay
2024-01-12 3:36 ` Dmitry Baryshkov
2024-01-15 5:52 ` hui liu
2024-01-15 9:53 ` Dmitry Baryshkov
2024-01-12 7:44 ` Krzysztof Kozlowski [this message]
2024-01-15 5:54 ` hui liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f14bff5-4f3e-426b-b81d-006da061af1e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_huliu@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox