From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B588C433DF for ; Fri, 19 Jun 2020 22:10:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31A9022265 for ; Fri, 19 Jun 2020 22:10:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N4UFXog3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729005AbgFSWKJ (ORCPT ); Fri, 19 Jun 2020 18:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728906AbgFSWKI (ORCPT ); Fri, 19 Jun 2020 18:10:08 -0400 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66AEDC06174E; Fri, 19 Jun 2020 15:10:08 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id p20so11746286ejd.13; Fri, 19 Jun 2020 15:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=U9kuTO2iPn0ptZqewG7UxF5Sm1BcoMAYjmIFd+9dDpE=; b=N4UFXog3hNaZNw71eWcAdiWUH9c+CT/LnRwj2Zpv/+3vf0wf3iBL3jRYQOhiYTgtzN +V+XbdeOyGVWXzFNHJ70n8PC6/yORz1FjDi0Wk4JznMRPYn9Zj7kmCmp2059GP5EBdk4 1ZZmwW+8XbQjYN8oyM/k1iWMiZB1UfJwP5pkFJ4oZQ5R4PwfLH9Bxf1DwfjgB5Dinw7t vISoqRccR2KZwnbZnHnen4haPanIHeCX9hPjtLBxRdMB/sadNoTLH8X2D5g8CpteF0zj hlTZEeoTt1Eh5VV5N48N3HNy00XR6SKMF2DBjM4h/HHtVxxA0qNyl3uknppvxkw5CGjL 0A1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U9kuTO2iPn0ptZqewG7UxF5Sm1BcoMAYjmIFd+9dDpE=; b=Hf7ycqOex9vWjQ562qpiDi5qyXENnWw8/qgVal512/NFlH1XHbi7L7jA2Bwc8JDyjt MiWd3dc1WU1j5ACfuHO6bbaRFxhFNeKXX2URj0tyaZHEvHZrfePYN0XpPV2eO6crZQUV er0APpFvDHzevyKl4Sj2RyHvNQTQOdBYC05YhZwJFnw3z8gmJX1pjtuE2o9XAg1kOXie mKZPXrRC9mzYZNQ0tyhf30fMJsxZtOC+oCwUszy4Y8Dv9WxmuCba223w5Q+dDx3fbWyL /WrqdudfBGXcncJMVVU1XIiIijpAmaVaxG6pDrqzNvRk9R3amcGfM7PXe7G/fkPXdqZP fmwQ== X-Gm-Message-State: AOAM530pj11frtNanM3326P1NzEUKQcHwdYhtSLdaeau5tdVhmSBKuIh ZczFOaeMybCa/7Pgc5QHG6XJGJXf X-Google-Smtp-Source: ABdhPJxp7XR9gdmWkCR8RfqyT/37oQUAuibX+I95xkrKcKR8QCpP3fg/esHudEPKDeINSzkQOuOZkA== X-Received: by 2002:a17:906:7043:: with SMTP id r3mr5535688ejj.270.1592604606732; Fri, 19 Jun 2020 15:10:06 -0700 (PDT) Received: from ?IPv6:2a01:110f:b59:fd00:98c8:c0f7:fd90:a9ec? ([2a01:110f:b59:fd00:98c8:c0f7:fd90:a9ec]) by smtp.gmail.com with ESMTPSA id c4sm5649983ejb.17.2020.06.19.15.10.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2020 15:10:06 -0700 (PDT) Subject: Re: [RESEND PATCH v27 11/15] leds: lp55xx: Add multicolor framework support to lp55xx To: Dan Murphy , pavel@ucw.cz, robh@kernel.org Cc: kbuild-all@lists.01.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200615201522.19677-12-dmurphy@ti.com> <202006180032.JW0i39C6%lkp@intel.com> <0a8a6f57-678d-b1b9-41e5-5e58c15cfe6b@ti.com> <58ad7723-131f-6930-00d7-1144c993110c@gmail.com> <56823113-4875-4813-8627-84b0d1792391@ti.com> <04473d1d-5cd8-7d1f-7c5d-8d8b582df464@ti.com> From: Jacek Anaszewski Message-ID: <1f5dd2f9-01c7-1f74-9b93-0ae2a6dac915@gmail.com> Date: Sat, 20 Jun 2020 00:10:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <04473d1d-5cd8-7d1f-7c5d-8d8b582df464@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Dan, On 6/19/20 6:35 PM, Dan Murphy wrote: > Jacek > > On 6/18/20 6:26 PM, Jacek Anaszewski wrote: >> On 6/19/20 12:09 AM, Jacek Anaszewski wrote: >>> Dan, >>> >>> On 6/18/20 11:44 PM, Dan Murphy wrote: >>>> Jacek >>>> >>>> On 6/18/20 4:21 PM, Jacek Anaszewski wrote: >>>>> Dan, >>>>> >>>>> On 6/18/20 12:33 AM, Dan Murphy wrote: >>>>>> Jacek >>>>>> >>>>>> On 6/17/20 4:41 PM, Jacek Anaszewski wrote: >>>>>>> Dan, >>>>>>> >>>>>>> On 6/17/20 9:22 PM, Dan Murphy wrote: >>>>>>>> Pavel/Jacek >>>>>>>> >>>>>>>> On 6/17/20 11:28 AM, kernel test robot wrote: >>>>>>>>> Hi Dan, >>>>>>>>> >>>>>>>>> I love your patch! Yet something to improve: >>>>>>>>> >>>>>>>>> [auto build test ERROR on pavel-linux-leds/for-next] >>>>>>>>> [cannot apply to j.anaszewski-leds/for-next] >>>>>>>>> [if your patch is applied to the wrong git tree, please drop us >>>>>>>>> a note to help >>>>>>>>> improve the system. BTW, we also suggest to use '--base' option >>>>>>>>> to specify the >>>>>>>>> base tree in git format-patch, please see >>>>>>>>> https://stackoverflow.com/a/37406982] >>>>>>>>> >>>>>>>>> url: >>>>>>>>> https://github.com/0day-ci/linux/commits/Dan-Murphy/Multicolor-Framework-v27/20200616-042217 >>>>>>>>> >>>>>>>>> base: >>>>>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git >>>>>>>>> for-next >>>>>>>>> config: ia64-randconfig-r015-20200617 (attached as .config) >>>>>>>>> compiler: ia64-linux-gcc (GCC) 9.3.0 >>>>>>>>> reproduce (this is a W=1 build): >>>>>>>>>          wget >>>>>>>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >>>>>>>>> -O ~/bin/make.cross >>>>>>>>>          chmod +x ~/bin/make.cross >>>>>>>>>          # save the attached .config to linux build tree >>>>>>>>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 >>>>>>>>> make.cross ARCH=ia64 >>>>>>>>> >>>>>>>>> If you fix the issue, kindly add following tag as appropriate >>>>>>>>> Reported-by: kernel test robot >>>>>>>>> >>>>>>>>> All errors (new ones prefixed by >>, old ones prefixed by <<): >>>>>>>>> >>>>>>>>> ia64-linux-ld: drivers/leds/leds-lp55xx-common.o: in function >>>>>>>>> `lp55xx_set_mc_brightness': >>>>>>>>>>> drivers/leds/leds-lp55xx-common.c:146: undefined reference to >>>>>>>>>>> `led_mc_calc_color_components' >>>>>>>>> ia64-linux-ld: drivers/leds/leds-lp55xx-common.o: in function >>>>>>>>> `devm_led_classdev_multicolor_register': >>>>>>>>>>> include/linux/led-class-multicolor.h:74: undefined reference >>>>>>>>>>> to `devm_led_classdev_multicolor_register_ext' >>>>>>>>> vim +146 drivers/leds/leds-lp55xx-common.c >>>>>>>>> >>>>>>>>>     138 >>>>>>>>>     139    static int lp55xx_set_mc_brightness(struct >>>>>>>>> led_classdev *cdev, >>>>>>>>>     140                        enum led_brightness brightness) >>>>>>>>>     141    { >>>>>>>>>     142        struct led_classdev_mc *mc_dev = >>>>>>>>> lcdev_to_mccdev(cdev); >>>>>>>>>     143        struct lp55xx_led *led = mcled_cdev_to_led(mc_dev); >>>>>>>>>     144        struct lp55xx_device_config *cfg = led->chip->cfg; >>>>>>>>>     145 >>>>>>>>>   > 146 led_mc_calc_color_components(&led->mc_cdev, brightness); >>>>>>>>>     147        return cfg->multicolor_brightness_fn(led); >>>>>>>>>     148 >>>>>>>> >>>>>>>> Well this was a mess to figure out. >>>>>>>> >>>>>>>> The only fix I can figure out here is to remove the >>>>>>>> >>>>>>>>      depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR >>>>>>>> >>>>>>>> from each child device and add >>>>>>>> >>>>>>>>      select LEDS_CLASS_MULTI_COLOR >>>>>>>> >>>>>>>> to the LP55XX_COMMON >>>>>>>> >>>>>>>> This way the Multi color framework will inherit the symbol that >>>>>>>> was set by the COMMON flag which is inherited by majority from >>>>>>>> the child flags. >>>>>>> >>>>>>> Did you try this? >>>>>>> >>>>>>> --- a/drivers/leds/Kconfig >>>>>>> +++ b/drivers/leds/Kconfig >>>>>>> @@ -398,6 +398,7 @@ config LEDS_LP50XX >>>>>>>  config LEDS_LP55XX_COMMON >>>>>>>         tristate "Common Driver for TI/National >>>>>>> LP5521/5523/55231/5562/8501" >>>>>>>         depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || >>>>>>> LEDS_LP8501 >>>>>>> +       depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR >>>>>>>         depends on OF >>>>>>>         select FW_LOADER >>>>>>>         select FW_LOADER_USER_HELPER >>>>>>> >>>>>>> >>>>>> Yes I did >>>>>> >>>>>> That gave unmet dependencies. >>>>>> >>>>>> WARNING: unmet direct dependencies detected for LEDS_LP55XX_COMMON >>>>>>    Depends on [m]: NEW_LEDS [=y] && (LEDS_LP5521 [=n] || >>>>>> LEDS_LP5523 [=m] || LEDS_LP5562 [=y] || LEDS_LP8501 [=y]) && >>>>>> (LEDS_CLASS_MULTI_COLOR [=m] || !LEDS_CLASS_MULTI_COLOR [=m]) && >>>>>> OF [=y] >>>>>>    Selected by [y]: >>>>>>    - LEDS_LP5562 [=y] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=y] >>>>>>    - LEDS_LP8501 [=y] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=y] >>>>>>    Selected by [m]: >>>>>>    - LEDS_LP5523 [=m] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C >>>>>> [=y] && (LEDS_CLASS_MULTI_COLOR [=m] || !LEDS_CLASS_MULTI_COLOR [=m]) >>>>>> >>>>> >>>>> When I was testing that yesterday I also had the same warning at some >>>>> point of testing different Kconfig setups, but with what I showed >>>>> above >>>>> it ceased to appear. Now every time I am doing "make oldconfig" the >>>>> CONFIG_LEDS_LP55XX_COMMON=y entry gets changed to =m with the config >>>>> from the test bot. >>>>> >>>> That is not what I saw in my testing especially after doing a distclean >>> >>> Could you please give your exact steps after "make distclean" and >>> copying test bot config to the kernel root directory? >>> >>> Also, please share the toolchain you're using for tests. >> >> Actually at this stage the toolchain is of lesser relevance. >> >> I've tried once more and indeed the problem shows up. >> >> It is caused by the driver entries doing >> >> "select LEDS_LP55XX_COMMON". >> >> Select sets config to "y" so it conflicts with >> "depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR" >> in the "config LEDS_LP55XX_COMMON". >> >> Your proposed fix will block the possibility of building >> LED_CLASS_MULTI_COLOR as a module when LP55XX drivers >> are enabled so this is also not an option. >> >> Solving this riddle will require some more thinking. >> I haven't analyzed it in detail but maybe "imply" statement from >> kconfig-language.rst could help somehow here. > > The multicolor framework will build as a module if the LED_CLASS is > defined as a module. > > See attached test_defconfig But it will be impossible to enable CONFIG_LEDS_LP50XX without CONFIG_LEDS_CLASS_MULTI_COLOR if you will remove depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR. This is actually why the above entry was needed. LP55XX drivers have to work also without multicolor class. > > defconfig contents > > CONFIG_NEW_LEDS=y > CONFIG_LEDS_CLASS=y > CONFIG_LEDS_CLASS_MULTI_COLOR=m > CONFIG_LEDS_LP50XX=m > CONFIG_LEDS_LP55XX_COMMON=y > CONFIG_LEDS_LP5523=m > CONFIG_LEDS_LP5562=m > CONFIG_LEDS_LP8501=m > > Output is > > CONFIG_NEW_LEDS=y > CONFIG_LEDS_CLASS=y > CONFIG_LEDS_CLASS_MULTI_COLOR=m > CONFIG_LEDS_LP50XX=m > CONFIG_LEDS_LP55XX_COMMON=m > CONFIG_LEDS_LP5523=m > CONFIG_LEDS_LP5562=m > CONFIG_LEDS_LP8501=m > > If any of the children are built in then the MC framework must be built > in as well. > > Dan > > -- Best regards, Jacek Anaszewski