From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Chunyan Zhang <chunyan.zhang@unisoc.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>
Subject: Re: [PATCH 1/3] dt-bindings: clk: sprd: Add UMS9620 support
Date: Thu, 4 Jan 2024 10:31:03 +0100 [thread overview]
Message-ID: <1f66cf69-5d2c-4e15-bf44-4b96a4cc2900@linaro.org> (raw)
In-Reply-To: <CAAfSe-vRLaCZca2anp7iBnHDPUr-oVexSVy7PKYhNDUZ8GGgaw@mail.gmail.com>
On 04/01/2024 10:26, Chunyan Zhang wrote:
>>>> Missing names.
>>>
>>> The names are fixed, but the order are not.
>>
>> Order must be fixed.
Did you read this? It must be. If it is not, your patchset has issues
you must fix.
>>
>>>
>>> For example:
>>> clk_a {
>>> clocks = <&ext_26m>, <&ext_32k>;
>>> clock-names = "ext-26m", "ext-32k";
>>> };
>>>
>>> clk_b {
>>> clocks = <&ext_26m>, <&ext_4m>;
>>> clock-names = "ext-26m", "ext-4m";
>>
>> And here the order is fixed...
>
> The order is not fixed, 'clk_b' will cause dtb_check error, since it
> skips the second one i.e. ext-32k in the clock-names list.
Then why do you use the same compatible for two different devices?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-04 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 8:51 [PATCH 0/3] Add UMS9620 clocks driver and bindings Chunyan Zhang
2023-12-29 8:51 ` [PATCH 1/3] dt-bindings: clk: sprd: Add UMS9620 support Chunyan Zhang
2024-01-04 8:46 ` Krzysztof Kozlowski
2024-01-04 9:09 ` Chunyan Zhang
2024-01-04 9:21 ` Krzysztof Kozlowski
2024-01-04 9:26 ` Chunyan Zhang
2024-01-04 9:31 ` Krzysztof Kozlowski [this message]
2023-12-29 8:51 ` [PATCH 2/3] clk: sprd: Add dt-bindings include file for UMS9620 Chunyan Zhang
2024-01-04 8:48 ` Krzysztof Kozlowski
2023-12-29 8:51 ` [PATCH 3/3] clk: sprd: add support " Chunyan Zhang
2023-12-29 20:02 ` kernel test robot
2023-12-29 20:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f66cf69-5d2c-4e15-bf44-4b96a4cc2900@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chunyan.zhang@unisoc.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).