From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, bgoswami@codeaurora.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
tiwai@suse.com, vkoul@kernel.org, robh+dt@kernel.org,
lee.jones@linaro.org
Subject: Re: [PATCH 04/12] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec
Date: Tue, 24 Jul 2018 12:48:57 +0100 [thread overview]
Message-ID: <1f700d0e-57f0-9d9d-cb32-a12c4c4b7243@linaro.org> (raw)
In-Reply-To: <20180724110602.GA2414@sirena.org.uk>
On 24/07/18 12:06, Mark Brown wrote:
> On Mon, Jul 23, 2018 at 04:54:02PM +0100, Srinivas Kandagatla wrote:
>> This patch adds bindings for wcd9335 audio codec which can support both SLIMbus
>> and I2S/I2C interface.
>
> ...
>
>> +Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC,
>> +It supports both I2S/I2C and SLIMbus audio interfaces.
>
> This is a standalone audio CODEC but it also has a MFD binding? I'd
> have just expected a single binding for a single device.
>
Thanks for the suggestion!
You are right, I should probably remove the mfd bindings totally.
and move them to codec bindings. And register codec and other blocks
like soundwire controller as mfd cells. like wm8994.
--srini
next prev parent reply other threads:[~2018-07-24 11:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 15:53 [PATCH 00/12] mfd: Add support to WCD9335 Audio Codec Srinivas Kandagatla
2018-07-23 15:53 ` [PATCH 01/12] mfd: dt-bindings: Add wcd9335 mfd bindings Srinivas Kandagatla
2018-07-24 5:56 ` Vinod
2018-07-24 11:50 ` Srinivas Kandagatla
2018-07-23 15:54 ` [PATCH 02/12] mfd: wcd9335: add support to wcd9335 core Srinivas Kandagatla
2018-07-23 15:54 ` [PATCH 03/12] mfd: wcd9335: add wcd irq support Srinivas Kandagatla
2018-07-23 15:54 ` [PATCH 04/12] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec Srinivas Kandagatla
2018-07-24 11:06 ` Mark Brown
2018-07-24 11:48 ` Srinivas Kandagatla [this message]
2018-07-23 15:54 ` [PATCH 05/12] ASoC: core: add support to snd_soc_dai_get_channel_map() Srinivas Kandagatla
2018-07-24 11:50 ` Applied "ASoC: core: add support to snd_soc_dai_get_channel_map()" to the asoc tree Mark Brown
2018-07-23 15:54 ` [PATCH 06/12] ASoC: wcd9335: add support to wcd9335 codec Srinivas Kandagatla
2018-07-23 15:54 ` [PATCH 07/12] ASoC: wcd9335: add CLASS-H Controller support Srinivas Kandagatla
2018-07-24 11:59 ` Mark Brown
2018-07-24 12:05 ` Srinivas Kandagatla
2018-07-23 15:54 ` [PATCH 08/12] ASoC: wcd9335: add basic controls Srinivas Kandagatla
2018-07-25 12:04 ` Vinod
2018-07-27 9:55 ` Srinivas Kandagatla
2018-07-23 15:54 ` [PATCH 09/12] ASoC: wcd9335: add playback dapm widgets Srinivas Kandagatla
2018-07-23 15:54 ` [PATCH 10/12] ASoC: wcd9335: add capture " Srinivas Kandagatla
2018-07-23 15:54 ` [PATCH 11/12] ASoC: wcd9335: add audio routings Srinivas Kandagatla
2018-07-23 15:54 ` [PATCH 12/12] ASoC: apq8096: Add support to Analog audio via WCD9335 slim Srinivas Kandagatla
2018-07-25 16:24 ` Mark Brown
2018-07-24 5:53 ` [PATCH 00/12] mfd: Add support to WCD9335 Audio Codec Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f700d0e-57f0-9d9d-cb32-a12c4c4b7243@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).