[PATCH v4 1/5] dt-bindings: power: Extend battery chemistry with capacitor

[PATCH v4 1/5] dt-bindings: power: Extend battery chemistry with capacitor

[Mike Looijmans]

Another technology to store energy is a (super)capacitor.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---

(no changes since v1)

 Documentation/devicetree/bindings/power/supply/battery.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml
index 491488e7b970..a22c97dfad88 100644
--- a/Documentation/devicetree/bindings/power/supply/battery.yaml
+++ b/Documentation/devicetree/bindings/power/supply/battery.yaml
@@ -44,6 +44,7 @@ properties:
       - const: lithium-ion-polymer
       - const: lithium-ion-iron-phosphate
       - const: lithium-ion-manganese-oxide
+      - const: capacitor
 
   over-voltage-threshold-microvolt:
     description: battery over-voltage limit
-- 
2.34.1


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl

Please consider the environment before printing this e-mail

[PATCH v4 4/5] dt-bindings: power: supply: ltc3350-charger: Add bindings

[Mike Looijmans]

The LTC3350 is a backup power controller that can charge and monitor
a series stack of one to four supercapacitors.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

(no changes since v3)

Changes in v3:
Fix $id after rename to lltc,ltc3350.yaml

Changes in v2:
Rename to lltc,ltc3350.yaml
Fix spaces and indentation

 .../bindings/power/supply/lltc,ltc3350.yaml   | 54 +++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml

diff --git a/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml b/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml
new file mode 100644
index 000000000000..dca7fe0f0d8f
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/lltc,ltc3350.yaml
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (C) 2024 Topic Embedded Products
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/lltc,ltc3350.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Linear Technology (Analog Devices) LTC3350 Supercap Charger
+
+maintainers:
+  - Mike Looijmans <mike.looijmans@topic.nl>
+
+description: |
+  The LTC3350 is a High Current Supercapacitor Backup Controller and System
+  Monitor.
+  Specifications about the charger can be found at:
+    https://www.analog.com/en/products/ltc3350.html
+
+properties:
+  compatible:
+    enum:
+      - lltc,ltc3350
+
+  reg:
+    maxItems: 1
+
+  lltc,rsnsc-micro-ohms:
+    description: Capacitor charger sense resistor in microohm.
+    minimum: 1000
+
+  lltc,rsnsi-micro-ohms:
+    description: Input current sense resistor in microohm.
+    minimum: 1000
+
+required:
+  - compatible
+  - reg
+  - lltc,rsnsc-micro-ohms
+  - lltc,rsnsi-micro-ohms
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      charger: battery-charger@9 {
+        compatible = "lltc,ltc3350";
+        reg = <0x9>;
+        lltc,rsnsc-micro-ohms = <10000>;
+        lltc,rsnsi-micro-ohms = <10000>;
+      };
+    };
-- 
2.34.1


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl

Please consider the environment before printing this e-mail

Re: [PATCH v4 1/5] dt-bindings: power: Extend battery chemistry with capacitor

[Krzysztof Kozlowski]

On 15/04/2024 10:13, Mike Looijmans wrote:
> Another technology to store energy is a (super)capacitor.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
> 
> (no changes since v1)
> 
>  Documentation/devicetree/bindings/power/supply/battery.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml
> index 491488e7b970..a22c97dfad88 100644
> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml
> @@ -44,6 +44,7 @@ properties:
>        - const: lithium-ion-polymer
>        - const: lithium-ion-iron-phosphate
>        - const: lithium-ion-manganese-oxide
> +      - const: capacitor

Please keep some sort of order... everyone insists on adding to the end
of the lists...

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v4 1/5] dt-bindings: power: Extend battery chemistry with capacitor

[Mike Looijmans]

On 15-04-2024 17:24, Krzysztof Kozlowski wrote:
> On 15/04/2024 10:13, Mike Looijmans wrote:
>> Another technology to store energy is a (super)capacitor.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>>
>> (no changes since v1)
>>
>>   Documentation/devicetree/bindings/power/supply/battery.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml
>> index 491488e7b970..a22c97dfad88 100644
>> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml
>> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml
>> @@ -44,6 +44,7 @@ properties:
>>         - const: lithium-ion-polymer
>>         - const: lithium-ion-iron-phosphate
>>         - const: lithium-ion-manganese-oxide
>> +      - const: capacitor
> Please keep some sort of order... everyone insists on adding to the end
> of the lists...

Could make it alphabetical, but that requires re-ordering the existing 
ones so "lithium" sorts before "nickel".

I think the intention here was that the order is the same as the 
matching defines in power-supply.h


> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>

-- 
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl

Re: [PATCH v4 1/5] dt-bindings: power: Extend battery chemistry with capacitor

[Krzysztof Kozlowski]

On 22/04/2024 09:50, Mike Looijmans wrote:
> On 15-04-2024 17:24, Krzysztof Kozlowski wrote:
>> On 15/04/2024 10:13, Mike Looijmans wrote:
>>> Another technology to store energy is a (super)capacitor.
>>>
>>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>>> ---
>>>
>>> (no changes since v1)
>>>
>>>   Documentation/devicetree/bindings/power/supply/battery.yaml | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml
>>> index 491488e7b970..a22c97dfad88 100644
>>> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml
>>> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml
>>> @@ -44,6 +44,7 @@ properties:
>>>         - const: lithium-ion-polymer
>>>         - const: lithium-ion-iron-phosphate
>>>         - const: lithium-ion-manganese-oxide
>>> +      - const: capacitor
>> Please keep some sort of order... everyone insists on adding to the end
>> of the lists...
> 
> Could make it alphabetical, but that requires re-ordering the existing 
> ones so "lithium" sorts before "nickel".

So just put it at beginning, less sorting later.

> 
> I think the intention here was that the order is the same as the 
> matching defines in power-supply.h

There is no such binding as power-supply.h. And other headers do not
matter, they are not bindings.

Best regards,
Krzysztof

Re: [PATCH v4 1/5] dt-bindings: power: Extend battery chemistry with capacitor

[Mike Looijmans]

On 22-04-2024 13:56, Krzysztof Kozlowski wrote:
> On 22/04/2024 09:50, Mike Looijmans wrote:
>> On 15-04-2024 17:24, Krzysztof Kozlowski wrote:
>>> On 15/04/2024 10:13, Mike Looijmans wrote:
>>>> Another technology to store energy is a (super)capacitor.
>>>>
>>>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>>>> ---
>>>>
>>>> (no changes since v1)
>>>>
>>>>    Documentation/devicetree/bindings/power/supply/battery.yaml | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml
>>>> index 491488e7b970..a22c97dfad88 100644
>>>> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml
>>>> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml
>>>> @@ -44,6 +44,7 @@ properties:
>>>>          - const: lithium-ion-polymer
>>>>          - const: lithium-ion-iron-phosphate
>>>>          - const: lithium-ion-manganese-oxide
>>>> +      - const: capacitor
>>> Please keep some sort of order... everyone insists on adding to the end
>>> of the lists...
>> Could make it alphabetical, but that requires re-ordering the existing
>> ones so "lithium" sorts before "nickel".
> So just put it at beginning, less sorting later.

Ok. I'll wait a bit for comments on the other parts, before sending a v6 
of the series.


>
>> I think the intention here was that the order is the same as the
>> matching defines in power-supply.h
> There is no such binding as power-supply.h. And other headers do not
> matter, they are not bindings.

Clear, thanks.


-- 
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl