From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37EE4A43F3 for ; Mon, 5 Oct 2026 14:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791210472; cv=none; b=W4acgNxgyZHr8FzXpdocwC2caiaXOcqYn5BsnYDdA186p7U0fBbuKOya+81Add5UiRvlFEjm0etUTsRwzEeJUjdpt2/gy1ueEIiLdMYjv59Jqu34OSsiM/FOnueFLEo3kyhWjdHFtRklBRcao3s+iJ+52oGnae9MKcQgglBmA7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791210472; c=relaxed/simple; bh=NRu7J4NYxclsy403NiQBS3+9SXKidUTOhMwJxWH8fP8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=GgX1yA4RcBJ9X5YAol3LSLCp4h97atOIphMwTXRzwBjMd/1Ob4AdQhkTR6lbwK/SFUX/D2vbuc7N/Qhggzq7qZZLcMW8fypXpaoHYxZdRa41SL0XkDJVsYishF7VhKU5g1Kpm3ud1tdNZLxevxYTVKlKhLVSvbIam+g/rjQEwcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=VDvAt7da; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="VDvAt7da" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49ff9642c57so7010885e9.0 for ; Mon, 05 Oct 2026 07:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1791210461; x=1791815261; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6SMh/wrH0eouNlX+QzH0eHRPiSn4jmUrEiB6WQs9PRg=; b=VDvAt7daPuTxliM72mxvq2Kzv32VDdtX1AYMKR3cr3EfYL1UcUMqurcs0zzKmpASXD /dQBNALQ5c/yLjTmJ6TmCZ4rmy7dWaoeGSbwrb9sYHgHgpysJ+qvttACoJgR7gy4DrMy 2lk1k+Cvvi2U0TNkz7Xm2Dx4yi54y8dvanqSus2c41OH4P+3ItsZEPny/7NSdyjyjdqn FtEtHTgARJvkRvvTzgrT2WK+MAVH8PpKhVNTiISzES3TR8e+es96LQswiqJxsXGcEDFo A+tuVYfAw4S3fBH2Mx6hH8eNMqLUHxDt0HS1xBpdon3slkXAeU5HWRmRV00d8RXWnaBt M3HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791210461; x=1791815261; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6SMh/wrH0eouNlX+QzH0eHRPiSn4jmUrEiB6WQs9PRg=; b=rk7yKqhLEJZV5VbifGJR6Uhhvaf1y7xaV7r1z9u97bOFUxZzdSFh412NSqmptk/Jzo iwDOAspSeTgO8UqpoJBgSv/qjHjfdgCPaMv/bAuokbf+N/HPStudSgMnnRDwxIq/PSbn ynTGb+c3fBkxYaaNYmLtrXpyjoSo0rKV4AMSJBOZ7iJ3pcqDjYnfKFOr8MkQp9+VeNLf 2jeOmb4J+idBugNhAFilwXPlf7isbr8y0M8Uano40/U6xqnVB2muGSxqtii4aouF96NC /V9D+zyrUIHl7DOXlMN469qNuaEFMRJot0eXDPCnPor3bLj3osTOpLByyk/46QfPuVdl gnug== X-Forwarded-Encrypted: i=1; AKwUvBzg4miGc0AbBdJRLrXLEZFcQiZrx1kIyON0jJ2kUB9uPvGNLbBIjowPSBOcVPntz/1qd/tP9blxbsLX@vger.kernel.org X-Gm-Message-State: AFuF++n04gES19StZbdkBMttW6Ckiw75vKQ+dBeNE+zD2vToxFXjVM8E hp4kJDwFUaZwDkW0xFFADZOejiZ9w4t8M5QTDfX5MDMOCCpgqph4315XaDHjcnJCZ+w= X-Gm-Gg: AYBFou1XsejiHDfixWtoXY5+HNgShJKY6glFXUJKXC4rg4MEZP3Mwu47DPAORzjbAKb Us/GSY71eW21LYrgDjaOKAnnU8S1Y/ruwAE8z1skg1R9EQK/Uw7ZOW0bVCC6JJxaayUlJT1Y8Nj T7v4joO5Ty1/hY5JgPSffl4AtF3+jY7x1Rh5vj9jyMd9FgoTym7O1hdweVGh25uW8+rkh2VHwwg tGDpVNPsjH59vSxEc4OXrpQ5aif5YIhrAWmsJKOW7nNmsykrqRtiyksF16UfvoijS2VL/PUkjzM pLQ2j+XT9hXTeyC0X/M2qcCbqvKTQhQLM5hAegB+ezRk1gDod6JXe2W/oNQDfT+DLYQVG5hjHzR /YeKv3THfKtdHOZ755TYIyxeifhQaNcrgOhvoiGZZkyEWN8l98er+Un3poFNzfbKo0VMwKjCsh9 s15RMy6VI6Ndk6AiYx70sYu68YtocSrdmxUCfVv2lvwso6fJw8rk6SrD7XKI5HMytPMCDbet7UC LBYOwq1LimVmm4= X-Received: by 2002:a05:600c:190d:b0:49f:c5aa:9ef4 with SMTP id 5b1f17b1804b1-4a02753fc8emr188561755e9.8.1791210460694; Mon, 05 Oct 2026 07:27:40 -0700 (PDT) Received: from localhost (90-182-211-1.rcp.o2.cz. [90.182.211.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a162e867e8sm325870355e9.15.2026.10.05.07.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2026 07:27:39 -0700 (PDT) From: Jerome Brunet To: Vyacheslav Yurkov via B4 Relay , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Brian Masney , Brian Masney , Jerome Brunet , Jyri Sarha Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Vyacheslav Yurkov , Vyacheslav Yurkov Subject: Re: [PATCH v8 1/2] dt-bindings: clock: gpio-gate-clock: Add a new compatible string In-Reply-To: <20260927-feature-clock-guard-v8-1-630938e302a1@bruker.com> References: <20260927-feature-clock-guard-v8-0-630938e302a1@bruker.com> <20260927-feature-clock-guard-v8-1-630938e302a1@bruker.com> Date: Mon, 05 Oct 2026 16:27:37 +0200 Message-ID: <1jbj986x46.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Sun 27 Sep 2026 at 14:59, Vyacheslav Yurkov via B4 Relay wrote: > From: Vyacheslav Yurkov > > Extend the binding to be used also for gpio-locked-fixed-clock. > A GPIO-locked fixed clock provider exposes a fixed-rate clock whose > availability depends on one or more GPIO lock-status signals. > > Some hardware designs provide fixed-frequency clocks generated outside > software control, such as by FPGA-resident PLLs. While the clock rate is > fixed, a separate GPIO signal indicates whether the clock source is > locked and producing a valid output. > > Signed-off-by: Vyacheslav Yurkov > --- > .../devicetree/bindings/clock/gpio-gate-clock.yaml | 32 ++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml b/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml > index d09d0e3f0c6e..1ad87c8b36b9 100644 > --- a/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml > @@ -11,7 +11,9 @@ maintainers: > > properties: > compatible: > - const: gpio-gate-clock > + enum: > + - gpio-gate-clock > + - gpio-locked-clock I think this name does not illustrate well what your driver does anymore. As I noted before, locked if very much PLL centric. enabled ? While the driver sits in the same C file (clk-gpio), I don't the binding doc should. I'll defer to the DT folks on this but I think it would more approriate with a different yaml. clk-gpio-gate and clk-gpio-mux have their own binding doc > > clocks: > maxItems: 1 > @@ -23,10 +25,29 @@ properties: > description: GPIO reference for enabling and disabling the clock. > maxItems: 1 > > + enabled-gpios: > + description: GPIO that indicates whether the clock is enabled or disabled. > + maxItems: 1 > + > required: > - compatible > - '#clock-cells' > - - enable-gpios > + > +allOf: > + - if: > + properties: > + compatible: > + const: gpio-gate-clock > + then: > + required: > + - enable-gpios > + - if: > + properties: > + compatible: > + const: gpio-locked-clock I think there should be a property in here to express how long you are willing to wait for the clock to be enabled. IOW the lock timeout. > + then: > + required: > + - enabled-gpios > > additionalProperties: false > > @@ -40,3 +61,10 @@ examples: > #clock-cells = <0>; > enable-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>; > }; > + > + clk_gpio_locked { > + compatible = "gpio-locked-clock"; > + #clock-cells = <0>; > + clocks = <&pll>; > + enabled-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>; > + }; > > -- > 2.34.1 > > -- Jerome