From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD2E020A5C2 for ; Thu, 20 Mar 2025 08:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742460401; cv=none; b=OsfsLnUDHY7rFC+s9V38LZVIA2ejg/ZcgIO3MHXjhidgzcjSgTErzzSOxlTlsbTX9A1gS7anevQAiRl01ql0zrdp3zyrgLNtPztvhhRQQjF3tJXoErWuErBStOOw9hnZK+NdTomvzO5BJVYJT7J4scKLBUB5NJbvA5cZgcTSX+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742460401; c=relaxed/simple; bh=jx2e6DSoT90IewT4q/0d/COQs4LVEYMYiIPzr0ZRhi0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=d/r2vJt8LO19F/ZeqNsPJQm03mrMkakyaM4USu4RFjMcOZ3ybj1Nc1mkeZK0r1ozCaUev8tRdPcpcOeDuzzjQiilQlKM9m7fpKU1iVPYF5BKyPHzWf1MwYwyPjWVJ5aNF6VTcPN2eeh89ngbH5bBaEji6ZKDPR0xjtlK5VRhbmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=V8i9susw; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="V8i9susw" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43cfebc343dso3048175e9.2 for ; Thu, 20 Mar 2025 01:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1742460397; x=1743065197; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=O3QH3qUlNH/gqSM8rGalO1GesljsIqna87D8tGVSkJw=; b=V8i9suswyIDMZGYzXRPSOvmAdpelFB8GcebKr1nJvQc1sV/NsH8JMC0OP4WlbY2AOD 0Ixyh3iRh1LZwHYMEOiioTvQTeVGbC2PthEDqGb8V9PBa7fi8Ws3NieOTrHVl0p6ubqD vCejr6kPQD2b7eD1ogvWyQ0C0YUNS1hmm7UmUmh7COMyLYlJWi7BrEOIC5E1JmQAxdn6 p//hpigwDGvpN+rXzXtCvdAhzwzgbmfjo3mEXjo7cIYTP/mly92RLbXue2D2leKPEZNl wFmfO88M8uJHCombhWI4eutoDV07l05650VRVs/aAlKDvQDiGVkn02wehkVgicQWlEEu sDlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742460397; x=1743065197; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O3QH3qUlNH/gqSM8rGalO1GesljsIqna87D8tGVSkJw=; b=sSbcKdS672GJ0w0FBo2gNt80nJCbSkw4+dFSI63Pz9FybnfSnK6aef57Zax16cigtT MaKLwxep25VN/9KmhVCtPUe9altKbdRIriwBJCM8oWoWE3MhCUP0MdppkYfxnkAveR2B vgu9COZm18p9JtUVSOtuwKB2kFU94nHPnTdJ2RToN3+6fzis8Cz9/OoiObScpzkU79fn s2xZOjcHVzoZYLeWBuL25qUR0DeHW/bCDHyj5em/jm3mb8Ura2JelZ09E3HyHI08TY47 FLJUFQfQ1nUodsP3GozbeZ+oVveEsI8s3K35sSir072R44RfM3egSxlCTBd4YXFG6+tM mqvw== X-Forwarded-Encrypted: i=1; AJvYcCXY5KIPXSQEIsHh9bXsqnUBmJfIl82lG0IVff2DdwCrYXx+rx90kAMi7gJXsvwitOZMG31NUHIDtRwf@vger.kernel.org X-Gm-Message-State: AOJu0YxkcPbqZEDDvV6lcrzA+AE5Yl3YHZNf9LiT04kKTpXzh+TGls5h wRgdmDYCi4D+NnT5ER5s/qgvoyNW6fgoYAI7L/W7DeQcsZMcAIm3sBbjjWAVz0k= X-Gm-Gg: ASbGncsS5s/E7IvPb5L+5Fnf/IHhBo0iMmRQbqyRAMZGbB2lZlg0IjIHePYWtB1jj8e d8ybHXIX1rGsocHtskXcis4V18FucCJDodyDQQi8xjoFw9IitPL6ToDEEF0QUMIOkEcYMuH78FA SzSfvbtLDxaML430btzXVCpgkrXWug+7jlndqEZQPhDy8VuM3Hygrt1Mh9aSzwpgrbJ9DLiBt4F QTrgfGlNTiEDIWCDTNdzFeMfP2cVg9C+URFq/72LYwSIFrVtwpicwNWVEczKBWV1HV83Cu8oaFf 08HHDQlvLDoxWTWkZZMuWa4XoGItkvoAeYLQjNIWFJya X-Google-Smtp-Source: AGHT+IHQm6xIAgW16c9rSJQfuwSOkpxhl2OJe1D/zAy21xgweiekDmWGRfU5wzJOyEV/LHZraSbP0g== X-Received: by 2002:a05:600c:3b20:b0:43c:fd1b:d6d6 with SMTP id 5b1f17b1804b1-43d43842e8bmr48409055e9.31.1742460396893; Thu, 20 Mar 2025 01:46:36 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:e0ba:db2b:7cf4:d967]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-395cb318afbsm23804353f8f.72.2025.03.20.01.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 01:46:36 -0700 (PDT) From: Jerome Brunet To: jiebing chen via B4 Relay Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Michael Turquette , Stephen Boyd , jiebing.chen@amlogic.com, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com Subject: Re: [PATCH v4 4/6] ASoC: meson: g12a-toacodec: Add s4 tocodec driver In-Reply-To: <20250319-audio_drvier-v4-4-686867fad719@amlogic.com> (jiebing chen via's message of "Wed, 19 Mar 2025 15:04:47 +0800") References: <20250319-audio_drvier-v4-0-686867fad719@amlogic.com> <20250319-audio_drvier-v4-4-686867fad719@amlogic.com> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Thu, 20 Mar 2025 09:46:36 +0100 Message-ID: <1jfrj82ioj.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed 19 Mar 2025 at 15:04, jiebing chen via B4 Relay wrote: > From: jiebing chen > > S4 tocodec support 8 lane to input, It need to enable > bclk and mclk control bit when work > > Signed-off-by: jiebing chen > --- > sound/soc/meson/g12a-toacodec.c | 46 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/sound/soc/meson/g12a-toacodec.c b/sound/soc/meson/g12a-toacodec.c > index 531bb8707a3ec4c47814d6a0676d5c62c705da75..88f9adabb3b5d7d8881fa110f1d0d51e9ac9c60e 100644 > --- a/sound/soc/meson/g12a-toacodec.c > +++ b/sound/soc/meson/g12a-toacodec.c > @@ -41,6 +41,9 @@ > #define CTRL0_BCLK_SEL_LSB 4 > #define CTRL0_MCLK_SEL GENMASK(2, 0) > > +#define CTRL0_BCLK_ENABLE_SHIFT 30 > +#define CTRL0_MCLK_ENABLE_SHIFT 29 > + > #define TOACODEC_OUT_CHMAX 2 > > struct g12a_toacodec { > @@ -129,6 +132,10 @@ static const struct snd_kcontrol_new g12a_toacodec_out_enable = > SOC_DAPM_SINGLE_AUTODISABLE("Switch", TOACODEC_CTRL0, > CTRL0_ENABLE_SHIFT, 1, 0); > > +static const struct snd_kcontrol_new s4_toacodec_clk_enable = > + SOC_DAPM_DOUBLE("Switch", TOACODEC_CTRL0, > + CTRL0_BCLK_ENABLE_SHIFT, CTRL0_MCLK_ENABLE_SHIFT, 1, 0); > + I think I remember commenting on this already. > static const struct snd_soc_dapm_widget g12a_toacodec_widgets[] = { > SND_SOC_DAPM_MUX("SRC", SND_SOC_NOPM, 0, 0, > &g12a_toacodec_mux), > @@ -143,6 +150,19 @@ static const struct snd_soc_dapm_widget sm1_toacodec_widgets[] = { > &g12a_toacodec_out_enable), > }; > > +/* > + * FIXME: > + * On this soc, tocodec need enable mclk and bclk control > + * just enable it when dapm power widget power on. > + */ > + > +static const struct snd_soc_dapm_widget s4_toacodec_widgets[] = { > + SND_SOC_DAPM_MUX("SRC", TOACODEC_CTRL0, CTRL0_BCLK_ENABLE_SHIFT, 0, > + &sm1_toacodec_mux), > + SND_SOC_DAPM_SWITCH("OUT EN", TOACODEC_CTRL0, CTRL0_MCLK_ENABLE_SHIFT, 0, > + &g12a_toacodec_out_enable), > +}; > + > static int g12a_toacodec_input_hw_params(struct snd_pcm_substream *substream, > struct snd_pcm_hw_params *params, > struct snd_soc_dai *dai) > @@ -236,6 +256,10 @@ static const struct snd_kcontrol_new sm1_toacodec_controls[] = { > SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 3, 0), > }; > > +static const struct snd_kcontrol_new s4_toacodec_controls[] = { > + SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 7, 0), > +}; > + > static const struct snd_soc_component_driver g12a_toacodec_component_drv = { > .probe = g12a_toacodec_component_probe, > .controls = g12a_toacodec_controls, > @@ -258,6 +282,17 @@ static const struct snd_soc_component_driver sm1_toacodec_component_drv = { > .endianness = 1, > }; > > +static const struct snd_soc_component_driver s4_toacodec_component_drv = { > + .probe = sm1_toacodec_component_probe, > + .controls = s4_toacodec_controls, > + .num_controls = ARRAY_SIZE(s4_toacodec_controls), > + .dapm_widgets = s4_toacodec_widgets, > + .num_dapm_widgets = ARRAY_SIZE(s4_toacodec_widgets), > + .dapm_routes = g12a_toacodec_routes, > + .num_dapm_routes = ARRAY_SIZE(g12a_toacodec_routes), > + .endianness = 1, > +}; > + > static const struct regmap_config g12a_toacodec_regmap_cfg = { > .reg_bits = 32, > .val_bits = 32, > @@ -278,6 +313,13 @@ static const struct g12a_toacodec_match_data sm1_toacodec_match_data = { > .field_bclk_sel = REG_FIELD(TOACODEC_CTRL0, 4, 6), > }; > > +static const struct g12a_toacodec_match_data s4_toacodec_match_data = { > + .component_drv = &s4_toacodec_component_drv, > + .field_dat_sel = REG_FIELD(TOACODEC_CTRL0, 19, 20), > + .field_lrclk_sel = REG_FIELD(TOACODEC_CTRL0, 12, 14), > + .field_bclk_sel = REG_FIELD(TOACODEC_CTRL0, 4, 6), > +}; > + > static const struct of_device_id g12a_toacodec_of_match[] = { > { > .compatible = "amlogic,g12a-toacodec", > @@ -287,6 +329,10 @@ static const struct of_device_id g12a_toacodec_of_match[] = { > .compatible = "amlogic,sm1-toacodec", > .data = &sm1_toacodec_match_data, > }, > + { > + .compatible = "amlogic,s4-toacodec", > + .data = &s4_toacodec_match_data, > + }, > {} > }; > MODULE_DEVICE_TABLE(of, g12a_toacodec_of_match); -- Jerome