From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE5231494C2 for ; Tue, 22 Oct 2024 09:51:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729590689; cv=none; b=shL5K+uLJOETAUuXl3y+YGCNaBJ2x7yf7MAEeuxiL1c2eSCiRyhO4f/q4/R4/OwqZnKOWhDW9eKk0owQ2UAeBtaYawKvZFId2zTxWLM8mLwJukudbdmjsOkiuzLG/DeKDn5AZiUEE4xYxOTL5vrzSmG2UKNbEyewudRbpyoZaG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729590689; c=relaxed/simple; bh=JsWWmLr80OvZZgtqzSLI+3NO59wkVjAXXzhBndm6rPs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=YdHo+S7Vm2WvSH8mBQfVN5je8OCTH5QFeBWATsprFoGwLdYhbD/0xg3yVY7kiikXcQzkBAcSowhFVemdXj9XkQI8x1iqxmOcfx1RT2p0N4Ka079St0gUAmDSz/3a7MBT4H1Y2GThgxjPZ7yxffmZ/KAl4/gEBPhsOBya+aF/+rQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=fJbPglXI; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="fJbPglXI" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4315df7b43fso54143845e9.0 for ; Tue, 22 Oct 2024 02:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1729590685; x=1730195485; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=O9uhSsPjuLDUWqYOIT4n8318oMtxdXxpij17XIrTsXE=; b=fJbPglXIIS2dknfgtbeunLcmjIXpFQlBmw2BrAwiOAVZu/rdZj3Y1BtqdRg7g9kyZ2 KhbNffz+hPm0J7WJIASZ6gyLBudGKgRGmBEHYcw0DaMlPYhGucp/SLET0JPqenbhLtQX qmU0f5Hh6tMoJFEY12pF2sTMa5ybFiiffOmCsMzR12mB6dvVSQVym8q8QjYFK6HjiB9R ZIi+pjGd6feUpyy9J15oOzryXiIffbLE+d+3Hh96C8UbUtykTGCBM3nw9gyOqW4BLk8l nm9zZzkdAus6FSw6wJHglp9sjPmrGF46cd2GugZ+7niwhSsjuFuc2Ya4Z6JMxorbjwnm +vyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729590685; x=1730195485; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O9uhSsPjuLDUWqYOIT4n8318oMtxdXxpij17XIrTsXE=; b=ubt4938BbVBrKTTg3/s5uL6KO1Z5iWJxz0jFVK9ipheLMm7FfInH0hV7Bt6QE7RGtx LYfFJHrI1A4vaLjIA/jkkCEk+6W66/P0le9osFSOalDemAwORiNj3uE+u1KV65o2foDa sVq9nS8UPvu1Py/cmkd0HxIRTRUJ4/2s2yKZoETxpW6S+3WHAZ7PVEVROeRRqRrU0u2p a1t0ZZfyeK6R7YopZ6PO5RnHeD02yEDjLRrkMa26oaN9l0M0HUukmvFqi7ic5kfulLDC Vq/e6r6TtsPAnAW8cdkGwkb515SBwNvZ6Uekg8cwjANXfJXamjBWgX68Zq/ZJc/jYbFU fLpA== X-Forwarded-Encrypted: i=1; AJvYcCUgWNVzJaF0cmfXGbSphRtqw5Fr3MWZlypb5/r1lHZdmGE6jSRd3wAmGct5KYMYmk25dtbXTfGCxyTO@vger.kernel.org X-Gm-Message-State: AOJu0YzquxgKZnSur0axcJ+DIijx7ZW0HOIWpqtboE3d8mkUs77HmfUM Xi4Sewu2Ik7wXDrkHzpb7tvOS0CVq1+ZaqXfEJKJ3QAPFZcGcQ5wSPfo62igILSIQ0oi+U8+VVh Ee9U= X-Google-Smtp-Source: AGHT+IG4BjZjQ2Z2dqGHg8e13po3OOXPlOkZEZh2gmQz0kEl9ezHR/+UkwbK17+DbKxR73ieabZKcw== X-Received: by 2002:a05:600c:6747:b0:430:5356:ac92 with SMTP id 5b1f17b1804b1-4316161fb1dmr109088635e9.7.1729590685185; Tue, 22 Oct 2024 02:51:25 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:ef1c:ae40:1300:20c6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f570de0sm83095085e9.6.2024.10.22.02.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 02:51:24 -0700 (PDT) From: Jerome Brunet To: Jan Dakinevich Cc: Conor Dooley , , Kevin Hilman , "Krzysztof Kozlowski" , , , , , Martin Blumenstingl , Michael Turquette , Neil Armstrong , Philipp Zabel , Rob Herring , Stephen Boyd Subject: Re: [RFC PATCH v4 0/5] Add A1 Soc audio clock controller driver In-Reply-To: <20240913121152.817575-1-jan.dakinevich@salutedevices.com> (Jan Dakinevich's message of "Fri, 13 Sep 2024 15:11:47 +0300") References: <20240913121152.817575-1-jan.dakinevich@salutedevices.com> Date: Tue, 22 Oct 2024 11:51:24 +0200 Message-ID: <1jplnsjwir.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri 13 Sep 2024 at 15:11, Jan Dakinevich wrote: > This series adds support for audio clock and reset controllers on A1 SoC family. > Split the reset part out of the series (I'd suggest adding VAD reset support while at it). Also remove the DT patch, since it will depends on both patchset. Drop the RFC tag, at v4 I think that phase is over. > Dependency: [4] > > Changes v3 [3] -> v4 > - Use auxiliary reset device implemented in [4] > - Split the driver into files > - Use common with axg-audio yaml schema > - Unify clock-names with axg-audio > > Changes v2 [2] -> v3 > - reset: > * added auxiliary device > - yaml: > * added declaration of optional clocks > * fixed names in example and another cosmetics > - clocks: > * reworked naming > * stop using of "core" clock name > * fixed wrong parenting > > Changes v1 [1] -> v2: > - Detached from v1's series (patch 2, 3, 4, 25). > - Reuse some of defines from axg-audio; > - Split the controller into two memory regions. > > Links: > [1] https://lore.kernel.org/lkml/20240314232201.2102178-1-jan.dakinevich@salutedevices.com/ > [2] https://lore.kernel.org/lkml/20240328010831.884487-1-jan.dakinevich@salutedevices.com/ > [3] https://lore.kernel.org/lkml/20240419125812.983409-1-jan.dakinevich@salutedevices.com/ > [4] https://lore.kernel.org/lkml/9a4377fe27d8eb940399e452b68fb5a6d678929f.camel@pengutronix.de/ > > Jan Dakinevich (5): > reset: amlogic: add support for A1 SoC in auxiliary reset driver > clk: meson: axg: share the set of audio helper macro > dt-bindings: clock: axg-audio: document A1 SoC audio clock controller > driver > clk: meson: a1: add the audio clock controller driver > arm64: dts: meson: a1: add the audio clock controller > > .../clock/amlogic,axg-audio-clkc.yaml | 3 + > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 48 +++ > drivers/clk/meson/Kconfig | 14 + > drivers/clk/meson/Makefile | 3 + > drivers/clk/meson/a1-audio-clkc.c | 359 ++++++++++++++++++ > drivers/clk/meson/a1-audio-drv.c | 104 +++++ > drivers/clk/meson/a1-audio-vad-clkc.c | 85 +++++ > drivers/clk/meson/a1-audio.h | 131 +++++++ > drivers/clk/meson/axg-audio.c | 138 +------ > drivers/clk/meson/meson-audio.h | 143 +++++++ > drivers/reset/amlogic/reset-meson-aux.c | 9 + > .../dt-bindings/clock/amlogic,a1-audio-clkc.h | 122 ++++++ > .../reset/amlogic,meson-a1-audio-reset.h | 29 ++ > 13 files changed, 1051 insertions(+), 137 deletions(-) > create mode 100644 drivers/clk/meson/a1-audio-clkc.c > create mode 100644 drivers/clk/meson/a1-audio-drv.c > create mode 100644 drivers/clk/meson/a1-audio-vad-clkc.c > create mode 100644 drivers/clk/meson/a1-audio.h > create mode 100644 drivers/clk/meson/meson-audio.h > create mode 100644 include/dt-bindings/clock/amlogic,a1-audio-clkc.h > create mode 100644 include/dt-bindings/reset/amlogic,meson-a1-audio-reset.h -- Jerome